Cant get images to upload corectly - In way over my head...

[wbent79]

Hey guys,

For some reason I cant get this to work... The original problem was: only jpeg images would upload and display.

This is the image code I am working with.

Any help would be greatly appreciated.

Thanks!

if(isset($_FILES["photo1"]["tmp_name"])&& $_FILES["photo1"]["tmp_name"]!="")
		{
			$file_temp = $_FILES['photo1']['tmp_name'];	
			$original_file_name = $_FILES['photo1']['name'];

		$new_file_name = time().$original_file_name;			
		$filepath = "../temp_files/".$new_file_name;				

		move_uploaded_file( $file_temp , $filepath );

		// Creating Full Image
		$thumbnail = "FULL".$new_file_name;
		$thumbnailpath = "../temp_files/".$thumbnail;			
		$imageBoxSize = 207;
		list($fileWidth,$fileHeight, $image_type)=getimagesize($filepath);								

		if($fileHeight > $fileWidth)
			{$unit = $fileWidth/$fileHeight;		$width = $imageBoxSize * $unit;		$height = $imageBoxSize;}
		else
			{$unit = $fileHeight/$fileWidth; 	$height = $imageBoxSize * $unit;	$width = $imageBoxSize;}	

		switch ($image_type)
		{
			case 1: $src = imagecreatefromgif($filepath); break;
			case 2: $src = imagecreatefromjpeg($filepath);  break;
			case 3: $src = imagecreatefrompng($filepath); break;
			default:  trigger_error('Unsupported filetype!', E_USER_WARNING);  break;
		}
		$tmp = imagecreatetruecolor($width,$height);
		imagecopyresampled($tmp,$src,0,0,0,0,$width,$height,$fileWidth,$fileHeight);
		if(imagejpeg($tmp,$thumbnailpath,100));

		//Creating Thumbnail
		$thumbnail = "TN".$new_file_name;
		$thumbnailpath = "../temp_files/".$thumbnail;			
		$imageBoxSize = 50;				
		list($fileWidth,$fileHeight)=getimagesize($filepath);						

		if($fileHeight > $fileWidth)
			{$unit = $fileWidth/$fileHeight;		$width = $imageBoxSize * $unit;		$height = $imageBoxSize;}
		else
			{$unit = $fileHeight/$fileWidth; 	$height = $imageBoxSize * $unit;	$width = $imageBoxSize;}	

		$src = imagecreatefromjpeg($filepath);
		$tmp = imagecreatetruecolor($width,$height);
		imagecopyresampled($tmp,$src,0,0,0,0,$width,$height,$fileWidth,$fileHeight);
		if(imagejpeg($tmp,$thumbnailpath,100));	

		//Creating MainPage Thumbnail
		$thumbnail = "MAIN".$new_file_name;
		$thumbnailpath = "../temp_files/".$thumbnail;			
		$imageBoxSize = 87;				
		list($fileWidth,$fileHeight)=getimagesize($filepath);						

		if($fileHeight > $fileWidth)
			{$unit = $fileWidth/$fileHeight;		$width = $imageBoxSize * $unit;		$height = $imageBoxSize;}
		else
			{$unit = $fileHeight/$fileWidth; 	$height = $imageBoxSize * $unit;	$width = $imageBoxSize;}	

		$src = imagecreatefromjpeg($filepath);
		$tmp = imagecreatetruecolor($width,$height);
		imagecopyresampled($tmp,$src,0,0,0,0,$width,$height,$fileWidth,$fileHeight);
		if(imagejpeg($tmp,$thumbnailpath,100));


		//Deleting Original File
		unlink($filepath);

		$_SESSION['photo1'] = $new_file_name;

[wbent79]

This occurs 4 times throughout the script. Once for each image uploaded.

[Weedpacket]

wbent79 wrote:

This occurs 4 times throughout the script. Once for each image uploaded.

That's probably your first mistake. If you're writing the same code over and over again then you should have written it once as a function, and then used that. It reduces the number of lines and hence the number of places you could make a mistake.

As an illustration of this, consider the fact that you're creating three images from the uploaded file, and you've largely duplicated the same code in three places (so you've got a large chunk of code repeated twelve times in all). I say "largely" because only the first copy ("Creating Full Image") checks the type of the uploaded file and uses the appropriate image creation function, while the other two ("Creating Thumbnail" and "Creating MainPage Thumbnail") both assume that it's always going to be a JPEG.

[wbent79]

Tried this....no change

if(isset($_FILES["photo1"]["tmp_name"])&& $_FILES["photo1"]["tmp_name"]!="")
		{
			$file_temp = $_FILES['photo1']['tmp_name'];	
			$original_file_name = $_FILES['photo1']['name'];

		$new_file_name = time().$original_file_name;			
		$filepath = "../temp_files/".$new_file_name;				

		move_uploaded_file( $file_temp , $filepath );

		// Creating Full Image
		$thumbnail = "FULL".$new_file_name;
		$thumbnailpath = "../temp_files/".$thumbnail;			
		$imageBoxSize = 207;
		list($fileWidth,$fileHeight, $image_type)=getimagesize($filepath);								

		if($fileHeight > $fileWidth)
			{$unit = $fileWidth/$fileHeight;		$width = $imageBoxSize * $unit;		$height = $imageBoxSize;}
		else
			{$unit = $fileHeight/$fileWidth; 	$height = $imageBoxSize * $unit;	$width = $imageBoxSize;}	

		switch ($image_type)
		{
			case 1: $src = imagecreatefromgif($filepath); break;
			case 2: $src = imagecreatefromjpeg($filepath);  break;
			case 3: $src = imagecreatefrompng($filepath); break;
			default:  trigger_error('Unsupported filetype!', E_USER_WARNING);  break;
		}
		$tmp = imagecreatetruecolor($width,$height);
		imagecopyresampled($tmp,$src,0,0,0,0,$width,$height,$fileWidth,$fileHeight);
		if(imagejpeg($tmp,$thumbnailpath,100));

		//Creating Thumbnail
		$thumbnail = "TN".$new_file_name;
		$thumbnailpath = "../temp_files/".$thumbnail;			
		$imageBoxSize = 50;				
		list($fileWidth,$fileHeight)=getimagesize($filepath);						

		if($fileHeight > $fileWidth)
			{$unit = $fileWidth/$fileHeight;		$width = $imageBoxSize * $unit;		$height = $imageBoxSize;}
		else
			{$unit = $fileHeight/$fileWidth; 	$height = $imageBoxSize * $unit;	$width = $imageBoxSize;}	
		switch ($image_type)
		{
			case 1: $src = imagecreatefromgif($filepath); break;
			case 2: $src = imagecreatefromjpeg($filepath);  break;
			case 3: $src = imagecreatefrompng($filepath); break;
			default:  trigger_error('Unsupported filetype!', E_USER_WARNING);  break;
		}
		$src = imagecreatefromjpeg($filepath);
		$tmp = imagecreatetruecolor($width,$height);
		imagecopyresampled($tmp,$src,0,0,0,0,$width,$height,$fileWidth,$fileHeight);
		if(imagejpeg($tmp,$thumbnailpath,100));	

		//Creating MainPage Thumbnail
		$thumbnail = "MAIN".$new_file_name;
		$thumbnailpath = "../temp_files/".$thumbnail;			
		$imageBoxSize = 87;				
		list($fileWidth,$fileHeight)=getimagesize($filepath);						

		if($fileHeight > $fileWidth)
			{$unit = $fileWidth/$fileHeight;		$width = $imageBoxSize * $unit;		$height = $imageBoxSize;}
		else
			{$unit = $fileHeight/$fileWidth; 	$height = $imageBoxSize * $unit;	$width = $imageBoxSize;}	
		switch ($image_type)
		{
			case 1: $src = imagecreatefromgif($filepath); break;
			case 2: $src = imagecreatefromjpeg($filepath);  break;
			case 3: $src = imagecreatefrompng($filepath); break;
			default:  trigger_error('Unsupported filetype!', E_USER_WARNING);  break;
		}
		$src = imagecreatefromjpeg($filepath);
		$tmp = imagecreatetruecolor($width,$height);
		imagecopyresampled($tmp,$src,0,0,0,0,$width,$height,$fileWidth,$fileHeight);
		if(imagejpeg($tmp,$thumbnailpath,100));


		//Deleting Original File
		unlink($filepath);

		$_SESSION['photo1'] = $new_file_name;

[wbent79]

Whats the best way to create a function for this?

[Weedpacket]

A first cut at refactoring and adding a couple more error messages gives something along the lines of...

function generate_file($image, $box_size, $filename, $prefix)
{
	$original_width = imagesx($image);
	$original_height = imagessy($image);
	if($original_height > $original_width)
	{
		$width = $box_size * $original_width/$original_height;
		$height = $box_size;
	}
	else
	{
		$width = $box_size;
		$height = $box_size * $original_height/$original_width;
	}
	$tmp = imagecreatetruecolor($width, $height);
	imagecopyresampled($tmp, $image, 0, 0, 0, 0, $width, $height, $original_width, $original_height);
	return imagejpeg($tmp, "../temp_files/$prefix$filename", 100);
}

function process_photo($field_name)
{
	if(empty($_FILES[$field_name]['tmp_name'] || !is_uploaded_file($_FILES[$field_name]['tmp_name']))
	{
		return;
	}
	$filename = $_FILES[$field_name]['tmp_name'];
	$new_file_name = time().$filename;

list(,,$imagetype) = getimagesize($filename);
switch($imagetype)
{
case IMG_GIF:
	$image = imagecreatefromgif($filepath);
	break;
case IMG_JPEG:
	$image = imagecreatefromjpeg($filepath);
	break;
case IMG_PNG:
	$image = imagecreatefrompng($filepath);
	break;
default:
	trigger_error('Unsupported filetype!', E_USER_WARNING);
	return false;
}
generate_file($image, 207, $filename, 'FULL') or trigger_error("Couldn't create full image!", E_USER_WARNING);
generate_file($image, 50, $filename, 'TN') or trigger_error("Couldn't create thumbnail image!", E_USER_WARNING);
generate_file($image, 87, $filename, 'MAIN') or trigger_error("Couldn't create mainpage thumbnail!", E_USER_WARNING);
}

//......

process_photo('photo1');
process_photo('photo2');
process_photo('photo3');
process_photo('photo4');