Coding for Contact Us form

[kenrobol]

Help!
I can’t seem to find out why this won’t work. Can someone look at the code for me? I will send somebody lunch if they can help me see what I am missing.

Here is the error:

Parse error: syntax error, unexpected T_ELSE in /home/robolexa/public_html/hfhbeauco.org/contact.php on line 26
PHP code

<?php
$to = $REQUEST['sendto'] ;
$from = $REQUEST['Email'] ;
$name = $REQUEST['Name'] ;
$headers = "From: $from";
$subject = "Web Contact Data";
$fields = array();
$fields{"Name"} = "Name";
$fields{"Company"} = "Company";
$fields{"Email"} = "Email";
$fields{"Phone"} = "Phone";
$fields{"list"} = "Mailing List";
$fields{"Message"} = "Message";
$body = "We have received the following information:\n\n"; foreach($fields as $a => $b){ $body .= sprintf("%20s: %s\n",$b,$REQUEST[$a]); }
$headers2 = "From: [e-mail]";
$subject2 = "Thank you for contacting us";
$autoreply = "Thank you for contacting us. Somebody will get back to you as soon as possible, usualy within 48 hours. If you have any more questions, please consult our website at www.oursite.com";
if($from == '') {print "You have not entered an email, please go back and try again";}
else{
if($name == '') {print "You have not entered a name, please go back and try again";}
else{
$send = mail($to, $subject, $body, $headers);
$send2 = mail($from, $subject2, $autoreply, $headers2);
if($send)
header("Location: http://www.hfhbeauco.org/thankyou.html");}
else{
{print "We encountered an error sending your mail, please notify [e-mail]";}
}
}
?>

[djjjozsi]

you're using rwong brackets when you fill the array.

$fields = array();
$fields["Name"] = "Name";
$fields["Company"] = "Company";

this is equal with:

$field=array(
"Name"=>"Name",
"list"=>"Mailing List"
);

[Weedpacket]

Your overenthusiasm for braces has led you astray in other ways, too:

if($from == '')
{
	print "You have not entered an email, please go back and try again";
}
else
{
	if($name == '')
	{
		print "You have not entered a name, please go back and try again";
	}
	else
	{
		$send = mail($to, $subject, $body, $headers);
		$send2 = mail($from, $subject2, $autoreply, $headers2);
		if($send)
			header("Location: http://www.hfhbeauco.org/thankyou.html");
	}
	else
	{
		{
			print "We encountered an error sending your mail, please notify [e-mail]";
		}
	}
}
if($from == '')
{
	print "You have not entered an email, please go back and try again";
}
else
{
	if($name == '')
	{
		print "You have not entered a name, please go back and try again";
	}
	else
	{
		$send = mail($to, $subject, $body, $headers);
		$send2 = mail($from, $subject2, $autoreply, $headers2);
		if($send)
			header("Location: http://www.hfhbeauco.org/thankyou.html");
	}
	else
	{
		{
			print "We encountered an error sending your mail, please notify [e-mail]";
		}
	}
}

[pudge1]

Why are you putting the data into an array. It seems like a waste of time. Just use the data as it is.

[kenrobol]

It still won't work
It will send me an email, but gives me this!
Parse error: syntax error, unexpected T_ELSE in /home/robolexa/public_html/hfhbeauco.org/contact.php on line 35

http://www.hfhbeauco.org/Volunteer.html

Code:
<?php
$to = $REQUEST['[e-mail]'];
$from = $REQUEST['Email'];
$name = $REQUEST['Name'];
$headers = "From: $from";
$subject = "Web Contact Data";
$fields = array();
$fields["Name"] = "Name";
$fields["Company"] = "Company";
$fields["Email"] = "Email";
$fields["Phone"] = "Phone";
$fields["list"] = "Mailing List";
$fields["Message"] = "Message";
$body = "We have received the following information:\n\n"; foreach($fields as $a => $b){ $body .= sprintf("%20s: %s\n",$b,$REQUEST[$a]); }
$headers2 = "From: [e-mail]";
$subject2 = "Thank you for contacting us";
$autoreply = "Thank you for contacting us. Somebody will get back to you as soon as possible, usualy within 48 hours. If you have any more questions, please consult our website at www.hfhbeauco.org";if($from == '')
if($from == '')
{
print "You have not entered an email, please go back and try again";
}
else
{
if($name == '')
{
print "You have not entered a name, please go back and try again";
}
else
{
$send = mail($to, $subject, $body, $headers);
$send2 = mail($from, $subject2, $autoreply, $headers2);
if($send)
header("Location: http://www.hfhbeauco.org/thankyou.html");
}
else
{
{
print "We encountered an error sending your mail, please notify [e-mail]";
}
}
}
if($from == '')
{
print "You have not entered an email, please go back and try again";
}
else
{
if($name == '')
{
print "You have not entered a name, please go back and try again";
}
else
{
$send = mail($to, $subject, $body, $headers);
$send2 = mail($from, $subject2, $autoreply, $headers2);
if($send)
header("Location: http://www.hfhbeauco.org/thankyou.html");
}
else
{
{
print "We encountered an error sending your mail, please notify [e-mail]";
}
}
}

[Weedpacket]

Please use the appropriate markup tags described in the FAQ for your posts. It would make it much easier to read (compare the code in your post with the code in mine).

And you still haven't addressed the problem I found when I tidied up your code (I didn't change anything, just formatted it more consistently): look at the indentation and how the braces pair up; see which if() statement each else lines up with.