Error after error! I get a diffrent one every time!

[chaseab]

:eek:Here is my code Please Help!😕

$host=' ';
$user='';
$pass='';
$db=' ';
$tbl='members';

// Connect to server and select database.
mysql_connect('$host', '$user', '$pass')or die('cannot connect');
mysql_select_db('$db')or die('cannot select DB');

// Get values from form
$firstname= $_POST['first_name'];
$username= $_POST['username'];
$password= $_POST['password'];
$email= $_POST['email'];


// Insert data into mysql 
$sql='INSERT INTO $tbl (id,firstname,username,password,email)VALUES(id(),'$firstname','$username','$password','$email')'; 
$result=mysql_query($sql); 

// if successfully insert data into database, displays message “Successful”. 
if($result){ 
echo 'Successful'; 
echo '<BR>'; 
echo '<a href=’main_login.html’>Back to form</a>'; 
} 

else 
die ('MySQL gagal karena'.mysql_error()); 

// close connection 
mysql_close(); 

[laserlight]

I have removed your database account details.

At a glance, the syntax highlighting shows that you forgot a single quote when initialising $pass.

[chaseab]

laserlight;10915164 wrote:

I have removed your database account details.

At a glance, the syntax highlighting shows that you forgot a single quote when initialising $pass.

Thanks for removing that!

But I don't see what you mean

[dagon]

$pass=';
should be
$pass='';

note the colours

[dagon]

on $sql=.. you mix up ' and `

[chaseab]

dagon;10915170 wrote:

$pass=';
should be
$pass='';

note the colours

It was in my code with ' ' I accedently backspaced it when I was clearing my password

[laserlight]

In other words, this:

$pass=';

should be:

$pass='';

[chaseab]

I edited it again and got this error Parse error: syntax error, unexpected T_VARIABLE in /home/a8914164/public_html/enter_it.php on line 21:mad:

[dagon]

It destroys the thread if you keep editing the original post, all the fixes no longer make any sense to some one visiting it in the future.

the last problem:

this:

$sql='INSERT INTO $tbl (id,firstname,username,password,email)VALUES(id(),'$firstname','$username','$password','$email')';

should be

$sql="INSERT INTO $tbl (id,firstname,username,password,email)VALUES(id(),'$firstname','$username','$password','$email')";

[chaseab]

Now I've got this error Warning: mysql_connect() [function.mysql-connect]: Unknown MySQL server host '$host' (3) in /home/a8914164/public_html/enter_it.php on line 10

[chaseab]

My code now

$host=' '; 
$user=''; 
$pass=''; 
$db=' '; 
$tbl='members'; 

// Connect to server and select database. 
mysql_connect('$host', '$user', '$pass')or die('cannot connect'); 
mysql_select_db('$db')or die('cannot select DB'); 

// Get values from form 
$firstname= $_POST['first_name']; 
$username= $_POST['username']; 
$password= $_POST['password']; 
$email= $_POST['email']; 


// Insert data into mysql 
$sql="INSERT INTO $tbl (id,firstname,username,password,email)VALUES(id(),'$firstname','$username','$password','$email')";
$result=mysql_query($sql); 

// if successfully insert data into database, displays message “Successful”. 
if($result){ 
echo 'Successful'; 
echo '<BR>'; 
echo '<a href=’main_login.html’>Back to form</a>'; 
} 

else 
die ('MySQL gagal karena'.mysql_error()); 

// close connection 
mysql_close(); 

[dagon]

You really have to start doing some work for your self. My last comment on this thread :Strings

[chaseab]

I am a beginner at php

[bradgrafelman]

Which is precisely why we're linking you to the manual; so you can learn the basics.

Here's a more specific link that takes you to the place of interest on the manual page for strings.

EDIT: Also, your code is vulnerable to SQL injection attacks. User-supplied data should never be placed directly into a SQL query string; instead, it must first be sanitized with a function such as [man]mysql_real_escape_string/man.