Outputting message in middle of page from class.

[Shabalaka]

Hi guys i have a small problem , Im wishing to print out a message halfway through the html page, The connection class and user class is working fine i mean its returning the messages to the index.php page but its just outputting them at the top of the page.

The index.php page. I have stripped the body,head tags for miminal post 🙂

<?php 
include_once('includes/connectionclass.php');
$connect = new Connections();
$connect -> EstablishConnection();

include_once("includes/userclass.php");
if (isset($_POST['login'])){
$NewUser = new User();
$loginerror = $NewUser->authorise();

}
?>
  <form id="form1" name="form1" method="post" action="">
    <table width="100%" border="0" cellspacing="0" cellpadding="0">
      <tr>
        <td colspan="2">&nbsp;</td>
        <td width="73%">&nbsp;</td>
      </tr>
      <tr>
        <td colspan="2" class="centredfonts">Username</td>
        <td><input name="username" type="text" class="inputs" id="username" /></td>
      </tr>
      <tr>
        <td colspan="2" class="centredfonts">Password</td>
        <td><label>
          <input type="password" name="password" id="password" class="inputs" />
        </label></td>
      </tr>
      <tr>
        <td colspan="2">&nbsp;</td>
        <td><label>
          <input type="submit" name="login" id="login" value="Login" />
        </label></td>
      </tr>
      <tr>
        <td colspan="2">&nbsp;</td>
        <td>&nbsp;</td>
      </tr>
      <tr>
        <td width="9%">&nbsp;</td>
        <td colspan="2" class="loginerror"><?php echo $loginerror;?></td>
        </tr>
    </table>

</form>

As you can see im trying to print out the returned value from $NewUser->authorise function here

      <td colspan="2" class="loginerror"><?php echo $loginerror;?></td>

as opposed to just putting it at the top of the page.

thanks to anyone who can help 🙂

regards Shab

[NogDog]

Is the output in question being generated directly within the Connections or User class itself, e.g. via an echo or user_error() command within one of the class methods? If so, you probably want to get rid of the echo or use error_log() instead of user_error(), and let the main script decide when to output things based on return values from method calls or such.

[Shabalaka]

The code calling the output is this

class User {
	public $username = "";
	public $password = "";
	public $fname = "";
	public $lname = "";
	public $email = "";
	public $loginerror = "";
	//Set the values to the above variables.
	function SetUser($_POST){
		$this->username = $_POST['username'];
		$this->password = md5($_POST['password']);
		$this->fname = ucfirst($_POST['fname']);
		$this->lname = ucfirst($_POST['lname']);
		$this->email = $_POST['email'];
		$this->FieldCheck();
			}

	function FieldCheck(){
		if (($this->username == "") ||($this->password == "") || ($this->fname == "") || ($this->lname == "")){
			print "Username is ".$this->username;
			$this->loginerror .= "<li>Username is blank</li>";

		}
		$this->CheckEmail();
	}


	function CheckEmail(){
	$emailcheck = count_chars($this->email);

	$acount=$emailcheck[ord("@")];	

	if ($acount == 0){
		$this->loginerror .= "<li>Invalid Email</li>";

	}
	$this->ErrorCheck();
}

	function ErrorCheck(){
		if ($this->loginerror == ""){
				$this->loginerror = "No errors on your application";
				print $this->loginerror;



		}else{
				$this->loginerror .= "<li>Errors have occured</li>";
				print $this->loginerror;
		}


	}
}//END USER CLASS.

This is the script with the outputs, I think it looks ok ( well i mean its working lol ) but im not sure about how i would condition the output in the login.php page as im not sure what how the output is referenced when i use

if(isset($_POST['submit'])){
		$NewUser = new User();
		 $NewUser->SetUser($_POST);
}

If im right i can access $this->loginerror using the following code but its not recommended if i believe although im not sure.

 <?php echo $NewUser->loginerror; ?> 

Thanks for the reply Nog and sorry for the long reply, I just like to try and make things as clear as possible for the people trying to help me 🙂

Regards Shab 😉

[Shabalaka]

I think i worked it out i just accessed the method/function ( i keep calling them methods now just to remind myself that they arent functions in OOP lol )

Code i used

$NewUser->ErrorCheck();

I put this in amongst the table where i wanted to output the message and it works fine 🙂

Is mixing the HTML and PHP valid OOP ?

Playing around with the various output methods ( Print, Echo , Return ) , I also managed to work out what each does 🙂

Print ( Will print out from inside the method and display at top of page )
Echo ( Same as above )
Return ( Will return the value to the page for display and not display it automatically )

If any of these sound wrong please inform me 🙂

Thanks Shab 🙂