Can I Optimize This Image Script?

[NOJ75]

Greetings all,

I am struggling with a script on my server that is using alot of memory. I have upped the max file size and the memory limit to what my hosts will allow me to use.

The code below is the main "feature" script of the whole thing. I am wondering if there is a way to optimize it at all. My clients NEED to upload photos, some over 2-3MB.

	$image = $_FILES["new_image"]["name"];
	$uploadedfile = $_FILES['new_image']['tmp_name'];

/* START DEALING WITH THE UPLOADED IMAGE */
if ($image) {

	$filename  = stripslashes($_FILES['new_image']['name']);
	$extension = getExtension($filename);
	$extension = strtolower($extension);

	$uploadedfile = $_FILES['new_image']['tmp_name'];
	$src = imagecreatefromjpeg($uploadedfile);

	list($width,$height) = getimagesize($uploadedfile);

	/* SET LARGE PHOTO SIZES */
		$newwidth=600;
		$newheight=450;
	$tmp = imagecreatetruecolor($newwidth,$newheight);

	/* SET THUMBNAIL SIZES */
		$newwidth1=250;
		$newheight1=188;
	$tmp1 = imagecreatetruecolor($newwidth1,$newheight1);

	/* COPY THE IMAGES */
	imagecopyresampled($tmp,$src,0,0,0,0,$newwidth,$newheight,$width,$height);

	imagecopyresampled($tmp1,$src,0,0,0,0,$newwidth1,$newheight1,$width,$height);

	/* RENAME THE PHOTOS */
	$newimagename  =  $hname.'.'.$extension;
	$newimagename1 =  $hname.'.'.$extension;

	/* STORE THE IMAGE AND THUMBNAIL */
	$filename  = "../../****/images/****/". $newimagename;
	$filename1 = "../../****/images/****/thumbs/". $newimagename1;

	imagejpeg($tmp,$filename,100); imagejpeg($tmp1,$filename1,100);

	imagedestroy($src); imagedestroy($tmp); imagedestroy($tmp1);

}

I really would appreciate any help. I have asked this question on other sites but unfortunately have not had a response, I am now really under pressure to find an answer.

Many thanks for your time.

[cahva]

Well images with size 2-3Mb it will use a lot of memory because images are processed in raw format(so 2Mb picture can easily eat over 32Mb of memory).

One thing that you could try is to rearrange your code so that when you do your resize, save it and use imagedestroy right after that, then do the other(thumb) resize, save image and destoy it. This is to free up memory as soon as possible and not maintaining images in memory(right now you have actually 3 images in memory: original, midsize and thumb).

If possible, you could also try to use imagemagick if its installed on the server. If ran from shell, it actually circumvents the PHP memorylimit. I actually dont know how imagemagick consumes memory if its used using the imagick extension.

[NOJ75]

Many thanks for your reply.

I would like to try the re-arranging of the code. Could you at all show me how you would arrange the code to do this?

I really appreciate your time.

Regards

[cahva]

Well heres a quick rearranging. Not tested:

	$image = $_FILES["new_image"]["name"];
    $uploadedfile = $_FILES['new_image']['tmp_name'];

/* START DEALING WITH THE UPLOADED IMAGE */
if ($image) {

    $filename  = stripslashes($_FILES['new_image']['name']);
    $extension = getExtension($filename);
    $extension = strtolower($extension);

	$newimagename  =  $hname.'.'.$extension;
    $newimagename1 =  $hname.'.'.$extension;

	$filename  = "../../****/images/****/". $newimagename;
    $filename1 = "../../****/images/****/thumbs/". $newimagename1;

    $uploadedfile = $_FILES['new_image']['tmp_name'];
    $src = imagecreatefromjpeg($uploadedfile);

    list($width,$height) = getimagesize($uploadedfile);

    /* SET LARGE PHOTO SIZES */
        $newwidth=600;
        $newheight=450;

	/* CREATE LARGE PHOTO, SAVE IT AND DESTROY IT */
    $tmp = imagecreatetruecolor($newwidth,$newheight);
	imagecopyresampled($tmp,$src,0,0,0,0,$newwidth,$newheight,$width,$height);
	imagejpeg($tmp,$filename,100);
	imagedestroy($tmp);


    /* SET THUMBNAIL SIZES */
        $newwidth1=250;
        $newheight1=188;

    $tmp = imagecreatetruecolor($newwidth1,$newheight1); // use the same name $tmp instead of $tmp1 just to be sure :)
	imagecopyresampled($tmp,$src,0,0,0,0,$newwidth1,$newheight1,$width,$height);
    imagejpeg($tmp,$filename1,100);

    imagedestroy($src);
	imagedestroy($tmp);

}

Dont know if it helps but should sqeeze the memory usage little bit.

[NOJ75]

Thank you very much for that. I still get an error.

The max memory is set to 24mb and my hosts wont increase anymore.

So I get this error:

Fatal error: Allowed memory size of 25165824 bytes exhausted (tried to allocate 2592 bytes) in /*/public_html//***/script.php on line 143

Any other ideas on what I can do?

This really is a pian in my **** :glare:

[cahva]

Tough luck man 🙂 Try the imagemagick or check whether imagick is installed as a module(you can see that in phpinfo).

[CoderDan]

There's no way of getting around the fact that using imagecreatefromjpeg (GD) will use a certain amount of memory for a certain size of image. So your options are to raise the memory available, decrease the size of image you support or use something other than GD (as cahva suggested, imagemagik, for example)

[NOJ75]

Its OK!

My hosts upped the limit to 32MB, that along with your modification worked a treat !!!

Thanks for your help buddy. 😃

SOLVED