[RESOLVED] form to insert data in table not inserting data in table

[mugwumpr]

I've been trying to make a form that will insert data into a table via a button. The variables are all returning the proper values, and both the page and the button are being correctly generated with accurate information, but there's a glitch somewhere between button and MySQL table that I just can't find. Pressing the button does NOT insert the data into the table.

Here's the relevant code:

if (isset ($_COOKIE['ID'])) {

$uid = escape_data($_COOKIE['ID']);
} else {
echo 'oopsie, no cookie for you!';
exit();
}

// make the query
$query = "SELECT fd_eggs.ID AS feid, name AS fename, releasedate AS rdate FROM fd_eggs
    LEFT JOIN fd_collection 
	ON fd_eggs.ID = fd_collection.egg_ID 
	ORDER BY releasedate DESC, fd_eggs.ID DESC";	
$result = mysql_query($query) or die(mysql_error());



//$ei = escape_data($row['feid']);
//$name = escape_data($row['fename']);	

echo '<table width="90%" border="0" cellspacing="5" cellpadding="0">';

//update the database
if (isset($_POST['submitted'])) {	
$eggp = escape_data($_POST['feid']);
$memp = escape_data($_POST['$uid']);
$namp = escape_data($_POST['fename']);

$query = "INSERT INTO fd_collection (ID, member_ID, egg_ID, egg_name) VALUES ('NULL', '$uid', '$eggp', '$namp')";
}	
$bg = '#eeeeee';  //set row background variable
while ($row = mysql_fetch_array($result, MYSQL_ASSOC)) {

$bg = ($bg=='#eeeeee' ? '#ffffff' : '#eeeeee');  //set background colours to alternate rows	

if ($row['egg_ID'] != 0) {
$eggid = escape_data($row['fd_eggs.ID']);
echo '<tr bgcolor="' . $bg . '"><td align="left"><img src="pics/yes.gif"></td>';
} else {

echo '<tr bgcolor="' . $bg . '"><td align="left"><form action="' . $PHP_SELF . '" method="post">
<input type="hidden" name="member_ID" size="50" maxlength="100" value="' . $uid . '" />
<input type="hidden" name="egg_ID" size="50" maxlength="100" value="' . $row['feid'] . '" />
<input type="hidden" name="egg_name" size="50" maxlength="100" value="' .  $row['fename'] . '" />
<input type="submit" name="submit" value="Have" />
<input type="hidden" name="submitted" value="TRUE" />
</form></td>';
}

I've been going over this endlessly, but I can't find where I've messed up. :xbones:

:queasy:

[bradgrafelman]

Your problem is here:

$memp = escape_data($_POST['$uid']);

Specifically, because you used single quotes around $uid PHP did not perform variable interpolation. In other words, you told PHP to look for an index of a dollar sign followed by the letters 'uid'. Variable interpolation only works when the string is enclosed by double quotes. Then again, since the entire string is just the variable's contents, there's no need for quotes at all.

Once you fix that, note that while you defined the INSERT query within $query, you never actually try to execute it.

Also note that $PHP_SELF isn't defined anywhere; you should probably be using $_SERVER['PHP_SELF'] instead.

[mugwumpr]

Thank you! I knew I was missing something obvious.

So, now it's inserting, but it's not inserting correctly.

It can see the variables $uid, $ei, and $name because it's displaying them in the button code:

<input type="hidden" name="member_ID" size="50" maxlength="100" value="2" /> 
<input type="hidden" name="egg_ID" size="50" maxlength="100" value="241" /> 
<input type="hidden" name="egg_name" size="50" maxlength="100" value="dragonearth" /> 

And, thank you bradgrafelman, it's now inserting data into the proper table, but it's only inserting 1/3 of it.

The table consists of 3 columns, thusly:

member_ID | egg_ID | egg_name
1 | 229 | rabbitfire
2 | 0 |

The member ID ($uid) is going through properly, but the other two aren't. The values in the second row should be "241" and "dragonearth" respectively, not "0" and [blank] as they appear.

Here's the code as it currently stands:

if (isset ($_COOKIE['ID'])) {

$uid = escape_data($_COOKIE['ID']);

} else {
echo 'oopsie, no cookie for you!';
exit();
}

if (isset($_POST['submitted'])) {	
//update the database
$query = "INSERT INTO fd_collection (ID, member_ID, egg_ID, egg_name) VALUES ('NULL', '$uid', '$ei', '$name')";
$result = @mysql_query($query) or die(mysql_error());
}	


// make the query
$query = "SELECT fd_eggs.ID AS feid, name AS fename, releasedate AS rdate FROM fd_eggs
    LEFT JOIN fd_collection 
	ON fd_eggs.ID = fd_collection.egg_ID 
	ORDER BY releasedate DESC, fd_eggs.ID DESC";	
$result = @mysql_query($query) or die(mysql_error());


echo '<table width="90%" border="0" cellspacing="5" cellpadding="0">';


$bg = '#eeeeee';  //set row background variable
while ($row = mysql_fetch_array($result, MYSQL_ASSOC)) {
$bg = ($bg=='#eeeeee' ? '#ffffff' : '#eeeeee');  //set background colours to alternate rows	
$ei = $row['feid'];
$name = $row['fename'];	
if ($row['egg_ID'] != 0) {
echo '<tr bgcolor="' . $bg . '"><td width="5%" align="left"><img src="pics/yes.gif"></td>';
} else {

echo '<tr bgcolor="' . $bg . '"><td width="5%" align="left"><form action="' . $_SERVER['PHP_SELF']  . '" method="post">
<input type="hidden" name="member_ID" size="50" maxlength="100" value="' . $uid . '" />
<input type="hidden" name="egg_ID" size="50" maxlength="100" value="' . $ei . '" />
<input type="hidden" name="egg_name" size="50" maxlength="100" value="' .  $name . '" />
<input type="submit" name="submit" value="Have" />
<input type="hidden" name="submitted" value="TRUE" />
</form></td>';
}

[bradgrafelman]

Why did you get rid of the variable declarations from your previous post? Specifically, this is what you had before:

$eggp = escape_data($_POST['feid']);
$memp = escape_data($_POST['$uid']);
$namp = escape_data($_POST['fename']); 

EDIT: Now that I look at it again, I notice you also changed the variable names. Either way, you didn't define the variables you referenced in the INSERT query string.

[mugwumpr]

I realized I could trim down on the number of variables by rearranging things a bit to make it a whole lot less byzantine.

I have defined the variables (it's tucked into the "while" statement), and I know they're working to some extent because a View Source of the generated page shows them returning the proper values. I've tried moving the variable declarations around to different places in the code, but the only placement that works for the HTML generation is where they are currently, everywhere else stops the HTML values as well; nothing at all works for the MySQL insertion.

Definitions:

$ei = $row['feid']; 
$name = $row['fename'];

Input for form:

<input type="hidden" name="member_ID" size="50" maxlength="100" value="' . $uid . '" />
<input type="hidden" name="egg_ID" size="50" maxlength="100" value="' . $ei . '" />
<input type="hidden" name="egg_name" size="50" maxlength="100" value="' .  $name . '" />
<input type="submit" name="submit" value="Have" />
<input type="hidden" name="submitted" value="TRUE" />
</form></td>';
}

echo '<td>';
echo '<img src="../pics/found/egg-found' . $ei . '.png" height="70px" width="50px"></td><td>';
echo $name;
echo '</td></tr>';

Output in HTML page with proper values in both form and image from those same variables:

<input type="hidden" name="member_ID" size="50" maxlength="100" value="2" /> 
<input type="hidden" name="egg_ID" size="50" maxlength="100" value="241" /> 
<input type="hidden" name="egg_name" size="50" maxlength="100" value="dragonearth" /> 
<input type="submit" name="submit" value="Have" /> 
<input type="hidden" name="submitted" value="TRUE" /> 
</form></td><td><img src="../pics/found/egg-found241.png" height="70px" width="50px"></td><td>dragonearth</td>

Why would they work in the generation part, but not be carried through to the insertion part when the $uid from the cookie works throughout?

I even tried removing the JOIN from the SELECT query to see what would happen, but it had no visible effect.

Here's the revamped code:

if (isset ($_COOKIE['ID'])) {

$uid = escape_data($_COOKIE['ID']);

} else {
echo 'oopsie, no cookie for you!';
exit();
}

if (isset($_POST['submitted'])) {	
//update the database
$query = "INSERT INTO fd_collection (ID, member_ID, egg_ID, egg_name) VALUES ('NULL', '$uid', '$ei', '$name')";
$result = @mysql_query($query) or die(mysql_error());
}	


// make the query
$query = "SELECT fd_eggs.ID AS feid, name AS fename, releasedate AS rdate FROM fd_eggs
    LEFT JOIN fd_collection 
    ON fd_eggs.ID = fd_collection.egg_ID 
    ORDER BY releasedate DESC, fd_eggs.ID DESC";	
$result = @mysql_query($query) or die(mysql_error());


echo '<table width="90%" border="0" cellspacing="5" cellpadding="0">';


$bg = '#eeeeee';  //set row background variable
while ($row = mysql_fetch_array($result, MYSQL_ASSOC)) {
$bg = ($bg=='#eeeeee' ? '#ffffff' : '#eeeeee');  //set background colours to alternate rows	
$ei = $row['feid'];
$name = $row['fename'];	
if ($row['egg_ID'] != 0) {
echo '<tr bgcolor="' . $bg . '"><td width="5%" align="left"><img src="pics/yes.gif"></td>';
} else {

echo '<tr bgcolor="' . $bg . '"><td width="5%" align="left"><form action="' . $_SERVER['PHP_SELF']  . '" method="post">
<input type="hidden" name="member_ID" size="50" maxlength="100" value="' . $uid . '" />
<input type="hidden" name="egg_ID" size="50" maxlength="100" value="' . $ei . '" />
<input type="hidden" name="egg_name" size="50" maxlength="100" value="' .  $name . '" />
<input type="submit" name="submit" value="Have" />
<input type="hidden" name="submitted" value="TRUE" />
</form></td>';
}

[mugwumpr]

I've tried all kinds of different permutations in the coding, and it looks like it SHOULD work, but it's not. The $uid variable derived from the cookie inserts properly, but the other two variables insert as "0" and [blank], no matter what value they're displaying elsewhere. :glare:

Can anyone see what I'm missing? Please? Here's the latest iteration of the code:

if (isset ($_COOKIE['ID'])) {
$uid = escape_data($_COOKIE['ID']);
} else {
echo 'oopsie, no cookie for you!';
exit();
}

if (isset($_POST['submitted'])) {
$eggp = escape_data($_POST["$ei"]);
$namp = escape_data($_POST["$name"]);
//update the database
$query = "INSERT INTO fd_collection (member_ID, egg_ID, egg_name) VALUES ('$uid', '$eggp', '$namp')";
$result = @mysql_query($query) or die(mysql_error());
}


// make the query
$query = "SELECT ID AS feid, name AS fename FROM fd_eggs
    ORDER BY releasedate DESC, ID DESC";	
$result = @mysql_query($query) or die(mysql_error());

$ei = $row['feid'];
$name = $row['fename'];

echo '<table width="90%" border="0" cellspacing="5" cellpadding="0">';


$bg = '#eeeeee';  //set row background variable
while ($row = mysql_fetch_array($result, MYSQL_ASSOC)) {
$bg = ($bg=='#eeeeee' ? '#ffffff' : '#eeeeee');  //set background colours to alternate rows	

if ($row['egg_ID'] != 0) {
echo '<tr bgcolor="' . $bg . '"><td width="5%" align="left"><img src="pics/yes.gif"></td>';
} else {

echo '<tr bgcolor="' . $bg . '"><td width="5%" align="left"><form action="' . $_SERVER['PHP_SELF']  . '" method="post">
<input type="hidden" name="member_ID" value="' . $uid . '" />
<input type="hidden" name="egg_ID" value="' . $ei . '" />
<input type="hidden" name="egg_name" value="' . $name  . '" />
<input type="submit" name="submit" value="Have" />
<input type="hidden" name="submitted" value="TRUE" />
</form></td>';
}

[bradgrafelman]

$eggp = escape_data($_POST["$ei"]);
$namp = escape_data($_POST["$name"]); 

Where are variables $ei and $name ever defined in your script?

From this code:

<input type="hidden" name="egg_ID" size="50" maxlength="100" value="241" /> 
<input type="hidden" name="egg_name" size="50" maxlength="100" value="dragonearth" /> 

it looks like you're trying to access "egg_ID" and "egg_name", two hidden POST'ed elements. Is this not correct?

[mugwumpr]

The two variables $ei and $name are defined about 10 rows below the ones you posted from the "submitted" check. The two variables from the "submitted" block shouldn't even come into play until something has been submitted via the form at the bottom.... at least that was the plan.

I've tried moving $ei and $name all over the code, but the location they're at now seems to be the only place they return an accurate value. Anywhere else, and the values are empty.

$query = "SELECT ID AS feid, name AS fename FROM fd_eggs 
    ORDER BY releasedate DESC, ID DESC";     

$result = @mysql_query($query) or die(mysql_error()); 

$ei = $row['feid']; 
$name = $row['fename']; 

The point of the script is to have a button that will automatically insert the ID numbers for the member and for each egg they have, plus the egg name, into a table. The values are meaningless to the person using the page, so that's why they're hidden. The names are the names of the columns in the MySQL table, which works great for the also-hidden $uid variable.

Here's what the page looks like, if you want a clearer idea of what I'm trying to accomplish: checklist

[mugwumpr]

Oops.... forgot to remove the exit() command for no cookie. That's done, so you can actually see the page now.

:rolleyes:

[mugwumpr]

Solved: needed form names, not variables in the POST command.