Problem with displaying product data into desired html table

binzy

Hello, I am facing a problem with displaying product data from mysql into the html table format I would like. I am very new at coding, so need help.
I have a working code which displays the data in a single column html table, but when I try to display it into a 3 column table, the results are incorrect. The product table has fields such as Name, Price, Desc etc.

Desired Output:

             Col1                  Col2                  Col3

Row 1--> Prod 1 Prod 2 Prod 3
Prod Name1 Prod Name2 Prod Name3
Price1 Price2 Price3

Row 1--> Prod 4 Prod 5 Prod 6
Prod Name4 Prod Name5 Prod Name6
Price4 Price5 Price6
..and so on
(each cell has product details of each product)

Please see my current code below. Understandably, the output of this code is repeating the data of each row across all columns, basically the column is not within the required iteration loop. I don’t know how to rectify this. Please help!

Current Output:
Col1 Col2 Col3
Row 1--> Prod 1 Prod 1 Prod 1
Prod Name1 Prod Name1 Prod Name1
Price1 Price1 Price1

Row 1--> Prod 2 Prod 2 Prod 2
Prod Name2 Prod Name2 Prod Name2
Price2 Price2 Price2
..and so on

Current Code:

<table style="text-align: left; width: 100%;" border="1" cellpadding="2" cellspacing="2">
<tbody>
<?php if($row = mysql_fetch_array($result)){do{?>
<tr style="font-family: Trebuchet MS; font-size: small; color: rgb(0, 0, 255);">
<?php for ( $counter = 1 ; $counter <= 3; $counter += 1) {?>
<td>
<?php 
$desc = $row["description"] ; 
$short_desc = substr($desc, 0, 50) ;?>
<img src="<?php echo $row["aw_thumb_url"];?>" alt="<?php echo $row["product_name"];?>" />
<br>
<?php echo $row["product_name"];?>
<br>
<?php echo $short_desc;?>
<br>
<?php echo $row["search_price"];?>
<br>
<a href="<?php echo $row["aw_deep_link"];?>">Purchase</a>
<br> 
</td>
<?php } ?>
</tr>
<?php } while($row = mysql_fetch_array($result));  

} ?>
</tbody>
</table>

Please let me know how I can get the desired output, with minimal changes (if possible) to this code. Will be very grateful. Thanks.

binzy

My previous post did not display the desired output correctly and I am unable to edit the post, so just adding the desired output more clearly in this post..

Desired 3 column HTML Table

Row 1 -> Product 1 Details - Product 2 Details - Product 3 Details
Row 2 -> Product 4 Details - Product 5 Details - Product 6 Details
..so on

Details include 4 fields - Image, Name, Desc and Price.

Sorry for the inconvenience, if any. Thanks!

Satabi2

I'm almost sure it's because of the 'for' loop within the table...the fetch on the 3rd line of your code should be inside the 'for' loop...

binzy

Thanks, tried that. But doesnt work.

djjjozsi

if($row = mysql_fetch_array($result)){do{   this is wrong.

maybe...

if(mysql_num_rows($result)){do{

binzy

Thanks, but this doesnt work. The original php code (without the for loop) gives the correct result for a single column display. But the product information gets repeated in each column if I try it for a 3 - column display. All suggestions to help me in this will be appreciated.

maxxd

Personally, drop the do entirely. Use a while() statement using $row to pull the data out, then increment. Try the following code - I haven't tested it (not having access to your data and all), but it's how I do the vast majority of the dynamic tables I create.

<table style="text-align:left; width:100%;" border="1" cellpadding="2" cellspacing="2">
	<tbody>
		<tr style="font-family: Trebuchet MS; font-size: small; color: rgb(0, 0, 255);">
			<td>
				<?php
				$i=0;
				while($row = mysql_fetch_array($result)){
					$desc = $row['description'];
					$short_desc = substr($desc,0,50)."...";
					print("<img src=\"".$row['aw_thumb_url']."\" alt=\"".$row['product_name']."\" /><br />");
					print($row['product_name']."<br />");
					print("$short_desc<br />");
					print($row['search_price']."<br />");
					print("<a href=\"".$row['aw_deep_link']."\">Purchase</a><br />");
					if($i==3){
						print("</td></tr><tr><td>");
						$i=0;
					}else{
						$i++;
					}
				}
				?>
			</td>
		</tr>
	</tbody>
</table>

What you're basically doing here is looping through all the data in the MySQL table and incrementing a cell count variable ($i) on each iteration. If you want a table three cells wide, end the row and start a new one when that increment variable hits 3. Reset the variable and start all over again.

Just make sure to close the last row with the correct number of cells (not shown in the code above), as it may not make it to 3 cells in order to form a correctly structured table.

binzy

Thanks, will try that. Have resolved this problem more or less using another piece of code. Thanks to all who helped.