my code isnt working for some reason..

Toadums

Hey, I cant figure out why this aint working...I am just trying to pass a php variable (string) into an onchange event...if i replace the variable with just a normal string, it works fine...

heres some code:


$str = $node->getData(); //(this is the variable that doesnt work)

$toReturn = "<div style=\"display:none;\" id=\"$nodeID\">$space
<img src=\"images/plus.gif\" onclick=\"showHide('$nodeChild');\" />
<label id=\"\" style=\"cursor:pointer;font-size:9pt;\">&nbsp;&nbsp;
<input type=\"checkbox\" class\"smallCheck\" name=\"$nodeID\" onchange=\"addRemoveData('$str');\" /> //its this line right here...the $str variable
$toReturn<br /></label></div>";

here is the JS it calls:

function addRemoveData(nodeData){

document.write("works");

//var display = document.getElementById("treeviewtext");

//display.innerHTML = display.innerHTML + nodeData + "<br />";

the wierd part is: if i view the source code in firefox it looks like this:

name="t10" onchange="addRemoveData('1.	Door release panel.');"

so i mean...thats exactly what it SHOULD look like...

any help would be much appreciated!! thansk 🙂

etully

Open Firefox, go to the Tools menu and open the error console. Then load the page. You'll be able to see why the addRemoveData() function is failing when it was created with PHP.

You are correct that creating Javascript with PHP should be no different than creating Javascript with a text editor. And you're right, the resulting Javascript looks like it should function fine.

When you see the error message in the error console, all will become clear.

Toadums

holy crap I had no idea that this error console existed...that is going to come in handy..

That being said, I dont understand this error...it says:

"unterminated string literal addRemoveData('2. Transformers."

so it like isnt putting the ' on the end of the string (i think thats what it means)...

but here is my code: onchange=\"addRemoveData('$str');\" it is definitely closed! lol ... make any sense?

edit: Oh, now that I see that is missing everything AFTER the string, looking at the page source it is on the next line...so perhaps each line of the string has an enter at the end 😃

ok, got it!! i just went like this: $display = substr($str,0,strlen($str)-4); and used that instead of $str, to get rid of the enter space

NogDog

You could probably use [man]trim/man or [man]rtrim/man to get rid of any unwanted leading/trailing white-space (including newlines).