[RESOLVED] Hopefully, a quickie...

jamesjohnson88

Ok, since Rodders help me with my last bug i've been getting on quite well, i.e - no bugs I couldn't solve myself. Anyway, i've just added an extra query to some working code but something isn't right. The original queries run but the new query gives me this error -

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 2

This is the troublesome query:

mysql_query("INSERT INTO Result_Log (League, Result, Comment, Timestamp)
VALUES ('$leagueName', '$addresult', '$comments', '$timestamp'") or die(mysql_error());

I have a feeling that it's probably going to be some little syntax error in the query. If not, please tell me and i'll post the full code.

Thanks in advance,

James

laserlight

My guess is that Timestamp is a keyword, so you should escape it. The normal way of escaping is to use double quotes, but since this is MySQL, use backticks:

mysql_query("INSERT INTO Result_Log (League, Result, Comment, `Timestamp`)
VALUES ('$leagueName', '$addresult', '$comments', '$timestamp'") or die(mysql_error());

I am also assuming that those variables have been through say, mysql_real_escape_string().

jamesjohnson88

That didn't work. Still get the same error.

$timestamp is the only one that doesn't have a mysql_real_escape_string.

Though I did try

$timestamp = mysql_real_escape_string(date("d/m/Y"));

just to see if it made a difference and it didn't.

laserlight

Oh, a missing closing parenthesis could be the problem. Try:

mysql_query("INSERT INTO Result_Log (League, Result, Comment, `Timestamp`)
VALUES ('$leagueName', '$addresult', '$comments', '$timestamp')") or die(mysql_error());

jamesjohnson88

Yup, that was it. Thank you. I've no idea how I missed that, I was sure i'd checked those, lol.

laserlight

You're welcome 🙂
Remember to mark this thread as resolved using the thread tools.

jamesjohnson88

Ah, thanks. I assumed a mod came and did that. I know better now.