ID3 Tag Reader

Plato

I wrote this code to sort out music I had ripped from an old mp3 player, where all the file names had been changed to MV34P.mp3 or the likes. The code simply takes the id3 tags from the file and then renames the file using the supplied "Artist - Title.mp3"

The code only works for ID3v1.

<?php

include ('functions.php');
connectDB('ipodmusic');
set_time_limit(0);

if ($handle = opendir("musicloop/")) {
    echo ("<strong>Directory opened successfully.</strong>");

while (false !== ($file = readdir($handle))) {
    if ($file != "." && $file != "..") {

        $filesize = filesize("musicloop/" . $file);
        $mp3 = fopen("musicloop/" . $file, "r");
        fseek($mp3, -128, SEEK_END);

        $tag = fread($mp3, 3);

        if ($tag == "TAG") {
            $data["Title"] = trim(fread($mp3, 30));
            $data["Artist"] = trim(fread($mp3, 30));
            $data["Album"] = trim(fread($mp3, 30));
        }

        fclose($mp3);

        $newName = $data['Artist'] . " - " . $data['Title'];
        $renaming = rename("musicloop/" . $file, "musicloop/" . $newName . ".mp3");

        $query = ("INSERT INTO `test`.`testing` (`title`, `artist`, `album`, `location`) VALUES ('" .
            $data['Title'] . "', '" . $data['Artist'] . "', '" . $data['Album'] .
            "', 'musicloop/" . $newName . ".mp3');");
        $insert = mysql_query($query);

    }

}

echo ("</br><strong>Operation Completed successfully!</strong>");

}

?>

CoderDan

A few of things I'd change:
1) use single quotes unless double quotes are needed.
2) call mysql_escape_string() on the string values you are building into your query.
3) don't collect the result of the query into $insert, as you don't use it.

laserlight

CoderDan wrote:
2) call mysql_escape_string() on the string values you are building into your query.

Slight correction: that should be mysql_real_escape_string(). mysql_escape_string() is deprecated (but then arguably the MySQL extension should not be used for new scripts).

CoderDan

laserlight;10922335 wrote:
Slight correction: that should be mysql_real_escape_string(). mysql_escape_string() is deprecated (but then arguably the MySQL extension should not be used for new scripts).

True that... sometime I'm gonna have to replace all my old sql code, not looking forward to that. (I don't mean the find and replace to insert _real so it doesn't need to use the alias, I mean move to MySQLi. Sad thing is I'm not even using mysql 4 anymore, but 5, and still use mysql)