[RESOLVED] help with fetchRow()

[Melindash]

Hello. I have a bit of code, and I don't know why it doesn't work.

Error Message:
Fatal error: Call to a member function fetchRow() on a non-object in /blah/blah/tranhist.php

Here is the part that it's talking about (tranhist.php):

<?php 
$dbarray = $database->getAcctDet($username);
while($row = $dbarray->fetchRow()) {
	echo "$row \n";
}
?>

Here's the function getAcctDet() in database.php:

  function getAcctDet($username){
      $q = "SELECT * FROM ".TBL_ACCOUNT_ACTIVITY." WHERE username = '$username'";     

      $result = mysql_query($q, $this->connection) or die(mysql_error());
 if(!$result || (mysql_numrows($result) < 1)){
         echo "No Transaction History Found";
     }

$dbarray = mysql_fetch_array($result);
return $dbarray;

   }

I had this working (I think) previously, but I forgot to append the username to the end of the filename, so I just got the error message "No Transaction History Found" every time, and I've since changed this around so much that I can't figure out which way is up anymore. I've actually gotten a while loop to work once on this page (back before I had a clue what I was doing, still don't actually), but lately I can't seem to get it right.

Thanks in advance,
Mendy

P.S. -- I know it isn't my connection to the database. I am able to call up individual cells from my database with the getAcctDet() array, by doing something like this:

<?php 
echo $session->acctact['datepost'];
echo $session->acctact['datefund'];

btw,

$session->acctact

is the variable that contains the array for getAcctDet (sorry if I'm redundant).

[Melindash]

Sorry, one last note- I have used several different variables. I know it isn't smart to use $dbarray right there, but it was only a desperate attempt.

[laserlight]

Looking at these two lines in getAcctDet:

$dbarray = mysql_fetch_array($result);
return $dbarray;

it is clear that getAcctDet() returns an array. Consequently, $dbarray is an array (as you have implied with the name). As such, $dbarray->fetchRow() does not make sense. You would likely write:

<?php 
$dbarray = $database->getAcctDet($username);
foreach ($dbarray as $field) {
	echo "$field \n";
}
?>

[Melindash]

I changed it, but now I get a new error:

Warning: Invalid argument supplied for foreach() in /home/content/m/e/l/melindash/html/tranhist.php on line 194

Thanks for your help.

[laserlight]

Do a print_r($dbarray) and post the result here.

[Melindash]

It might just be that I'm an idiot, but I tried print_r($dbarray) and print_r($dbarray, true). neither printed anything new on the page.

Since the table account_activity has multiple entries for each username (it's a transaction history), it has an index on the field username, but no primary key. Could this be a factor? When I changed my code to look like this:
(tranhist.php)

<?php
$tranhist = $database->getTranHist;
echo $tranhist;
?>

(database.php)

 function getTranHist($username){
	$q = "SELECT * FROM  ".TBL_ACCOUNT_ACTIVITY." WHERE username = '$username'";
	$result = mysql_query($q, $this->connection) or die(mysql_error());
if(!result || (mysql_numrows($result) < 1)){
	echo "No Transaction History Found";
}

$tharray = mysql_fetch_row($result);
return $tharray;
}

It prints "No Transaction History Found," but no error message.
This leads me to believe it is a problem with my query, but the query is fine. So, maybe it's the database? It's impossible to have a primary key, because I have multiple rows for each username.

I'm going to run a similar query on another table and find out if the table is the problem.

[laserlight]

Melindash wrote:

I tried print_r($dbarray) and print_r($dbarray, true). neither printed anything new on the page.

Do you also have (X)HTML on the page that may interfere with the output of print_r?

Melindash wrote:

Since the table account_activity has multiple entries for each username (it's a transaction history), it has an index on the field username, but no primary key. Could this be a factor?

No, except that it means that your query result handling is fundamentally wrong. It also looks like you did not properly account for the case where no row has a match for the username, in which case false is returned, and this would cause the foreach loop to fail.

Melindash wrote:

This leads me to believe it is a problem with my query, but the query is fine. So, maybe it's the database? It's impossible to have a primary key, because I have multiple rows for each username.

It is always possible to have a primary key; it can be a combined key or an arbitrary integer primary key. The fact that you have multiple rows for each username means that you should be retrieving in a loop, e.g.,

function getTranHist($username) {
    $query = sprintf("SELECT * FROM %s WHERE username='%s'",
        TBL_ACCOUNT_ACTIVITY,
        mysql_real_escape_string($username));
    $result = mysql_query($query, $this->connection) or die(mysql_error());
    $rows = array();
    while ($row = mysql_fetch_assoc($result)) {
        $rows[] = $row;
    }
    return $rows;
}

Of course, this means that you will be returning an array of arrays instead.

[Melindash]

Thanks for all your help. I'm in way over my head. I made it this far with my site, but lack of knowledge is really holding me back here.

[laserlight]

Well, you seem to be doing fine for a beginner.