sql request not going through

dbomb101

I have been creating a php webpage, I have created a section of code which deletes the uploaded information, although it does delete the actual item it doesnt delete the link supplied for the item, which has been written in my sql database

below is the code which does the deletion

if ($picDelete1 == "deleted")
{


$sql1="UPDATE lessondetails  picture1 = '' WHERE r_id ='$pid'";

makeQuery($sql1);


if (!unlink($pic1))
  {
  echo ("Error deleting $file");
  }
else
  {
  echo ("Deleted $file");
  }

$picture1 = "";	

}

and below this sentence is the code which connects to the database

?php

function makeQuery($query)

{

//build select query

$msg="";



//connect to mysql

if(!($database = mysql_connect("studb.cms.gre.ac.uk","dd615","army4sr")))

{

$msg+="could not connect to database<br/>";

}



if(!mysql_select_db("mdb_dd615",$database))

{

$msg+="could not open database<br/>";



}

if(!($result = mysql_query($query,$database)))

{

$msg+="could not execute query:".mysql_error()."<br/>";

}

mysql_close($database);



return $result;

}

?>

dbomb101

I know the sql query in the first section of code is missing SET but despite fixing this and double checking the remainder it still doesn't work

slick101

although it does delete the actual item it doesnt delete the link supplied for the item, which has been written in my sql database

If I get this right you say it deletes the file no problem.

but it does not set picture1 = '';

If thats the case you should re-check your query

$sql1="UPDATE lessondetails  SET picture1 = '' WHERE r_id ='$pid'";
echo $sql1;
die();

so you can see what your query is. Im not sure what db class your using but if there is a error method you should use it.

goodluck!

dbomb101

yeah I did the eccho copied in the results directly to the sql table and it worked fine, on top of which the function I use for writing the info to the database works fine when writing the other items to the database am sooo confused at the moment it hurts

😕

CoderDan

your makeQuery() function formats up an error message but doesn't do anything with it.
I'd suggest making use of this variable (echoeing/returning it) to see where your problem lies.
Also, you state:

the function I use for writing the info to the database

This sounds to me like you use a different function to do your successful query. Has this makeQuery() function ever worked? (also, you might want to redact real login information from your code)