Simple Conditional Logic/Syntax Help

scriderpsd

I'm trying to work in this simple error checking sequence when my form is submitted. What I want to do check to see if the bar code is already in the database, then check to see if the serial number is already in their. Then, if neither of those fields are duplicates, I check to make sure nothing is empty before doing my insert.

Unfortunately, it doesn't work...it never gets to the submit. I know it's a logic problem but I can't figure it out. Any help is appreciated...

		if (isset($_POST['submit'])) {

		if (!empty($bar_code)) {
			$sqlCheckBarCode = "SELECT COUNT(*) as numrows_bar FROM inventory where bar_code=$bar_code";
			$resultCheckBarCode = mysql_query($sqlCheckBarCode) or die('Error, Bar Code query failed');
			$rowCheckBarCode = mysql_fetch_array($resultCheckBarCode, MYSQL_ASSOC);
			$numrowsBarSingle = $rowCheckBarCode['numrows_bar'];

			if ($numrowsBarSingle!=0){
				echo '<center><big><big><big>Oops...Bar Code Already In The Database</big></big></big></center>';
			}
		}

		if (!empty($serial_number)) {
			$sqlCheckSerialNumber = "SELECT COUNT(*) as numrows_serial FROM inventory where serial_number='$serial_number'";
			$resultCheckSerialNumber = mysql_query($sqlCheckSerialNumber) or die('Error, Serial Number query failed');
			$rowCheckSerialNumber = mysql_fetch_array($resultCheckSerialNumber, MYSQL_ASSOC);
			$numrowsSerialSingle = $rowCheckSerialNumber['numrows_serial'];

			if ($numrowsSerialSingle!=0){
				echo '<center><big><big><big>Oops...Serial Number Already In The Database</big></big></big></center>';
			}
		}

		else if (!empty($bar_code) && !empty($item_type) && !empty($purchased_by) && !empty($manufacturer) && !empty($model) && !empty($serial_number) && !empty($last_inventory) && !empty($warranty_expires) && !empty($po_number) && !empty($date_acquired) && !empty($location) && !empty($vendor)) {
			$sqlInsert="INSERT INTO inventory (bar_code, item_type, purchased_by, manufacturer, model, serial_number, last_inventory, warranty_expires, po_number, date_acquired, over_500, small_attractive, location, room_number, assigned_to, vendor) VALUES ('$bar_code', '$item_type', '$purchased_by', '$manufacturer', '$model', '$serial_number', '$last_inventory', '$warranty_expires', '$po_number', '$date_acquired', '$over_500', '$small_attractive', '$location', '$room_number', '$assigned_to', '$vendor')";
  		mysql_query($sqlInsert,$conn) or die('Error, query failed');	
 			$message_sucess = "<br>You have succesfully added an inventory item!";
  		echo '<META HTTP-EQUIV="refresh" content="0;URL=additem.php?message_success='.$message_sucess.'">';
			echo '<span class="errortext">'. $message_sucess .'</span></TD>';

  	}
		$message = "<br>You must fill in all required fields (marked in red)!";
		$textclass = "errortext";
}

CoderDan

you use an check: isset( $POST['submit'] ) - then you use what I assume are post variables as $bar_code, etc, not as $POST['bar_code'] - is that the problem?

Bjom

what you are doing is this:

   if (isset($_POST['submit'])) {
       //whatever
   else if (!empty($bar_code) && !empty($item_type) && !empty($purchased_by) && !empty($manufacturer) && !empty($model) && !empty($serial_number) && !empty($last_inventory) && !empty($warranty_expires) && !empty($po_number) && !empty($date_acquired) && !empty($location) && !empty($vendor)) { 
               //your query

      } 
        $message = "<br>You must fill in all required fields (marked in red)!"; 
        $textclass = "errortext"; 
   }

The elseif is only reached when $_POST['submit'] is not set....

devinemke

if (isset($_POST['submit']))
{
	$fields = array(
	'bar_code' => 'req',
	'item_type' => 'req',
	'purchased_by' => 'req',
	'manufacturer' => 'req',
	'model' => 'req',
	'serial_number' => 'req',
	'last_inventory' => 'req',
	'warranty_expires' => 'req',
	'po_number' => 'req',
	'date_acquired' => 'req',
	'over_500' => '',
	'small_attractive' => '',
	'location' => 'req',
	'room_number' => '',
	'assigned_to' => '',
	'vendor' => 'req'
	);

$errors = array();

foreach ($_POST as $key => $value)
{
	$value = trim($value);
	if (isset($fields[$key]) && $fields[$key] && $value == '') {$errors[] = $key; break;} else {$fields[$key] = "'" . mysql_real_escape_string($value) . "'";}
}

if ($errors)
{
	exit('the following fields are empty:' . implode(', ', $errors));
}

$result = mysql_query('SELECT COUNT(*) FROM inventory WHERE bar_code = ' . $fields['bar_code']) or exit(mysql_error());
if (mysql_result($result, 0)) {exit('Bar Code Already In The Database');}

$result = mysql_query('SELECT COUNT(*) as numrows_serial FROM inventory where serial_number = ' . $fields['serial_number']) or exit(mysql_error());
if (mysql_result($result, 0)) {exit('Serial Number Already In The Database');}

$sql = 'INSERT INTO inventory (' . implode(', ', array_keys($fields)) . ') VALUES (' . implode(', ', $fields) . ')';
mysql_query($sql) or exit(mysql_error());
echo 'You have succesfully added an inventory item!';
}

scriderpsd

Bjom;10922217 wrote:

what you are doing is this:

   if (isset($_POST['submit'])) {
       //whatever
   else if (!empty($bar_code) && !empty($item_type) && !empty($purchased_by) && !empty($manufacturer) && !empty($model) && !empty($serial_number) && !empty($last_inventory) && !empty($warranty_expires) && !empty($po_number) && !empty($date_acquired) && !empty($location) && !empty($vendor)) { 
               //your query

      } 
        $message = "<br>You must fill in all required fields (marked in red)!"; 
        $textclass = "errortext"; 
   }

The elseif is only reached when $_POST['submit'] is not set....

okay, this is where I'm having the problem. From what I see, it looks like the two "error checking" ifs and the else if are embedded inside the "submit" if.

It looks like what is happening is that I will only reach the else if when the serial_number is empty.

What I want to do is check for duplicates on both the bar_code and serial_number and if both of those evaluate to false, then do the else if.

I'm starting to confuse myself.

Bjom

The error checking ifs are nested. The elseif is something differrent:

Here in pseudocode:

IF (cond1) THEN:
    IF (cond1.1) THEN:
        do stuff
    END IF
ELSEIF (cond2) THEN:
    IF (cond2.1) THEN:
        do stuff
    END IF
ELSE:
        do stuff
END IF

IF and ELSEIF are on the same level. First the IF(cond1) is evaluated. If it is negative: ELSEIF(cond2) will be next..if that is negative too....goto the ELSE.

Now the nested IFs: first one(cond1.1) is only reached if cond1 is true, second one(cond2.1) only if cond2 is true.

So if you want to have a chain of conditions that all must be met: nest them (cond1), (cond1.1), (cond1.1.1) etc. If they are alternatives use else or elseif.

Now take a piece of paper and write down what you want, w/o using code. That usually helps clearing the confusion.

Bjom