PLEASE HELP - "Parse error: syntax error, unexpected T_STRING"

Megadeth

Parse error: syntax error, unexpected T_STRING in /home/wrestles/public_html/includes/functions_reputation.php on line 115

I tried to change the settings of the reputation feature on my forum and it caused this error. I put changed back the 3 numbers I changed, but i'm still getting the error.

Here's the part that I changed. Can you see anything wrong with it?

$reputation_value = 0;
	}
	else if ($post['reputation'] < 0)
	{
		$reputationgif = 'neg';
		$reputationhighgif = 'highneg';
		$reputation_value = $post['reputation'] * -1;
	}
	else
	{
		$reputationgif = 'pos';
		$reputationhighgif = 'highpos';
	}

if ($reputation_value > 500)
{  // bright green bars take 200 pts not the normal 100
	$reputation_value = ($reputation_value / 2) + 250;
}

$reputationbars = intval($reputation_value / 100); // award 1 reputation bar for every 100 points
if ($reputationbars > 10)
{
	$reputationbars = 10;
}

if (!$post['showreputation'] AND $perms['genericpermissions'] & $vbulletin->bf_ugp_genericpermissions['canhiderep'])
{
	$posneg = 'off';
	$post['level'] = $vbphrase['reputation_disabled'];
[B][COLOR="Red"]I THINK THIS BLANK SPACE IS LINE 115[/COLOR][/B]
		eval('$post['reputationdisplay'] = "' . fetch_template('postbit_reputation') . '";');
	}
	else
	{
		if (!$post['reputationlevelid'])

	{
		$post['level'] = $vbulletin->options['reputationundefined'];
	}
	for ($i = 0; $i <= $reputationbars; $i++)
	{
		if ($i >= 5)
		{
			$posneg = $reputationhighgif;
		}
		else
		{
			$posneg = $reputationgif;
		}

		$post['level'] = $vbphrase['reputation' . $post['reputationlevelid']];
		eval('$post['reputationdisplay'] .= "' . fetch_template('postbit_reputation') . '";');
	}
}

($hook = vBulletinHook::fetch_hook('reputation_image')) ? eval($hook) : false;

return true;
}

Help would be much appreciated. My forum has grind to a halt because of this.

Megadeth

Anyone? My members are getting pissed that they can't open any threads..

Randy_Jackson

There's an opening if statement missing from the code you posted. I doubt that's the problem, but if you could repost the entire function, that would be helpful.

Megadeth

Ok here's the whole thing:

<?php
/*======================================================================*
|| #################################################################### ||
|| # vBulletin 3.8.2 - Licence Number VBF068F20C
|| # ---------------------------------------------------------------- # ||
|| # Copyright &#169;2000-2009 Jelsoft Enterprises Ltd. All Rights Reserved. ||
|| # This file may not be redistributed in whole or significant part. # ||
|| # ---------------- VBULLETIN IS NOT FREE SOFTWARE ---------------- # ||
|| # http://www.vbulletin.com | http://www.vbulletin.com/license.html # ||
|| #################################################################### ||
*======================================================================*/

// ## Function takes an array from fetch_userinfo and an array from cache_permissions()
// ## Returns the user's reputation altering power (for positive)
function fetch_reppower(&$userinfo, &$perms, $reputation = 'pos')
{
    global $vbulletin;

// User does not have permission to leave negative reputation
if (!($perms['genericpermissions'] & $vbulletin->bf_ugp_genericpermissions['cannegativerep']))
{
    $reputation = 'pos';
}

if (!($perms['genericpermissions'] & $vbulletin->bf_ugp_genericpermissions['canuserep']))
{
    $reppower = 0;
}
else if ($perms['adminpermissions'] & $vbulletin->bf_ugp_adminpermissions['cancontrolpanel'] AND $vbulletin->options['adminpower'])
{
    $reppower = iif($reputation != 'pos', $vbulletin->options['adminpower'] * -1, $vbulletin->options['adminpower']);
}
else if (($userinfo['posts'] < $vbulletin->options['minreputationpost']) OR ($userinfo['reputation'] < $vbulletin->options['minreputationcount']))
{
    $reppower = 0;
}
else
{
    $reppower = 1;

    if ($vbulletin->options['pcpower'])
    {
        $reppower += intval($userinfo['posts'] / $vbulletin->options['pcpower']);
    }
    if ($vbulletin->options['kppower'])
    {
        $reppower += intval($userinfo['reputation'] / $vbulletin->options['kppower']);
    }
    if ($vbulletin->options['rdpower'])
    {
        $reppower += intval(intval((TIMENOW - $userinfo['joindate']) / 86400) / $vbulletin->options['rdpower']);
    }

    if ($reputation != 'pos')
    {
        // make negative reputation worth half of positive, but at least 1
        $reppower = intval($reppower / 2);
        if ($reppower < 1)
        {
            $reppower = 1;
        }
        $reppower *= -1;
    }
}

($hook = vBulletinHook::fetch_hook('reputation_power')) ? eval($hook) : false;

return $reppower;
}

// ###################### Start getreputationimage #######################
function fetch_reputation_image(&$post, &$perms)
{
    global $stylevar, $vbphrase, $vbulletin;

if (!$vbulletin->options['reputationenable'])
{
    return true;
}

$reputation_value = $post['reputation'];
if ($post['reputation'] == 0)
{
    $reputationgif = 'balance';
    $reputation_value = 0;
}
else if ($post['reputation'] < 0)
{
    $reputationgif = 'neg';
    $reputationhighgif = 'highneg';
    $reputation_value = $post['reputation'] * -1;
}
else
{
    $reputationgif = 'pos';
    $reputationhighgif = 'highpos';
}

if ($reputation_value > 500)
{  // bright green bars take 200 pts not the normal 100
    $reputation_value = ($reputation_value / 2) + 250;
}

$reputationbars = intval($reputation_value / 100); // award 1 reputation bar for every 100 points
if ($reputationbars > 10)
{
    $reputationbars = 10;
}

if (!$post['showreputation'] AND $perms['genericpermissions'] & $vbulletin->bf_ugp_genericpermissions['canhiderep'])
{
    $posneg = 'off';
    $post['level'] = $vbphrase['reputation_disabled'];

    eval('$post['reputationdisplay'] = "' . fetch_template('postbit_reputation') . '";');
}
else
{
    if (!$post['reputationlevelid'])


        $post['level'] = $vbulletin->options['reputationundefined'];
    }
    for ($i = 0; $i <= $reputationbars; $i++)
    {
        if ($i >= 5)
        {
            $posneg = $reputationhighgif;
        }
        else
        {
            $posneg = $reputationgif;
        }

        $post['level'] = $vbphrase['reputation' . $post['reputationlevelid']];
        eval('$post['reputationdisplay'] .= "' . fetch_template('postbit_reputation') . '";');
    }
}

($hook = vBulletinHook::fetch_hook('reputation_image')) ? eval($hook) : false;

return true;
}

/*======================================================================*
|| ####################################################################
|| # Downloaded: 15:56, Tue Apr 8th 2008
|| # CVS: $RCSfile$ - $Revision: 24960 $
|| ####################################################################
*======================================================================*/
?>

Randy_Jackson

At line 119, you have this:

        if (!$post['reputationlevelid'])


        $post['level'] = $vbulletin->options['reputationundefined'];
    }

Somehow, a curly brace was removed. This should work as a replacement:

        if (!$post['reputationlevelid'])
		{

        $post['level'] = $vbulletin->options['reputationundefined'];
    }

Megadeth

I changed it but it didn't make any difference 🙁

CoderDan

Looks to me like your like 115 is the problem.

        eval('$post['reputationdisplay'] = "' . fetch_template('postbit_reputation') . '";');

should be something like:

        eval('$post[\'reputationdisplay\'] = "' . fetch_template('postbit_reputation') . '";');

Megadeth

^ I can't add the two backwards slashes. They disappear after I save the code.

CoderDan

Well, there are other ways to write it without using the backward slashes, but I think you have a bigger problem if your editor isn't saving your code the way it's written.

paulnaj

^ I can't add the two backwards slashes. They disappear after I save the code.

What editor are you using? Just use Notepad or Simpletext or equivalent.

PS. There's another instance of the eval statement about 20 lines further on from the line CoderDan picked out. It'll need fixing - can't quite understand the need to use eval() at all here - what's wrong with just

$post['reputationdisplay'] = fetch_template('postbit_reputation');

Megadeth

^ I changed them both to what you suggested and now it's the same except it says the error is on like 143 (the last line).

Megadeth

(double post cause I can't edit the last post)
This is the error message:

Parse error: syntax error, unexpected '}' in /home/wrestles/public_html/includes/functions_reputation.php on line 143

CoderDan

Might be best to repost your current code, with all the fixes.

Megadeth

<?php
/*======================================================================*
|| #################################################################### ||
|| # vBulletin 3.8.2 - Licence Number VBF068F20C
|| # ---------------------------------------------------------------- # ||
|| # Copyright &#169;2000-2009 Jelsoft Enterprises Ltd. All Rights Reserved. ||
|| # This file may not be redistributed in whole or significant part. # ||
|| # ---------------- VBULLETIN IS NOT FREE SOFTWARE ---------------- # ||
|| # http://www.vbulletin.com | http://www.vbulletin.com/license.html # ||
|| #################################################################### ||
*======================================================================*/

// ## Function takes an array from fetch_userinfo and an array from cache_permissions()
// ## Returns the user's reputation altering power (for positive)
function fetch_reppower(&$userinfo, &$perms, $reputation = 'pos')
{
	global $vbulletin;

// User does not have permission to leave negative reputation
if (!($perms['genericpermissions'] & $vbulletin->bf_ugp_genericpermissions['cannegativerep']))
{
	$reputation = 'pos';
}

if (!($perms['genericpermissions'] & $vbulletin->bf_ugp_genericpermissions['canuserep']))
{
	$reppower = 0;
}
else if ($perms['adminpermissions'] & $vbulletin->bf_ugp_adminpermissions['cancontrolpanel'] AND $vbulletin->options['adminpower'])
{
	$reppower = iif($reputation != 'pos', $vbulletin->options['adminpower'] * -1, $vbulletin->options['adminpower']);
}
else if (($userinfo['posts'] < $vbulletin->options['minreputationpost']) OR ($userinfo['reputation'] < $vbulletin->options['minreputationcount']))
{
	$reppower = 0;
}
else
{
	$reppower = 1;

	if ($vbulletin->options['pcpower'])
	{
		$reppower += intval($userinfo['posts'] / $vbulletin->options['pcpower']);
	}
	if ($vbulletin->options['kppower'])
	{
		$reppower += intval($userinfo['reputation'] / $vbulletin->options['kppower']);
	}
	if ($vbulletin->options['rdpower'])
	{
		$reppower += intval(intval((TIMENOW - $userinfo['joindate']) / 86400) / $vbulletin->options['rdpower']);
	}

	if ($reputation != 'pos')
	{
		// make negative reputation worth half of positive, but at least 1
		$reppower = intval($reppower / 2);
		if ($reppower < 1)
		{
			$reppower = 1;
		}
		$reppower *= -1;
	}
}

($hook = vBulletinHook::fetch_hook('reputation_power')) ? eval($hook) : false;

return $reppower;
}

// ###################### Start getreputationimage #######################
function fetch_reputation_image(&$post, &$perms)
{
	global $stylevar, $vbphrase, $vbulletin;

if (!$vbulletin->options['reputationenable'])
{
	return true;
}

$reputation_value = $post['reputation'];
if ($post['reputation'] == 0)
{
	$reputationgif = 'balance';
	$reputation_value = 0;
}
else if ($post['reputation'] < 0)
{
	$reputationgif = 'neg';
	$reputationhighgif = 'highneg';
	$reputation_value = $post['reputation'] * -1;
}
else
{
	$reputationgif = 'pos';
	$reputationhighgif = 'highpos';
}

if ($reputation_value > 500)
{  // bright green bars take 200 pts not the normal 100
	$reputation_value = ($reputation_value / 2) + 250;
}

$reputationbars = intval($reputation_value / 100); // award 1 reputation bar for every 100 points
if ($reputationbars > 10)
{
	$reputationbars = 10;
}

if (!$post['showreputation'] AND $perms['genericpermissions'] & $vbulletin->bf_ugp_genericpermissions['canhiderep'])
{
	$posneg = 'off';
	$post['level'] = $vbphrase['reputation_disabled'];

         $post['reputationdisplay'] = fetch_template('postbit_reputation'); 
}
else
{
	  if (!$post['reputationlevelid'])


        $post['level'] = $vbulletin->options['reputationundefined'];
    } 
	for ($i = 0; $i <= $reputationbars; $i++)
	{
		if ($i >= 5)
		{
			$posneg = $reputationhighgif;
		}
		else
		{
			$posneg = $reputationgif;
		}

		$post['level'] = $vbphrase['reputation' . $post['reputationlevelid']];
		 $post['reputationdisplay'] = fetch_template('postbit_reputation'); 
	}
}

($hook = vBulletinHook::fetch_hook('reputation_image')) ? eval($hook) : false;

return true;
}

/*======================================================================*
|| ####################################################################
|| # Downloaded: 15:56, Tue Apr 8th 2008
|| # CVS: $RCSfile$ - $Revision: 24960 $
|| ####################################################################
*======================================================================*/
?>

CoderDan

Randy Jackson;10922315 wrote:
At line 119, you have this:
        if (!$post['reputationlevelid'])


        $post['level'] = $vbulletin->options['reputationundefined'];
    }
Somehow, a curly brace was removed. This should work as a replacement:
        if (!$post['reputationlevelid'])
		{

        $post['level'] = $vbulletin->options['reputationundefined'];
    }

You didn't apply his fix.