oop class y does this work

kiwi2

class classname
{
var item1;
var item2;
var item3;
function whateverulike()
{
/fetch some data from db/
$this->item = $row[item1];
ect;
}
}
this is not what u wld call a "proper" class, yet it works, why, why?, I want 2 write everything like this now!, it's not right, but it works, can anyone explain it 2 me, pls, pls, no get, no set, no private, no public..., HELP, it WORKS, why??

laserlight

kiwi2 wrote:
it's not right, but it works, can anyone explain it 2 me, pls, pls, no get, no set, no private, no public..., HELP, it WORKS, why??

Whether it is right or not depends on your point of view. Syntactically, ignoring non-existent variables and the "etc", it is correct. The use of the var keyword is from PHP 4, and it effectively declares the variables as public. The lack of getters and setters is not necessarily a sign of bad design.

By the way, post PHP code in [noparse]

[/noparse] bbcode tags.

NogDog

A method declaration with no public/protected/private keyword is made public by default (much as using the old-fashioned "var" keyword makes that class variable public. So as long as you want those class members to be public, the "public" is optional. So perhaps the real question you need to address is when members should be public, protected, or private.

kiwi2

Do u mean I can go ahead, and it's not incorrect, & I shldnt be learning something else!

laserlight

kiwi2 wrote:
Do u mean I can go ahead, and it's not incorrect, & I shldnt be learning something else!

You should be learning the PHP 5 syntax, but there is no harm also learning the PHP 4 syntax as it can help if you have to maintain scripts written for PHP 4.

NogDog

It is "correct", but I would recommend declaring everything explicitly just to make the interface clearer when reading the code.

I would prefer to see this:

class Foo
{
   public $someVariable;

   public function __construct($var)
   {
      $this->someVariable = $var;
   }

   public function bar()
   {
      echo $this->someVariable;
   }
}

...instead of this...

class Foo
{
   var $someVariable;

   function Foo($var)
   {
      $this->someVariable = $var;
   }

   function bar()
   {
      echo $this->someVariable;
   }
}

...unless you need your code to be backwards compatible with the no longer supported PHP4.

kiwi2

thanx 4 all the help..!