If statement not working

[LJUK]

Hi all.

I've been working on this piece of code, and I can't figure out why it won't work.

if (mysql_num_rows($res1) > 0) {
while($row = mysql_fetch_assoc($res1)) {
			echo "".$row['ReviewFormat']."";



		}

		}
		else {
			echo "morning";
		}

The code doesn't display the morning message. The query is correct as it works with data in the DB, but when I remove it, I get a blank area instead of the morning message. 😕

Can anyone help?

[tommyc21]

if($row[ReviewFormat] == "0")
{
	echo "";
}
else 
{
              echo "morning";
}

[tommyc21]

your Query is rong it should be laid out something like this

$sql = "SELECT ReviewFormat FROM yourdatabase WHERE theid ";
if ($rows = mysql_num_rows($sql)) 
{
  while($row = mysql_fetch_assoc($rows)) 
      {
      if($row[ReviewFormat] == "0") 
 { 
    echo ""; 
 } 
  else 
 { 
    echo "morning"; 
 }
}
}

Not like

if (mysql_num_rows($res1) > 0) {
while($row = mysql_fetch_assoc($res1)) {

[LJUK]

The problem I have, is there are 5 or 6 rows I'll be using. I haven't been able to get it working so stripped it right down and started at the beginning with just 1 field. Is it possible to do it with this many fields?

[tommyc21]

im not entiley sure but im guessin you can do it like this

      if($row[ReviewFormat] == "1") 
{ 
    echo "morning"; 
} 
  else 
{ 
    echo ""; // emty echo's is fine they will not show up
} 
      if($row[ReviewFormat] == "2") 
{ 
    echo "after noon"; 
} 
  else 
{ 
    echo ""; 
}
      if($row[ReviewFormat] == "3") 
{ 
    echo "evening"; 
} 
  else 
{ 
    echo "";
}

[Bjom]

wrong:
$row[ReviewFormat]

right
$row['ReviewFormat']

mysql is dead - mysqli is the way to go

Other than that:

The original code is fine. However you say:

but when I remove it

....

then the numrows most likely produces an error...

try this instead:

if (mysql_num_rows && mysql_num_rows($res1) > 0) {

and keep the rest of your original code. looks ok.

One thing perhaps:

echo "".$row['ReviewFormat']."";

What are the "" good for? it is the same as

echo $row['ReviewFormat'];

or if you plan to add text in front and behind then use single quotes ' intstead of double ".

[LJUK]

Thanks for the replies all. I won't get a chance to mess around with the code until early next week, but will let you know how it goes!