can never get the content in functions to display

[tommyc21]

for some reason i can never get the content in functions to display is there some thin i have done rong ?

        $query2="SELECT * from friends as a,users as b where a.addid='$rprofile[ID]' and b.ID=a.addedid order by acep='1' DESC";
       $command2 = mysql_query ($query2)
		or die($db_error);
$result1 = mysql_fetch_assoc($command2);
function render_table($result2, $display_columns=3)
{
    $padding = ($display_columns - 1) - (($count - 1)%$display_columns);
    echo '<table>';
    for($i=0; $i<$count; $i++)
    {
        if($i % $display_columns == 0)
            echo '<tr>';
        echo '<td>';
        render_cell($result2[$i]);
        echo '</td>';
        if($i % $display_columns == $display_columns - 1)
            echo "</tr>";
    }
    if($padding != 0)
    {
        for($i=0; $i<$padding; $i++)
            echo '<td></td>';
        echo '</tr>';
    }
    echo '</table>';
}
    function render_cell($result1)
{
    $link = $result2['username'];
    $image = $result2['mainpath'];
    echo "<a href='$link'><img src='photos/$link/$image' title='$link' alt='$link' /></a>";
}

echo render_table($result2);

[paulnaj]

Hi Tommy,

You're getting in a bit of a mess here, I'm afraid.

1. You don't need to echo out render_table(). It is doing the echo-ing itself.
2. You've set the variable $result1, but passed $result2 to render_table() (you've mixed up the vars in render_call too).

P 🙂

[tommyc21]

sorry i pasted the code i was messing about with here i the 1 i was useing

       $sql="SELECT * from friends as a,users as b where a.addid='$rprofile[ID]' and b.ID=a.addedid LIMIT 0,9";
       $resultset = mysql_query($sql);
       while($record = mysql_fetch_assoc($resultset));
       $record[] = $records;
function render_table($records, $display_columns=3)
{
    $padding = ($display_columns - 1) - (($count - 1)%$display_columns);
    echo '<table>';
    for($i=0; $i<$count; $i++)
    {
        if($i % $display_columns == 0)
            echo '<tr>';
        echo '<td>';
        render_cell($records[$i]);
        echo '</td>';
        if($i % $display_columns == $display_columns - 1)
            echo '</tr>';
    }
    if($padding != 0)
    {
        for($i=0; $i<$padding; $i++)
            echo '<td></td>';
        echo '</tr>';
    }
    echo '</table>';
}

function render_cell($record)
{
    $user = $record['username'];
    $image = $record['mainpath'];
    echo "<a href='$user'><img src='photos/$user/$image' title='$user' alt='$user' /></a>";
}
render_table($result1);

even if i romove $record[] = $records; and change the bottom the top function sql strings back to record it just out puts the same and that nothing

its not realy the sql thats fine works on other things just functions they do my headin

[Weedpacket]

1. Where does $result1 get defined?

2.        while($record = mysql_fetch_assoc($resultset)); 

   The semicolon ends the while loop immediately - you probably don't want that.

3.        $record[] = $records; 

   That's almost certainly the wrong way around (even if it was part of the loop on the previous line, which it's not because of that semicolon in the previous point).

[tommyc21]

ok i have finaly got it to out put but just got a small probilem it only out puts 1 friend 9 times any 1 no how i can get it to out put 9 friends? instead of the 1 friend 9 times?

$sql="SELECT * from friends as a,users as b where a.addid='$rprofile[ID]' and b.ID=a.addedid order by a.associd DESC";
      $command = mysql_query ($sql);
       $record = mysql_fetch_assoc($command);
function render_table($record, $display_columns=3)
{
    $padding = ($display_columns - 1) - (($count++ - 0)%$display_columns);
    echo '<table>';
        for($i=0; $i<9; $i++)
    {
if($i % $display_columns == 0)
            echo '<tr>';
        echo '<td>';
        render_cell($record);
        echo '</td>';
        if($i % $display_columns == $display_columns - 1)
            echo '</tr>';
    }
    if($padding != 0)
    {
        for($i=0; $i<$padding; $i++)
            echo '<td></td>';
        echo '</tr>';
        }
    echo '</table>';
}
    function render_cell($record)
{
    $user = $record['username'];
    $image = $record['mainpath'];
    echo "<a href='$user'><img src='photos/$user/$image' title='$user' alt='$user' /></a>";
}

render_table($record);

[Weedpacket]

        render_cell($record); 

You set the value of $record outside the loop but never change it inside the loop. So it has the same value every time.

[tommyc21]

so what do i do some thing like

render_cell($record["addedid]"); 

or

]render_cell($user);

[johanafm]

Change the last part to

if ($command)
	render_table($command);

And then change

function render_table($record, $display_columns=3) 
// ...
        for($i=0; $i<9; $i++)

To

function ($command, $display_columns=3)
// ...
	while ($record = mysql_fetch_assoc($command)

[tommyc21]

thanks all for your help its working now well i have some things to tweak but atleast its working i will repost it when im done so people can have it thanks 🙂