regex help needed

Good2CU

These 2 don't seem to be matching as intended:

if (preg_match('#_(a-d)\.jpg^#i', $url)) {

I want to match any urls that end with "_#.jpg" where # can be a, b, c, or d

and

} else if (preg_match('#_(1-4)\.jpg^#i', $url)) {

I want to match any urls that end with "_#.jpg" where # can be 1, 2, 3, or 4

Thanks in advance

NogDog

"^" is the start-of-string assertion. For the end-of-string assertion you want "$".

Weedpacket

And it's [1-4], not (1-4).

nrg_alpha

You could combine both preg_matches into one as such:

if (preg_match('#_[1-4a-d]\.jpg$#i', $url)) {

As Weedpacket was saying, use [..] instead of (...).
The difference is that [..] is a character class while (...) is a capturing group.

So by using [1-4a-d], this is saying, match a single character that is between 1 and 4 or a thru d where as (a-d) as you have done will look for an a, followed by a dash, followed by a d, all of which is captured (and thus stored into a numerical variable like $1).

You can learn more about pcre at the following links:

http://ca2.php.net/manual/en/book.pcre.php
http://www.regular-expressions.info/
http://weblogtoolscollection.com/regex/regex.php

Should be more than enough to help get you started.