[RESOLVED] Function error

wiqi

Hey guys,
Please help me. I have created the following function

function svar($ab)
{
if(isset($ab))
{
echo $ab;}
}
}

when ever i try to pass variable to the function e.g.

svar($fname);

it gives the following error.
Notice: Undefined variable: fname in C:\ etc etc

please help me out!

paulnaj

Hi,

Just to be correct - it's not actually an error, just a notice that $fname has no value when passed to your function.

The function is receiving a variable that has no value and warning you about it. It means the function is not going to do the job you hoped (check if a variable has a value and if so print it).

You could just do ...

if(isset($fname)) echo $fname;

... of course.

Paul.

NogDog

Just to clarify, the notice is not coming from the function, but from your attempt to call that function with an undefined variable.

wiqi

while writing the code with if(isset($fname)), code works very fine. but problem is i have to write down this thing at 24 or more places at a page so i want to make the code concise. if there's any other way you can suggest?

wiqi


<html>
<title>IPD Record Editing ::HMS</title>
<style type="text/css">
<!--
.style2 {font-size: 12px}
.style4 {
	font-size: 16px;
	color: #000000;
	font-weight: bold;
}
.style9 {font-size: 12px; color: #333333; font-weight: bold; }
.style10 {color: #000000}
.style12 {font-size: 12px; color: #000000; }
-->
</style>
<body>

<table width="679" border="0">
  <tr>
    <th height="94" colspan="2" scope="col"><img src="hmsh.gif" width="963" height="177"></th>
  </tr>
  <tr>
    <th colspan="2" scope="col"><?php include("toolbar.php"); ?></th>
  </tr>
  <tr valign="top">
    <td width="153" rowspan="2" scope="row">
	<?php include("menu.php"); ?>	</td>
    <td width="742" bgcolor="#A7B5CE" scope='row'><p align='left'>Edit  Patient Information</p>
    </td>
  </tr>
  <tr>
    <td scope='row'><?php if($session->logged_in){

				if (empty($_GET['pid']))
				{	$pid='undefined';}
						else
						{$pid= $_GET['pid'];}

			$tbl='ipd';
			$sql = "SELECT * FROM $tbl WHERE pid='$pid'";
			$query = mysql_query($sql); 
			while ($row = mysql_fetch_array($query)){
			$rid = $row["rid"];
			$bed=$row["bed"];
			$days=$row["days"];
			$fname=$row["fname"];
			$lname=$row["lname"];
			$bgroup=$row["bgroup"];
			$age=$row["age"];
			$addr=$row["addr"];
			$phno=$row["phno"];
			$city=$row["city"];
			$dstat=$row["dstat"];
			$ddate=$row["ddate"];
			$adate=$row["adate"];
			$gen=$row["gen"];
			$ward=$row["ward"];
			$diag=$row["diag"];
			$trtm=$row["trtm"];
			$achar=$row["achar"];
			$tchar=$row["tchar"];
			$paid=$row["paid"];
			$docid=$row["docid"];
			$status=$row["status"]; 
			 }
			 mysql_free_result($query);



			 ?> 


<form action='vipd.php' method='get'>
      <table width="100%" border="0">
          <tr>
            <td width="26%"> Enter ID </td>
            <td width="74%"><label>
              <input type="text" name="pid" id="pid">
            </label></td>
          </tr>
          <tr>
            <td width="26%">&nbsp;</td>
            <td><input name="View Record" type="submit"></td>
          </tr>
          <tr>
            <td width="26%">&nbsp;</td>
            <td>&nbsp;</td>
          </tr><?php if($pid!="undefined")
				 {
			function svar($ab)
			{
			if(isset($ab))
			{ echo $ab; } }

			 ?>
      <tr>
        <td width="26%" bgcolor="#CCCCCC">First Name</td>
        <td bgcolor="#CCCCCC"><?php svar($fname); ?></td>
      </tr>
      <tr>
        <td>Last Name </td>
        <td><?php if(isset($fname))echo $lname; ?></td>
      </tr>
      <tr>
        <td bgcolor="#CCCCCC">Age</td>
        <td bgcolor="#CCCCCC"><?php if(isset($fname))echo $age; ?></td>
      </tr>
      <tr>
        <td>Blood Group </td>
        <td><?php if(isset($fname))echo $bgroup; ?>             </td>
      </tr>
      <tr>
        <td bgcolor="#CCCCCC">Address</td>
        <td bgcolor="#CCCCCC"><?php if(isset($fname))echo $addr; ?></textarea></td>
      </tr>
      <tr>
        <td>Phone No </td>
        <td><?php if(isset($fname))echo $phno; ?></td>
      </tr>
      <tr>
        <td bgcolor="#CCCCCC">City</td>
        <td bgcolor="#CCCCCC"><?php if(isset($fname))echo $city; ?></td>
      </tr>
      <tr>
        <td>Gender</td>
        <td>
          <?php if(isset($fname))echo $gen; ?>                </td>
      </tr>
      <tr>
        <td bgcolor="#CCCCCC">Date Discharge </td>
        <td bgcolor="#CCCCCC"><?php if(isset($fname))echo $ddate ;?></td>
      </tr>
      <tr>
        <td>Days Stayed </td>
        <td><?php if(isset($fname))echo $days ;?></td>
      </tr>
      <tr>
        <td bgcolor="#CCCCCC">Ward</td>
        <td bgcolor="#CCCCCC"><?php if(isset($fname))echo $ward; ?></td>
      </tr>
      <tr>
        <td>Diagnose</td>
        <td><?php if(isset($fname))echo $diag; ?></textarea></td>
      </tr>
      <tr>
        <td bgcolor="#CCCCCC">Treatment</td>
        <td bgcolor="#CCCCCC"><?php if(isset($fname))echo $trtm; ?></td>
      </tr>
      <tr>
        <td>Discharge Status </td>
        <td><?php echo $dstat; ?></td>
      </tr>
      <tr>
        <td bgcolor="#CCCCCC">Room ID </td>
        <td bgcolor="#CCCCCC"><?php echo $rid;?></td>
      </tr>
      <tr>
        <td>Bed ID </td>
        <td><?php echo $bed;?></td>
      </tr>
      <tr>
        <td bgcolor="#CCCCCC">Dr ID </td>
        <td bgcolor="#CCCCCC"><?php echo $docid;?></td>
      </tr>
      <tr>
        <td>Admit Charges </td>
        <td><?php echo $achar; ?></td>
      </tr>
      <tr>
        <td bgcolor="#CCCCCC">Total Charges </td>
        <td bgcolor="#CCCCCC"><?php echo $tchar; ?></td>
    </tr>
      <tr>
        <td>Paid Amount </td>
        <td><?php echo $paid;?></td>
      </tr>
      <tr>
        <td bgcolor="#CCCCCC">Billing Status </td>
        <td bgcolor="#CCCCCC"><?php echo $status;  ?></td>
      </tr> <?php } else { echo "Cannot find the reord you specified";}
	  ?>
      <tr>
        <td>&nbsp;</td>
        <td><input name='Go Back' type='button' id="Go Back" value='Go Back' onClick="history.go(-1);return true;" /></td>
      </tr>
  </table> 
</form>  

<?php }
	  else
	  {
	  echo "you are not logged in.";   } ?>
	  </td>
 </tr>
 </table>
</body>
</html>

wiqi

i was working on the page.. every if(isset($variable)) will be different in the end

mblack0508

wiqi;10923081 wrote:
i was working on the page.. every if(isset($variable)) will be different in the end

I read everything I dont know what you're trying to accomplish by having only $fname go through the function, but to make the function work as intended

function svar($ab=null)
{
if(isset($ab))
{
echo $ab;}
}
}

mblack0508

bah realized I made a mistake so ignore the update I made, I was under the assumption $fname was being set above. if I were you, I would treat $fname like the other vars instead of calling a function, which from the quick browse I did you only used once, you should just do, as someone earlier in this thread suggested:

if (isset($fname)) { echo $fname; }

quickest and cleanest solution.

paulnaj

The thing is, why are you testing the same thing 24 times?. In fact why are you testing to see if $fname is set. Surely, by that time every one of those variables will have been set, even if it's to NULL (edit: mysql NULL value).

mblack0508

paulnaj;10923090 wrote:
The thing is, why are you testing the same thing 24 times?. In fact why are you testing to see if $fname is set. Surely, by that time every one of those variables will have been set, even if it's to NULL (edit: mysql NULL value).

I'm not 100% on this but if you return a row, you dont get a null. More to the point if mysql_fetch_array returns false, the while statement doesnt even process once. And thus his current error when the user isnt found.

He should be doing an if statement instead of a while, since he only wants one record and only one should be returned.

Now off the top of my head this is what he should have done.

if ($row = mysql_fetch_array($query)) {
 // set vars to values returned
}
else {
 // set vars to values to null
}

wiqi

thanks mblack0508. $ab=null worked fine.. Hats off!