Calling a method from an included class?

[Pinkmischief]

Hi guys

I have a query regarding how to do this
say for example i have 3 or more classes

connections.php
users.php
login.php

now
in each of these files is the following.

//In our login page we have the usual code if isset etc..

include_once('users.php');
if(isset($_POST['Submit'])){

$newuser = new user;
$newuser -> setlogin($_POST);
}

include_once('connections.php');
class user {
 public $username;
 public $password;


public function setlogin($_POST){

$this->username = $_POST['username'];
$this->password = $_POST['password'];
// Now i want to send these details to connections.php
$newconnection = new connection;
$newconnection->checkdb("SELECT * FROM `users` WHERE `username` = '".$this->username."');
}

class connection {
 private $username = "root";
 private $password = "";
 private $server = "localhost";
 private $db = "users";
 private $connectionlink;

private function connect(){
$this->connectionlink = mysql_connect($this->server,$this->username,$this->password);
mysql_select_db($this->db,$this->connectionlink);
}

public function checkdb($sql){

 mysql_query($sql);
 if(mysql_num_rows($sql) == 0){
echo "no results found";
}

}

How can i do this please?

Im quite new to using Classes in PHP , So there may be some small errors there.

Also i know theres no MYSQL_REAL_ESCAPE_STRING on the posts for SQL injections but as this is a dummy script i wrote as i was posting i didnt bother with that 🙂

Many Thanks Pink.

[mblack0508]

I dont see why it wouldnt work, but then again I'm not evaluating the code specifically just that you're loading multiple classes.

You have an error in one piece of code I caught

$newconnection->checkdb("SELECT * FROM `users` WHERE `username` = '".$this->username."'); 

should be:

$newconnection->checkdb("SELECT * FROM `users` WHERE `username` = '".$this->username."'"); 

On another note, and this is just personal preferences, I would check out PDO instead of using the standard mysql driver.

You can do prepared statements which is better in my opinion. Like an example below

$dbh = new PDO("mysql:host=localhost;dbname=mydb", "user", "pass");
$stmt = $dbh->prepare("SELECT * FROM users WHERE username = ?");
$stmt->bindParam(1, $this->username, PDO::PARAM_STR);
$stmt->execute();
if (!$res = $stmt->fetch()) {
   echo "No data return!\n";
}
else {
  // process data returned
}

[Pinkmischief]

Oh cool i didnt know i could set sql statements and use them over and over 🙂

Thx for spotting that error there too , I will be sure to look into prepared statements a bit more.

If i can do it this way too would be good always good to know more than one way to skin a cat 🙂

Thanks for your reply 🙂

[Pinkmischief]

I got these 3 pages and am still trying to incorporate this way but no joy...

index.php

<?php 
include_once("scripts/userclass.php");
include_once("scripts/connectclass.php");
if(isset($_POST['Submit_login'])){
$newuser = new user;
$newuser->setuserdetails($_POST);
}
?>

userclass.php

<?php 
include("connectclass.php");
 $newconnection = new connection;
$newconnection -> connect();
class user{

public $username;
public $password;

public function setuserdetails($_POST){

	$this->username = mysql_real_escape_string($_POST['username']);
	$this->password = mysql_real_escape_string($_POST['password']);

		if(($this->username == "") || ($this->password == "")){
			echo "Fields are blank";
		}else{
		$sql = "SELECT * FROM `users` WHERE `username` = '".$this->username."' AND `password` = '".$this->password."'";

		$newconnection->handlesql($sql);

		}

}

}
?>

connectclass.php

<?php 
class connection{

private $server = "localhost";
private $username = "root";
private $password = "";
private $db = "mydatabase";

public $connectionlink;


public function connect(){

$this->connectionlink = mysql_connect($this->server,$this->username,$this->password);

mysql_select_db($this->db,$this->connectionlink);

}

public function handlesql($sql){
	echo $sql;


}


}


?>

Now the error when i run this i get is this

Notice: Undefined variable: newconnection in C:\wamp\www\mytest\scripts\userclass.php on line 20

Fatal error: Call to a member function handlesql() on a non-object in C:\wamp\www\mytest\scripts\userclass.php on line 20

Can anyone tell me why i get this error please?

Regards Pink 😉

[Pinkmischief]

When i add a variable with public attribute like below

public $newconnection = new connection;

and try calling the handlesql();

like $this->newconnection->handlesql($sql);

I get a Parse error: parse error in C:\wamp\www\mytest\scripts\userclass.php on line 8

[mblack0508]

Pinkmischief;10923475 wrote:

When i add a variable with public attribute like below

public $newconnection = new connection;

and try calling the handlesql();

like $this->newconnection->handlesql($sql);

I get a Parse error: parse error in C:\wamp\www\mytest\scripts\userclass.php on line 8

can you paste the code exactly?

[Bjom]

mysql is being phased out anyway. mysqli is the replacement and it comes oo and with prepared statements. PDO...if you like it....

Does this need to be public?

public $newconnection = new connection;

You could try:

private $_newconnection = null;
...
//in the constructor:
public function __construct()
{
$this->_newconnection = new connection();
$this->_newconnection->connect();
}

[mblack0508]

Bjom;10923665 wrote:

mysql is being phased out anyway. mysqli is the replacement and it comes oo and with prepared statements. PDO...if you like it....

Sure but mysqli is better than the old mysql functions, but it makes the code less portable. PDO solves the database backend situation. Since I use PDO only now, I'm a little fuzzy but I'm pretty sure the OO part of mysqli is pretty much the same as PDO.

[Bjom]

I'm pretty sure the OO part of mysqli is pretty much the same as PDO.

I'm not sure what you mean. Syntax? Well it's both OO, so there are similarities, but it's not exactly the same, of course.

makes the code less portable

Code will be equally portable compared to mysql, but I'm sure you mean: mysqli code is less portable than PDO code.

There exist different points of view about that topic. I'm personally on the portability sceptics side (plus I tried PDO and didn't like it, but that is a matter of taste - hence my comment ...if you like it...).

Bjom

[mblack0508]

Code will be equally portable compared to mysql, but I'm sure you mean: mysqli code is less portable than PDO code.

Its more about preferences, most people wont need to switch to it. I feel its more of a good practice. Although I agree with you that mysqli is better than mysql extension.