Learning PHP - log in system wont work

Benjipie

Hi, Im slowly making my way through a php book 'PHP and MySQL Web Development' and found myself stuck trying to make a simple log in system. I've checked my code against that in the book and cant find any errors so im hoping someone here can help.

Here's the code.

<?php
session_start();

if (isset($_POST['userid']) && isset ($_POST['password'])) {
    //if the user has just tried to log in;

$userid = $_POST['userid'];
$password = $_POST['password'];

$db_conn = new mysqli('my.server.com', 'username', 'password', 'database');

if (mysqli_connect_errno()) {
    echo 'connection to the database has failed: '.mysqli_connect_error();
    exit();
}

$query = 'selsect * from authorized_users '
          ."where name = '$userid' "
          ."and password =sha1('$password')";

$result = $db_conn->query($query);

if ($result->num_rows > 0) {
    //if they are in the database register the user id;
    $_SESSION['valid_user'] = $userid;
}

$db_conn -> close();
}
?>

<html>
<body>

<h1>Home Page</h1>

<?

if (isset($_SESSION['valid_user'])) {

echo 'you are logged in as ' . $_SESSION['valid_user'] . '<br />';
echo '<a href = "logout.php">log out</a><br />';
}else{
    if (isset($userid)) {
        //if they've tried to log in and failed;
        echo "could not log you in";
    }else{
        //they have not tried to log in yet;

    echo "you are not logged in";
}

//privide for to log in;
echo '<form method="POST" action="authmain.php">';
echo '<table>';
echo '<tr><td>Userid: </td>';
echo '<tr><input type="text" name="userid"></td></tr>';
echo '<tr><td>Password: </tr>';
echo '<td><input type="password" name="password"<td>';
echo '<tr><td colspan="2" align="center" >';
echo '<input type="submit" value="log in"></td></tr>';
echo '</table></form>';
}
?>


</body>
</html>

Thanks. Ben.

Bjom

What errors do you get, why do you post here, what needs our attention, where do you need help? (could you replace [ code][ /code] with [ php] [ /php], please) ?

Bjom

there is a typo in your query:

selsect --> SELECT

it is common practice and a good idea to write all SQL keywords in capitals.

add this to the query part:

$result = $db_conn->query($query) or trigger_error('Query error: ' . $db_conn->error, E_USER_ERROR);

good that you are using mysqli and not mysql 🙂