[RESOLVED] Returning multiple arrays in a class and referencing that array?

[Pinkmischief]

Hi guys

I have a class which im working on as a personal improvement project to try to understand classes better. 🙂

I know theres mysqli which i have been told you can do pre-determined statements on. But this is just a project for me to get a better understanding of classes and how certain things would be done in them

My method/function

    function retrieveallrows($table){

$this->generatedsql = "SELECT * FROM `".$table."`";
$this->query = mysql_query($this->generatedsql);
while($this->result = mysql_fetch_array($this->query)){
		$this->returnarray();

		}
}

and the return array method

function returnarray(){

	return( $this->result);	

}

I understand that return will end the method retrieveallrows as soon as the return is executed.

And no results will be displayed.

The page i am calling this class from is

$new = new connection;
$new->retrieveallrows("users");

And now the tricky part lol or i think so...

I have a dropdown on the same page and im trying to fill it with the value of id and displayed value of username

These are columns 0 and 1 in the table.

So $this->result[0]; would be the user id
and $this->result[1]; would be the username
The Dropdown Menu

 <select name="users">
         <option>Please select a user</option>
         <?php 
		echo "<option value = '$new->returnarray([0])'>$new->returnarray([1])</option>";

   ?>
   </select>

Is this possible or is retrieving multiple arrays and being able to reference the values inside that array in an external page?

Many Thanks to all who reply

Pink. 🙂

[CoderDan]

you probably want to move your $this->returnarray(); call to after the while loop, (or just remove it altogether, it's not needed) and change the while loop call to while($this->result[] = mysql_fetch_array($this->query)){} or similar, and then you can use $obj->result[$row][$field] after teh object has been prepped.

[Pinkmischief]

I tried with the following code

    function retrieveallrows($table){
       $this->generatedsql = "SELECT * FROM `".$table."`";
	$this->query = mysql_query($this->generatedsql);
	while($this->result[] = mysql_fetch_array($this->query)){}
    }

function returnarray(){

	print($this->result);	

}

Then inbetween the dropdown tags i put

echo $new->returnarray[0];

Im using returnarray because i was told its bad practice to reference an objects property directly?

Is this true ?

But still no results are shown from returnarray()?

Many thanks for the reply🙂

Pink

[CoderDan]

well, you're looking at $new->returnarray, assuming $new is your object of the class, then you'd want to look at $new->result now instead. also, print takes a string as an argument, not an array, and it prints, it doesn't return anything, so your returnarray function returns nothing.
As I mentioned, if you directly read off $new->result then you don't even need returnarray function. if you want to use it still, you can have returnarray return $this->result

also, I'm assuming you are posting code from within a class - if it's procedural, then it's different again.
If you could post all your related code, it would help to figure it out.

[Pinkmischief]

This is the full PHP class im working on and just trying to perform various db things as you can see some of the functions are empty at the moment.

<?php 

class connection{

var $server = "localhost";
var $username = "root";
var $password = "";
var $db = "nopvc";
// The generated SQl 
var $generatedsql;
var $query;
var $connection;
//Status returned from query;
var $status;
// Num Rows 
var $numrowsfromquery;
// The result array from a query
var $result = array();



function connect(){

$this->connection = mysql_connect($this->server,$this->username,$this->password);
mysql_select_db($this->db,$this->connection);

}


function insert($_POST,$table){


array_pop($_POST);
$sql = "INSERT INTO `".$table."`";
$sql.= "(";
//Count the array 
	$aryamt = count($_POST);
	$i = 0;

	while($i < $aryamt){
			$sql.= "`".key($_POST)."`,";
		next($_POST);
		$i++;

}
$i = 0;
//count the string 
$strlen = strlen($sql);
$sql = substr($sql,0,-1);


// Add the closing ) 
$sql.=") VALUES (";
foreach($_POST as $key=>$value){
	if($key == "password"){
		//echo "password found";
		$sql .= "'".mysql_real_escape_string(md5($value))."',";
		}else{
		$sql.= "'".mysql_real_escape_string($value)."',";
		}
}

$strlen = strlen($sql);
$sql = substr($sql,0,-1);
$sql.=");";

$this->generatedsql = $sql;

//Perform the query()
$this->performquery();
}


function performquery(){

$this->query = mysql_query($this->generatedsql);
// Any rows from query ?

$this->numrowsfromquery = @mysql_num_rows($this->query);

// if no rows
if ($this->numrowsfromquery != 0){
	$this->status = $this->numrowsfromquery;
	$this->result = mysql_fetch_array($this->query);
	$this->returnstatus();
}
	if($this->query == false){

	$this->status =  "Error performing the sql : ".$this->generatedsql;
	}


}


function duplicaterowcheck(){



}


function update(){






}

function deleterow(){






}




function deleteall(){







}




function retrieveonerow($searchvalue,$field,$table){
$this->generatedsql = "SELECT * FROM `".$table."` WHERE `".$field."` = '".mysql_real_escape_string($searchvalue)."'";
$this->performquery();
}


function retrieveallrows($table){
$this->generatedsql = "SELECT * FROM `".$table."`";
$this->query = mysql_query($this->generatedsql);
while($this->result[] = mysql_fetch_array($this->query)){}
}

function setsession($uid,$uname,$ulvl){
	session_start();
	$_SESSION['sid'] = session_id();
	$_SESSION['user_id'] = $uid;
	$_SESSION['user_lvl'] = $ulvl;
	$_SESSION['user_name'] = $uname;

}


function returnstatus(){
	return $this->status;	
}


function returnarray(){

	print($this->result);	

}


}
?>

And in the page where i create the instance

$new = new connection;
$new->retrieveallrows("users");
   <select name="users">
         <option>Please select a user</option>
         <?php 
		echo $new->returnarray[0];

   ?>
   </select>

Many thanks for all your help Dan 🙂

Regards Pink.

[CoderDan]

ok, your fetchallrows should initialize this->result to an empty array before the while, so if the same class instance has the function run twice it doesn't gather double results.
(personally I wouldn't store it into a class var at all, but into a fun var that is returned by the fun)
in fact, I'll tell you how to do that rather than just making what you have work:
change:

    function retrieveallrows($table){
    $this->generatedsql = "SELECT * FROM `".$table."`";
    $this->query = mysql_query($this->generatedsql);
    while($this->result[] = mysql_fetch_array($this->query)){}
    } 

to:

    function retrieveallrows ( $table ) {
    $this->generatedsql = "SELECT * FROM `".$table."`";
    $this->query = mysql_query($this->generatedsql);
    $return_array = array();
    while($this->result = mysql_fetch_array($this->query)){
      $return_array[] = $this->result;
    }
    return $return_array;
    }

Although I'm still really not sure why you're making a class for this, and why you're storing queries and results as members of this class...

anyhows, if you do this, then your output code can be:

$new = new connection;
$all_users_array = $new->retrieveallrows("users"); 

and then you can loop through $all_users_array which should be a multidimensional array of the nature $all_users_array[$row_num][$field_name] == 'field value for row'
and as such you can do:

foreach ( $all_users_array as $user )
{
  echo "<option value='$user[idfield]'>".htmlentities( $user['namefield'] )."</option>\n";
}

}

[Pinkmischief]

Will try that way Dan

My Reasoning for this class.

Im just making a class for it because i got fed up keep typing out the SQL statements so i thought if i have pre-prepared statements like the ones in that file

Its only my 2nd attempt at a class file structure , So im not 100% sure on what i should be storing for it to "validate" being a class lol if thats the right term.

I could just pass a value and append it to the pre written statement

So like
$new->retrieveallrows("users");

I know theres probably a lot of other easier ways to do this 😉

But when we choose the easiest option i find i dont learn anything 🙂

After all anybody can copy/paste but if you dont know what you are copying/pasting then you are lost if problems arise 😉

As you can see i have a few other functions to do but if i can get this to work i feel it will make my life a little easier as i have always worked procedural coding before attempting classes, So i ended up with about a million functions....

example if to register a user i had a function reguser which had an sql and query and result and then login function for that and if admin section would have addnews,deletenews,editnews functions for each page....

I have been told that using frameworks like Joomla,ROR,Drupal are good for implementing a CMS system but i have no idea how they work and i when i inspected the code it looked very very confusing... Considering im new to classes..

Thanks Dan

Regards Pink 😉

[Pinkmischief]

Works like a charm!!

Now just to dissect it and comment it out for references so when i look back on it i know whats happening 🙂

and have to do some research on htmlentities ( Havent seen that before....) lol

one last question with that code will that retrieve any array from any specified table?

So if i send the param ("news")

It will dragall rows from the news table in the db and i can simply reference them the same way as the users?

Many Thanks Dan

[CoderDan]

Well, I think you'd be doing yourself a big favour if you looked at the mysqli class - it's now a core part of php, and I think will do what you need - I'm slightly ashamed to admit I don't use it myself, however my full time job is working on a codebase that was started about 6 years ago, by someone else, and I'm only second rank programmer here, as I'm new, so I don't get to dictate what we use (yet). But from what I've read, you can set up a much simpler framework using mysqli and prepared statements, and that'd save you 'reinventing the wheel' so to speak.
I do understand the 'doing it yourself' mentality, however, and doing it for the sake of figuring out how it's done, but these days I tend to find other stuff to do for the sake of doing that arent in the core php functionality 😛