Why will this code not update the database..

[Omenizer]

I dont understand why this code is not updating the database. When I click submit all I get back is "Array()" at the top of the unchanged form.

<?php require_once("includes/connect.php"); ?> 
<?php require_once("includes/functions.php"); ?> 
<?php 
      if (intval($_GET['article']) == 0) { 
         redirect_to("news.php"); 
      } 
      if (isset($_POST['submit'])) { 
         $errors = array(); 

     $required_fields = array('title', 'content'); 
     foreach($required_fields as $fieldname) { 
        if (!isset($_POST[$fieldname]) || empty($_POST[$fieldname])) {  
           $errors[] = $fieldname;  
        } 
     } 

     print_r($errors); 

     if (empty($errors)) { 
        // Perform Update 
        $id = $_GET['article']; 
        $title = $_POST['title']; 
        $content = $_POST['content']; 

        $query = "UPDATE subjects SET  
                 title = '{$title}', 
                 content = '{$content}' 
              WHERE id = {$id}"; 
        $result = mysql_query($query, $connect); 
        if (mysql_affected_rows() == 1) { 
           // Success 
        } else { 
           // Failed 
        } 

     } else { 
        // Errors occurred 
     } 




  }  
?> 
<?php 
if(isset($_GET['article'])) { 
      $query = "SELECT * FROM news WHERE id={$_GET['article']} "; 
      $get_article = mysql_query($query, $connect); 
      if(!$get_article) { 
         die("Database Query Failed: ".mysql_error()); 
      } 
         if ($articledata = mysql_fetch_array($get_article)) { 
      } else { 
         $articledata = NULL; 
      } 
} 
?> 
<?php include("includes/header.php"); ?> 

   <h2>Edit News Article: <?php echo $articledata['title']; ?></h2> 
            <form action="editnews.php?article=<?php echo $articledata['id']; ?>" method="post"> 
                <p>Title:<br /></p> 
                    <input type="text" name="title" value="<?php echo $articledata['title']; ?>" id="title" /> 

            <p>   Content:<br /></p> 
                <textarea name="content" cols="40" rows="5" id="content"><?php echo $articledata['content']; ?></textarea> 
            <br /><input type="submit" name="submit" value="Edit News"  /> 


        </form> 
     <br /> 
     <a href="news.php">Cancel</a> 

<?php require("includes/footer.php"); ?>

[ivan7]

you must change $GET
with $post because your form method use post

( sorry my english so bad 🙁 )

like this example :

$id= strtoupper ($_POST['id']);
$up_nama= strtoupper ($_POST['up_nama']);
$up_t_lahir= strtoupper ($_POST['up_t_lahir']);
$up_alamat=strtoupper ($_POST['up_alamat']);
$up_rt=strtoupper ($_POST['up_rt']);
$up_rw=strtoupper ($_POST['up_rw']);
$up_status=strtoupper ($_POST['up_status']);
$up_agama=strtoupper ($_POST['up_agama']);
$up_pekerjaan=strtoupper ($_POST['up_pekerjaan']);
$up_goldar=strtoupper ($_POST['up_goldar']);
$up_ayah=strtoupper ($_POST['up_ayah']);
$up_ibu=strtoupper ($_POST['up_ibu']);


$host = "localhost";
$user = "root";
$pass = "";
$db = "log";
$connect = mysql_connect($host,$user,$pass) or die("Gagal konek");
$pilih_db = mysql_select_db($db) or die("Database tidak ada");

$query="UPDATE penduduk SET alamat='$up_alamat',rt='$up_rt',rw='$up_rw',status='$up_status',agama='$up_agama',pekerjaan='$up_pekerjaan',goldar='$up_goldar',ayah='$up_ayah',ibu='$up_ibu' WHERE id='$id'";
mysql_query($query);
mysql_close();

[johanafm]

That would be the print_r($errors)... Move that down to the else // Errors occured.

And in the else // Failed, add code to output sql errors.

At a quick glance, I suspect the reason is your where clause:

"WHERE id = ". $id; // remove the { } 

And where do you assign the value to $id?

[ivan7]

$id=$_POST['article'];

if(isset($id)) {
      $query = "SELECT * FROM news WHERE id=$id ";
      $get_article = mysql_query($query, $connect);
      if(!$get_article) {
         die("Database Query Failed: ".mysql_error());
      }
         if ($articledata = mysql_fetch_array($get_article)) {
      } else {
         $articledata = NULL;
      }

[johanafm]

Ah, a second look at it and I finally saw the line. My bad on the id.