[RESOLVED] File Upload Script not working correctly

IceRegent

I am trying to get a file upload script to work. I have a form that has dynamically populated fields in it. I also have a file select field in it.

<html>
<form enctype="multipart/form-data" method="post" action="contentupdate.php">
	<table width="800px" cellspacing="2" cellpadding="2" bordercolor="#804000" border="2px">
		<tr>
     		<td>Links Info<td>
     		<td><textarea name="linkinfo" rows="10" cols="30"><?php echo $row['links']; ?></textarea><td>
     		<td></td>
     </tr>
     <tr>
     		<td>Main Contents<td>
     		<td><textarea name="maincontent" rows="10" cols="40"><?php echo $row['center']; ?></textarea><td>
     		<td></td>
     </tr>
		<tr>
			<td>Logo Picture <input type="file" name="logo"></td>
     </tr>
     <tr><td></td><td style="text-align:center"><input type="submit" value="Update!"></td></tr>
	</table>
</form>
</html>

I then submit the form to my php script.

<?php
session_start();
include $_SERVER['DOCUMENT_ROOT'] . '/include/config.php';

$picture = basename( $_FILES['logo']['name']);
// Now to upload the logo picture if one is selected
if ($picture == NULL) { echo 'No valid picture info!'; }	
if ($picture <> NULL) {
$target_path = "template/images/";
$target_path = $target_path . basename( $_FILES['logo']['name']);

if(move_uploaded_file($_FILES['logo']['tmp_name'], $target_path)) {
    echo "The file ".  basename( $_FILES['logo']['name']). 
    " has been uploaded";
	} else{
    echo "There was an error uploading the file, please try again!";
    echo 'Here is some more debugging info:';
				print_r($_FILES);
				print "</pre>";
	}
}
?>

I lifted this segment of the file upload script from another website I have, where the script works just like it should. But now, all of a sudden, I get the result that "picture = NULL", for some reason, thusly, the file upload never occurs. I added in the sections to echo out about no valid picture info to give myself an idea of whether it was processing or not. It is always NULL. Why?

Ice

ixalmida

Sounds like the temp file isn't getting created - probably a permissions issue. I'd start by testing whether the temp file exists:

if(isset($_FILES["logo"]) && file_exists($_FILES["logo"]["tmp_name"]))
    echo "Temp file exists!";

IceRegent

I tried changing the file uploading to a standalone set of files. Here is what it now looks like:

File select form:

<?php
session_start();
echo '<p style="text-align:center">This script will update the <b>LOGO</b> for the website <b>' . $_SESSION['band'] . '</b></p>';

echo '<form enctype="multipart/form-data" action="logoup.php" method="POST">
<input type="hidden" name="MAX_FILE_SIZE" value="100000">
Choose a file to upload: <input name="uploadedfile" type="file"><br />
<input type="submit" value="Upload File">
</form>';
?>

Here is the file uploader script:

<?php
// Where the file is going to be placed 
$target_path = "images/";
echo $_files['uploadedfile'];

/* Add the original filename to our target path.  

Result is "uploads/filename.extension" */
$target_path = $target_path . basename( $_FILES['uploadedfile']['name']);

if(move_uploaded_file($_FILES['uploadedfile']['tmp_name'], $target_path)) {
    echo "The file ".  basename( $_FILES['uploadedfile']['name']). 
    " has been uploaded";
} else {
    echo "There was an error uploading the file, please try again!";
}
if(isset($_FILES["logo"]) && file_exists($_FILES["uploadedfile"]["tmp_name"]))
    echo "Temp file exists!"; 

?>

Not sure if I put the temp upload checker in the right location..

Here is the results of anything I try to upload:

There was an error uploading the file, please try again!

No matter what I do. The subdirectory 'images' is in the current folder, and it has write to permissions for the user, the permissions are: 0755

I have tried ever kind of permission I can think of. So what could be the problem?

Ice

dagon

add a print_r($_FILES); see what you get

IceRegent

At what point should I insert it?

IceRegent

I placed the statement near the top after the :
$target_path = "images/";
echo $files['uploadedfile'];
print_r($FILES);

This is the result I got..

Array ( [uploadedfile] => Array ( [name] => Dock.jpg [type] => [tmp_name] => [error] => 2 [size] => 0 ) ) There was an error uploading the file, please try again!

IceRegent

Ok, I seem to have gotten it working now, but, I need to rename the file to a specified file name. WHat is the correct way to rename the uploaded file?

Ice

johanafm

File size issue. Always check the php doc

johanafm

move_uploaded_file should work.

IceRegent

Ok, confusion on my part.."move_uploaded_file" should work? Yes, I realized the file size issue and fixed that, but, I dont understand how to change the uploaded file name..

johanafm

move_uploaded_file("originalname", "whereeveryouwanttoputthenewfile/name.ext");

IceRegent

Ok, I figured out where the actual filename would come from. The code segment :

$target_path = ($target_path . $_SESSION['band'] . 'logo' );

This is where I change the file name. I understand the statement now..:

if(move_uploaded_file($_FILES['uploadedfile']['tmp_name'], $target_path))

Equals: Move the filename from local directory, give it the file name specified in target path.

Ice

IceRegent

However, one last item... What would I do if I wanted to overwrite and existing file with a newly uploaded file? How would that be accomplished? I just get an error and no upload when I try to overwrite a file.

johanafm

php.net
Search for file. Check the left column yourself. Plenty of options. unlink() seems confusing as a name to me, but perhaps there was a good reason for it.

ixalmida

It's a carry-over from Unix: unlink

IceRegent

Ok, I got it all figured out now. Thanks guys!

Ice