Code Formatting Question

[amy_damnit]

How do you indent your code?

Style #1: Align PHP Starting/Ending Tags with Code

<?php
// Class providing generic data access functionality
class database_handler {
    // Hold an instance of the PDO class
    private static $_mHandler;

// Private constructor to prevent direct creation of object
private function __construct()
{
}
}
?>

Style #2: Indent Code from PHP Tags

<?php
    // Class providing generic data access functionality
    class database_handler {
        // Hold an instance of the PDO class
        private static $_mHandler;

    // Private constructor to prevent direct creation of object
    private function __construct()
    {
    }
}
?>

Using Style #1 saves you an extra indent.

Using Style #2 looks better to me.

Which Style do you prefer??

(Or do you have another Style you prefer??)

Amy

[laserlight]

A more general version of this topic was once discussed in Coding Style, and possibly other threads.

As for your specific question: I see no purpose in adding an extra level of indentation to account for PHP tags.

[NogDog]

Yeah, I'd have to say that seems like a waste of horizontal space for a very minimal benefit. But ultimately, unless you are required to follow some group's standard, the "correct" answer is whatever works best for you.

[amy_damnit]

NogDog;10925220 wrote:

Yeah, I'd have to say that seems like a waste of horizontal space for a very minimal benefit. But ultimately, unless you are required to follow some group's standard, the "correct" answer is whatever works best for you.

While I used to alwys use Style #2, it dawned on me this weekend that Style #1 is more practical. Both you and LaserLight seem to agree.

Amy