[RESOLVED] Queries failing to work.

[jamesjohnson88]

The queries in question are the ones for decrementing the 'GamesPlayed' value. They pass the if statement correctly and show no errors, so have no idea what is wrong with them.

Here is the code (sans connection code) -

// Set variables.
$logID = mysql_real_escape_string($_POST['resultID']);

// Pull Scoring_Log data and assign variables.
$array = mysql_query("SELECT * FROM Scoring_Log WHERE resultID='$logID'") or die(mysql_error());
//echo mysql_num_rows($array); // Shows how many rows are returned.

$row=mysql_fetch_array($array, MYSQL_BOTH); // CHECKPOINT 1 - CLEAR
//print_r($row); // Shows array.

// Players Involved.
$player1 = $row['1stPlayer'];
$player2 = $row['2ndPlayer'];
$player3 = $row['3rdPlayer'];
$player4 = $row['4thPlayer'];
$player5 = $row['5thPlayer'];
$player6 = $row['6thPlayer'];
$player7 = $row['7thPlayer'];
$player8 = $row['8thPlayer'];
// Points Awarded.
$p1Points = $row['1stPoints'];
$p2Points = $row['2ndPoints'];
$p3Points = $row['3rdPoints'];
$p4Points = $row['4thPoints'];
// League Involved.
$leagueName = $row['LeagueName']; 

echo ("$player1");
echo ("$player2");
echo ("$player3");
echo ("$player4");
echo ("$player5");
echo ("$player6");
echo ("$player7");
echo ("$player8");

echo ("$p1Points");
echo ("$p2Points");
echo ("$p3Points");
echo ("$p4Points");

echo ("$leagueName");

// Minus One Game Played. DOESN'T WORK?!
if ($player1 =! NULL)
{
	mysql_query("UPDATE $leagueName SET GamesPlayed=GamesPlayed-1 WHERE PlayerName='$player1' LIMIT 1") or die(mysql_error());
}
if ($player2 =! NULL)
{
	mysql_query("UPDATE $leagueName SET GamesPlayed=GamesPlayed-1 WHERE PlayerName='$player2' LIMIT 1") or die(mysql_error());
}
if ($player3 =! NULL)
{
	mysql_query("UPDATE $leagueName SET GamesPlayed=GamesPlayed-1 WHERE PlayerName='$player3' LIMIT 1") or die(mysql_error());
}
if ($player4 =! NULL)
{
	mysql_query("UPDATE $leagueName SET GamesPlayed=GamesPlayed-1 WHERE PlayerName='$player4' LIMIT 1") or die(mysql_error());
}
if ($player5 =! NULL)
{
	mysql_query("UPDATE $leagueName SET GamesPlayed=GamesPlayed-1 WHERE PlayerName='$player5' LIMIT 1") or die(mysql_error());
}
if ($player6 =! NULL)
{
	mysql_query("UPDATE $leagueName SET GamesPlayed=GamesPlayed-1 WHERE PlayerName='$player6' LIMIT 1") or die(mysql_error());
}
if ($player7 =! NULL)
{
	mysql_query("UPDATE $leagueName SET GamesPlayed=GamesPlayed-1 WHERE PlayerName='$player7' LIMIT 1") or die(mysql_error());
}
if ($player8 =! NULL)
{
	mysql_query("UPDATE $leagueName SET GamesPlayed=GamesPlayed-1 WHERE PlayerName='$player8' LIMIT 1") or die(mysql_error());
}

// Remove W/L/D's.
$index_array = mysql_query("SELECT * FROM League_Index WHERE LeagueName='$leagueName'") or die(mysql_error());
$index_row = mysql_fetch_array($index_array);
$leagueType = $index_row["LeagueType"]; // Checkpoint 2 - Clear

// For multiplayer leagues.
if ($leagueType = "multiplayer")
{
	if ($player8 =! NULL)
	{
		mysql_query("UPDATE $leagueName SET Times_1st=Times_1st-1 Points=Points-11 WHERE PlayerName='$player1' LIMIT 1") or die(mysql_error());
		mysql_query("UPDATE $leagueName SET Times_2nd=Times_2nd-1 Points=Points-8 WHERE PlayerName='$player2' LIMIT 1") or die(mysql_error());
		mysql_query("UPDATE $leagueName SET Times_3rd=Times_3rd-1 Points=Points-5 WHERE PlayerName='$player3' LIMIT 1") or die(mysql_error());
		mysql_query("UPDATE $leagueName SET Points=Points-2 WHERE PlayerName='$player4'") or die(mysql_error());
	}
	else if ($player7 =! NULL || $player6 =! NULL)
	{
		mysql_query("UPDATE $leagueName SET Times_1st=Times_1st-1 Points=Points-8 WHERE PlayerName='$player1' LIMIT 1") or die(mysql_error());
		mysql_query("UPDATE $leagueName SET Times_2nd=Times_2nd-1 Points=Points-5 WHERE PlayerName='$player2' LIMIT 1") or die(mysql_error());
		mysql_query("UPDATE $leagueName SET Times_3rd=Times_3rd-1 Points=Points-2 WHERE PlayerName='$player3' LIMIT 1") or die(mysql_error());
	}
	else if ($player5 =! NULL || $player4 =! NULL)
	{
		mysql_query("UPDATE $leagueName SET Times_1st=Times_1st-1 Points=Points-5 WHERE PlayerName='$player1' LIMIT 1") or die(mysql_error());
		mysql_query("UPDATE $leagueName SET Times_2nd=Times_2nd-1 Points=Points-2 WHERE PlayerName='$player2' LIMIT 1") or die(mysql_error());
		mysql_query("UPDATE $leagueName SET Times_3rd=Times_3rd-1 Points=Points-1 WHERE PlayerName='$player3' LIMIT 1") or die(mysql_error());
	}
	else ($player3 =! NULL || $player2 =! NULL)
	{
		mysql_query("UPDATE $leagueName SET Times_1st=Times_1st-1 Points=Points-3 WHERE PlayerName='$player1' LIMIT 1") or die(mysql_error());
		mysql_query("UPDATE $leagueName SET Times_2nd=Times_2nd-1 WHERE PlayerName='$player2' LIMIT 1") or die(mysql_error());
		mysql_query("UPDATE $leagueName SET Times_3rd=Times_3rd-1 WHERE PlayerName='$player3' LIMIT 1") or die(mysql_error());
	}
}

// For classic leagues.
if ($player1 =! NULL)
{
	mysql_query("UPDATE $leagueName SET Draws=Draws-1 Points=Points-1 WHERE PlayerName='$player7' LIMIT 1") or die(mysql_error());
	mysql_query("UPDATE $leagueName SET Draws=Draws-1 Points=Points-1 WHERE PlayerName='$player8' LIMIT 1") or die(mysql_error());
}
else
{
	mysql_query("UPDATE $leagueName SET Wins=Wins-1 Points=Points-3 WHERE PlayerName='$player1' LIMIT 1") or die(mysql_error());
	mysql_query("UPDATE $leagueName SET Losses=Losses-1 WHERE PlayerName='$player2' LIMIT 1") or die(mysql_error());
}

//For trueskill leagues.
if ($player1 =! NULL)
{
	mysql_query("UPDATE $leagueName SET Draws=Draws-1 Points=Points-7 WHERE PlayerName='$player7' LIMIT 1") or die(mysql_error());
	mysql_query("UPDATE $leagueName SET Draws=Draws-1 Points=Points-7 WHERE PlayerName='$player8' LIMIT 1") or die(mysql_error());
}
else
{
	mysql_query("UPDATE $leagueName SET Draws=Draws-1 Points=Points-'$p1Points' WHERE PlayerName='$player1' LIMIT 1") or die(mysql_error());
	mysql_query("UPDATE $leagueName SET Draws=Draws-1 Points=Points-'$p2Points' WHERE PlayerName='$player2' LIMIT 1") or die(mysql_error());
}


// Remove From Result_Log.
mysql_query("DELETE FROM Result_Log WHERE LogID = '$logID'") or die(mysql_error());

If you spot any other errors please feel free to point them out as I know this query isn't the only bug in this piece of code.

Any help you can offer is appreciated.

• James

[dagon]

instead of

if ($player1 =! NULL)

use

if (empty($player1)) ...

[jamesjohnson88]

Nope, no difference. Code executes and runs through but the query has no effect.

[dagon]

you don't go out of your way to make it easy to be helped, good luck :-)

[jamesjohnson88]

Sorry if I have offended you. I was simply reporting back on what happened after I did as you instructed.

[faifas]

Try echoing the queries to see if they are really ok

[jamesjohnson88]

Ok, I have tried that and it appears that the $player1,2,3,etc. variables all have the the value of '1'. So i'm guessing the '=! NULL' code is a bool. Yet when I use '(empty($player1))' it has no effect, the 'if' statement doesn't catch it and the rest of the code continues to execute.

if ($player1 =! NULL)
{
	mysql_query("UPDATE $leagueName SET GamesPlayed=GamesPlayed-1 WHERE PlayerName='$player1' LIMIT 1") or die(mysql_error());
	echo ("$leagueName, $player1");
}
if ($player2 =! NULL)
{
	mysql_query("UPDATE $leagueName SET GamesPlayed=GamesPlayed-1 WHERE PlayerName='$player2' LIMIT 1") or die(mysql_error());
	echo ("$leagueName, $player2");
}

[jamesjohnson88]

Fixed it -

I set a duplicate variable for each player then used as the bool, so the player variables were left untouched.

if ($var1 =! NULL)
{
	mysql_query("UPDATE $leagueName SET GamesPlayed=GamesPlayed-1 WHERE PlayerName='$player1' LIMIT 1") or die(mysql_error());
	echo ("$leagueName, $player1");
}

Thanks faifas!

[faifas]

I am not sure of where did you get the idea of using $var =! NULL, which means that you are declaring a $var whose value is !NULL and that is why your variables were re-declared.

For comparison you should do if($var != NULL) which is ok, because you're not re-declaring the variable.

Hope this helps!

[jamesjohnson88]

I'm using the way you've just mentioned. My $var are set by doing $var = $player.