calculating business days in php

[scialom]

Hi all

I am using this function (taken from php.net site) to calculate business days between two dates

function getWorkingDays($startDate,$endDate,$holidays){
    //The total number of days between the two dates. We compute the no. of seconds and divide it to 60*60*24
    //We add one to inlude both dates in the interval.
    $days = (strtotime($endDate) - strtotime($startDate)) / 86400 + 1;

$no_full_weeks = floor($days / 7);

$no_remaining_days = fmod($days, 7);

//It will return 1 if it's Monday,.. ,7 for Sunday
$the_first_day_of_week = date("N",strtotime($startDate));

$the_last_day_of_week = date("N",strtotime($endDate));
// echo              $the_last_day_of_week;
//---->The two can be equal in leap years when february has 29 days, the equal sign is added here
//In the first case the whole interval is within a week, in the second case the interval falls in two weeks.
if ($the_first_day_of_week <= $the_last_day_of_week){
    if ($the_first_day_of_week <= 6 && 6 <= $the_last_day_of_week) $no_remaining_days--;
    if ($the_first_day_of_week <= 7 && 7 <= $the_last_day_of_week) $no_remaining_days--;
}

else{
    if ($the_first_day_of_week <= 6) {
    //In the case when the interval falls in two weeks, there will be a Sunday for sure
        $no_remaining_days--;
    }
}

//The no. of business days is: (number of weeks between the two dates) * (5 working days) + the remainder
//---->february in none leap years gave a remainder of 0 but still calculated weekends between first and last day, this is one way to fix it
   $workingDays = $no_full_weeks * 5;
    if ($no_remaining_days > 0 )
    {
      $workingDays += $no_remaining_days;
    }

//We subtract the holidays
foreach($holidays as $holiday){
    $time_stamp=strtotime($holiday);
    //If the holiday doesn't fall in weekend
    if (strtotime($startDate) <= $time_stamp && $time_stamp <= strtotime($endDate) && date("N",$time_stamp) != 6 && date("N",$time_stamp) != 7)
        $workingDays--;
}

return $workingDays;
}

when I test it with 20/08/2009 and 24/08/2009 the return is 4 but it should be 3! any ideas ?

[Installer]

Edit: Sorry for the seeming nonsense in my original first sentence. I saw 3! as 31.

"20/08/2009" and "24/08/2009" aren't in a format that strtotime() recognizes. It converts them to the same day (the start of the epoch), thus it sees them as the same day. (You should turn on display_errors while you develop. You'd then see a "non-well-formed" notice to alert you to the problem.)

Assuming you pass it date strings that strtotime() recognizes (e.g. "20-08-2009"), this should work:

function get_working_days($start_date, $end_date, $holidays = array())
{
    $start_ts = strtotime($start_date);
    $end_ts = strtotime($end_date);
    foreach ($holidays as & $holiday) {
        $holiday = strtotime($holiday);
    }
    $working_days = 0;
    $tmp_ts = $start_ts;
    while ($tmp_ts <= $end_ts) {
        $tmp_day = date('D', $tmp_ts);
        if (!($tmp_day == 'Sun') && !($tmp_day == 'Sat') && !in_array($tmp_ts, $holidays)) {
            $working_days++;
        }
        $tmp_ts = strtotime('+1 day', $tmp_ts);
    }
    return $working_days;
}

[loshiewoshie]

Thanks for that.