[RESOLVED] preg_replace_callback function

[JD_]

hi , im using this code:

$regex = '#(href=")(http://[a-zA-Z0-9?&%.;:/=+_-]*)#';
$str2 = preg_replace_callback($regex,'shoveItInTheDatabase', $html_file);

function shoveItInTheDatabase($match) {

echo"<pre>";
print_r($match);
echo"</pre>";

}

which works , i want to additionally pass $user_client and $newsletter_id to this function.

e.g

function shoveItInTheDatabase($match,$user_client,$newsletter_id) {

echo"<pre>";
print_r($match);
echo"</pre>";

}

how do i pass the $user_client and $newsletter_id to this function with the preg_replace_callback, can't seem to figure out how to do it.

[JD_]

the solution is to set global on those vars, inside and outside the function e.g

 global $user_client

[nrg_alpha]

Passing globally is generally considered bad practice for reasons such as potential confliciting namespaces, lack of encapsulation, tighter coupling / dependancy issues, etc..

I would recommend assigning the $user_client and $newsletter_id variables to an object and pass the object into the function instead. Objects are already global, yet retain their own namespacing, encapsulation and what have you.

EDIT - You can google the issue of global variables and why it's bad practice.