strange problem, variable fine within loop, doesn't work outside

[Desbrina]

I have this code

function cranks($users = '', $all = '', $silent = false)
{
	global $db, $user;
	$sql_array = array(
		'SELECT' => 'sum(u1.agi + u1.`int` + u1.str + u1.dex) as points1, 
				sum(u2.agi + u2.`int` + u2.str + u2.dex) as points2, 
				sum(u3.agi + u3.`int` + u3.str + u3.dex) as points3, 
				sum(u4.agi + u4.`int` + u4.str + u4.dex) as points4, 
				sum(s1.level) as skills1, 
				sum(s2.level) as skills2, 
				sum(s3.level) as skills3, 
				sum(s4.level) as skills4
			',
		'FROM' => array(USER_SQUAD_TABLE => 's'),
		'LEFT_JOIN' => array(
			array(
				'FROM' => array(USER_CREATURES_TABLE => 'u1'),
				'ON' => 'u1.id = s.cid1'
			),
			array(
				'FROM' => array(USER_CREATURES_TABLE => 'u2'),
				'ON' => 'u2.id = s.cid2'
			),
			array(
				'FROM' => array(USER_CREATURES_TABLE => 'u3'),
				'ON' => 'u3.id = s.cid3'
			),
			array(
				'FROM' => array(USER_CREATURES_TABLE => 'u4'),
				'ON' => 'u4.id = s.cid4'
			),
			array(
				'FROM' => array(USER_SKILLS_TABLE => 's1'),
				'ON' => 's1.cid = s.cid1'
			),
			array(
				'FROM' => array(USER_SKILLS_TABLE => 's2'),
				'ON' => 's2.cid = s.cid2'
			),
			array(
				'FROM' => array(USER_SKILLS_TABLE => 's3'),
				'ON' => 's3.cid = s.cid3'
			),
			array(
				'FROM' => array(USER_SKILLS_TABLE => 's4'),
				'ON' => 's4.cid = s.cid4'
			),
			array(
				'FROM' => array(USERS_TABLE => 'm'),
				'ON' => 's.uid = m.user_id'
			)
		),
		'WHERE' => 'm.group_id != 6
			AND m.user_type NOT IN (1,2)',
		'ORDER_BY' => 'points1 DESC'
	);

if($users != '')
{
	$sql_array['WHERE'] .= ' AND s.uid = ' . $users;
}
elseif($all != '')
{
	$sql_array['SELECT'] .= ', m.username, m.user_id';
	$sql_array['GROUP_BY'] = ' m.user_id';
}

$sql = $db->sql_build_query('SELECT', $sql_array);
$result = $db->sql_query($sql);
//$userss = '';
while($row = $db->sql_fetchrow($result))
{
	$total = $row['points1'] + $row['points2'] + $row['points3'] + $row['points4'] + $row['skills1'] + $row['skills2'] + $row['skills3'] + $row['skills4'] ;
	if($all != '' && $total != 0)
	{
		$u[] = '<option value="'.$row['user_id'].'">'.$row['username'].' - Rating: '.$total.'</option>';
	}
	else
	{
		if($silent)
		{
			return $total;
		}
		else
		{
			return $total;
		}
	}
}
/*if($u != '')
{*/
	$details = implode('<br/>', $u)
	return  $details;
//}
$db->sql_freeresult($result);
}

if i print u after its being added to all the details appear fine, but the return at the bottom shows nothing

any ideas why?

[dagon]

how are you calling the cranks() function

[dagon]

also $db->sql_freeresult($result); will never run since its after return

[Desbrina]

its being called twice, once as such

cranks($u='', $all='t')

which is the one that doesn't work
the second is

cranks($user->data['user_id'])

which works fine

as for $db->sql_freeresult($result);, its left over code that needs to be removed

[dagon]

neither of those should display anything on-screen sine there is no output call.

[Desbrina]

the whole code

$template->assign_vars(
	array(
		'MSG' => $msg,
		'RANKS' => cranks($u='', $all='t'),
		'CREATURE1' => $c1,
		'CREATURE2' => $c2,
		'CREATURE3' => $c3,
		'CREATURE4' => $c4,
		'P1' => $row['points1'],
		'S1' => $row['skills1'],
		'T1' => ($row['points1'] + $row['skills1']),
		'P2' => $row['points2'],
		'S2' => $row['skills2'],
		'T2' =>( $row['points2'] + $row['skills2']),
		'P3' => $row['points3'],
		'S3' => $row['skills3'],
		'T3' => ($row['points3'] + $row['skills3']),
		'P4' => $row['points4'],
		'S4' => $row['skills4'],
		'T4' => ($row['points4'] + $row['skills4']),
		'SQUAD' => cranks($user->data['user_id']),
		'STAMINA' => $row['stamina']
	)
);

[anoopmail]

try changing

 'RANKS' => cranks($u='', $all='t'),

to

 'RANKS' => cranks('', 't'),

[Desbrina]

i'm now getting the ouput of 0

<select name="users" id="users">
			0          </select>

EDIT: I seem to have fixed it by changing the if within the while to this

if($all != '' && $total != 0)
		{
			$u[] = '<option value="'.$row['user_id'].'">'.$row['username'].' - Rating: '.$total.'</option>';
		}
		elseif($us != '' && !$all)
		{
			return $total;
		}