Really basic program/question

[FuriousIrishman]

So this is probably something really dumb, but I am just starting out with PHP... it's a really simple program that pushes a string with $_GET and passes it into a switch statement within a function. Except it doesn't work and I can't figure out why. Anyone more experienced see anything retarded jump out at you? Let me know, I'd be extremely grateful. 😃

<?php
/* Variables and Functions */
#
function CheckGrade($grade]){	
	$Grade = strtoupper($grade);
	switch ($Grade) {
    	case "A":
        	$retValue = <<< Text
			Grade is excellent.<br/>
			<p class="content"><a href="LetterGrades.html">Enter another grade?</a>
			Text;
			echo $retValue;
        	break;
    	case "B":
			$retValue = <<< Text
			Grade is good.<br/>
			<p class="content"><a href="LetterGrades.html">Enter another grade?</a>
			Text;
			echo $retValue;
        	break;
   		case "C":
        	$retValue = <<< Text
			Grade is fair.<br/>
			<p class="content"><a href="LetterGrades.html">Enter another grade?</a>
			Text;
			echo $retValue;
        	break;
		case "D":
        	$retValue = <<< Text
			Barely Passing.<br/>
			<p class="content"><a href="LetterGrades.html">Enter another grade?</a>
			Text;
			echo $retValue;
        	break;
		case "F":
        	$retValue = <<< Text
			Failed.<br/>
			<p class="content"><a href="LetterGrades.html">Enter another grade?</a>
			Text;
			echo $retValue;
        	break;
		default:
			$retValue = <<< Text
			invalid response, please re-enter information <a href="LetterGrades.html">Here</a>.
			Text;
			echo $retValue;
			break;
	 }	
}

Should execute from

CheckGrade($_GET["grade"]);

Aaaagh.

[dagon]

your using heredoc, there's no reason to do that, and an important thing to note that if you do, you can't then indent the closing identifier.

better to drop the heredoc syntax altogether

//SNIP
case "A":
            $retValue = 'Grade is excellent.<br/><p class="content"><a href="LetterGrades.html">Enter another grade?</a>';
            echo $retValue;
            break;
//SNIP

generally not a good idea to put echo in a function ..

//SNIP
case "A":
            $retValue = 'Grade is excellent.<br/><p class="content"><a href="LetterGrades.html">Enter another grade?</a>';
            break; 
//SNIP

echo CheckGrade($_GET["grade"]); 

[pete_bisby]

You've left behind a square bracket in the function call, to the right of $grade.

And functions always "return" a value - remove the echo statements and return $retval outside of the switch statement.