mystery NULL mucking me up -

[elliotpo]

Hello, I'm fairly new to this, having trouble with a basic query. I can run the query in Terminal, but when I write it into PHP I get the following error message:

Warning: mysql_query() expects parameter 2 to be resource, null given in (etc.)

and here is the problematic line:
mysql_query ( 'INSERT INTO users (id, username, password, first_name, last_name) VALUES (1, \'john\', \'password\', \'john\', \'thompson\')', NULL )

it's not clear to me where that NULL is coming from.

here's what i'm writing in the page i'm trying to load:

$sql = sprintf("INSERT INTO users (id, username, password, first_name, last_name) VALUES (1, 'john', 'password', 'john', 'thompson')");
$result = $db->query($sql);

and here's how the method is written on the page that's being included:

	public function query($sql) {
	$result = mysql_query($sql, $this->connection);
	$this->confirm_query($result);
	return $result;
}

Again, I can just enter the row into MySql directly and no trouble, but I can't get it to work through PHP. Any advice? I feel like something simple and glaring is at fault here, but I can't see it.

Thanks so much -

Elliot

[elliotpo]

and here is the problematic line:
mysql_query ( 'INSERT INTO users (id, username, password, first_name, last_name) VALUES (1, \'john\', \'password\', \'john\', \'thompson\')', NULL )

this is what the error reporting is showing as the line. what i quoted below that is what i'm entering. so i'm confused as to why the NULL is appearing in the error report, and what to do about it.

maybe that was clear all along.

thanks.

[johanafm]

It looks like you don't have a connection

public function query($sql) {
	// When is $this->connection set?
	$result = mysql_query($sql, $this->connection);
}

Why not make sure it's always set?

public function query($sql) {
	if (!$this->connection)
		$this->connection = DbConn::getConnection();
	$result = mysql_query($sql, $this->connection);
}

[elliotpo]

class MySQLDatabase
{

private $connection;

function __construct () {
	$this->connection;
}

public function open_connection() {
	$this->connection = mysql_connect(DB_SERVER, DB_USER, DB_PASS);
	if (!$this->connection) {
		die("databse connection failed, anaranjado: " . mysql_error());
	} else {
		$db_select = mysql_select_db(DB_NAME, $this->connection);
		if (!db_select) {
			die("database selection failed, padre: " . mysql_error());
		}
	}

I take your advice. But I think I'm having touble with my PHP/MySQL connection, as has been the case since installing Snow Leopard. Do you have any advice on THAT?

I've been changing MySql sock values or removing them and changing localhost to 127 but it's still sketchy.

Thanks for the response -

[elliotpo]

Ah, it's embarrassing. I was trying to connect with a function __construct, and had simply mistyped that method. Apologies. Thanks for the responses, they were still instructive.

[johanafm]

Good that you got it working. But I'd recommend changing to

class MySQLDatabase
{
// static makes this shared amongst all instantiations of MySQLDatabase
private static $connection;

// You don't actually need to create instances of this class, so make the constructor private
private function __construct () {}

// So this goes static as well
public static function &open_connection() {
	// Only connect to the server once
	if (!self::$connection)
		self::$connection = mysql_connect(DB_SERVER, DB_USER, DB_PASS);
	if (!self::$connection) {
		die("databse connection failed, anaranjado: " . mysql_error());
	}

return self::$connection;
}

Then you can make the class containing your query function(s) get the connection from this class and always be certain that only one connection is made per page request.

[elliotpo]

indeed. much obliged. -elliot.