Problem with page count

phpnow

Hello everyone, I am having a problem with creating a small script that limits results to a page and create 1,2,3,4 ...ETC so you can go to the next page. Now This same script worked three years ago with like PHP 3 or so. All I did was change to PHP5 So anyway here is the script: Any suggestions??

Could it be a register globals problem???

phpnow

Could it be a register globals problem???

Calculate Page-Numbers

#################################################################################################
if (empty($perpage)) $perpage = 10;
if (empty($pperpage)) $pperpage = 9; //!!! ONLY 5,7,9,11,13 !!!!
//if (empty($sort)) $sort = "$miles ";
if (empty($offset)) $offset = 0;
if (empty($poffset)) $poffset = 0;

$amount = mysql_db_query($database, "SELECT count(*) FROM publicPhotos1 "); //
$amount_array = mysql_fetch_array($amount);
$pages = ceil($amount_array["0"] / $perpage);
$actpage = ($offset+$perpage)/$perpage;
$maxpoffset = $pages-$pperpage;
$middlepage=($pperpage-1)/2;
if ($maxpoffset<0) {$maxpoffset=0;}

echo "<b><div align=\"default\"><font face=\"Arial, Helvetica, sans-serif\" size=\"2\"><font color=\"#000033\">\n";

echo "<table width=\"100%\" border=\"0\" cellpadding=\"0\" cellspacing=\"0\" bgcolor=\"#000066\">
<tr>
<td width=\"6%\"><div align=\"center\"></div></td>
<td width=\"88%\"><div align=\"center\"></div></td>
<td width=\"6%\"><div align=\"center\"></div></td>
</tr>
</table>";
if ($pages) { // print only when pages > 0
echo "$ad_pages\n";

if ($offset) {
    $noffset=$offset-$perpage;
    $npoffset = $noffset/$perpage-$middlepage;
    if ($npoffset<0) {$npoffset=0;}
    if ($npoffset>$maxpoffset) {$npoffset = $maxpoffset;}
echo "<a href=\"$PHP_SELF?offset=$noffset&poffset=$npoffset\"
        onmouseover=\"window.status='$nav_prev'; return true;\"
	    onmouseout=\"window.status=''; return true;\"><<</a>";
}

for($i = $poffset; $i< $poffset+$pperpage && $i < $pages; $i++) {
	$noffset = $i * $perpage;
    $npoffset = $noffset/$perpage-$middlepage;
    if ($npoffset<0) {$npoffset = 0;}
    if ($npoffset>$maxpoffset) {$npoffset = $maxpoffset;}
$actual = $i + 1;
    if ($actual==$actpage) {
    echo "(<a href=\"$PHP_SELF?offset=$noffset&poffset=$npoffset\"
        onmouseover=\"window.status='$nav_actpage'; return true;\"
	    onmouseout=\"window.status=''; return true;\">$actual</a>) ";
        } else {
    echo "[<a href=\"$PHP_SELF?offset=$noffset&poffset=$npoffset\"
        onmouseover=\"window.status='$nav_gopage'; return true;\"
	    onmouseout=\"window.status=''; return true;\">$actual</a>] ";
    }
}

if ($offset+$perpage<$amount_array["0"]) {
    $noffset=$offset+$perpage;
    $npoffset = $noffset/$perpage-$middlepage;
    if ($npoffset<0) {$npoffset=0;}
    if ($npoffset>$maxpoffset) {$npoffset = $maxpoffset;}
echo "<a href=\"$PHP_SELF?offset=$noffset&poffset=$npoffset\"
        onmouseover=\"window.status='$nav_next'; return true;\"
	    onmouseout=\"window.status=''; return true;\">>></a> <br>";
    }
}

johanafm

Most likely. Request data comes in the $POST and $GET arrays.

phpnow

I think I know what you mean, but I am not sure. It seems like the VARS are getting lost somehow or something like that. Anyway suggestions on how to pull them out and make this work.

johanafm

If you see perpage=...&offset=... etc in the address bar after clicking a pagination link, the information is sent as get data. Else it's sent as post data. (And of course, some of that stuff may be hard coded into the script as well. $perpage is such a candidate if there is a part of the script coming before the code you posted.

But to see what's sent, you can just use

print_r($_POST);
print_r($_GET);

Then, change things like this

if (empty($_GET['perpage')) $perpage = 10;
else $perpage = $_GET['perpage'];

phpnow

Yea, but here is what I dont understand. This code worked perfectly three years or so ago. All I did was put the site back up and now it doesnt work at all. Has some changed that drastic in PHP that would cause this not to work. Thats gotta be it, because like I said...I changed nothing...everything is exactly the same even the database tables and all VARS are the same. Very weird...

johanafm

Of course there have been changes. If you were using PHP3, you're 2 major relreases down the road now. And even between 4 and 5 there were major changes.

In this particular case register_globals is off by default and I'd guess that it will disappear even as an option in PHP 6.

phpnow

Yea I saw that...I have been trying catch up on the changes and it is a bit much. I am trying to help my brother with a family website project, but it has been a long, long time and I have just got to catch up on my coding. Let me ask you this....did you see anything in that code that would keep it from working? It should work right?

johanafm

I didn't actually read the code. You asked if it could be an issue with register globals, and at a quick scan there was no use of either $GET or $POST, which is why I confirmed that this was a reasonable assumption (and easy to check the validity of).

That code is neither indented, nor wrapped in php tags, so there's no way I'd read it.

phpnow

is this what you mean

<?PHP

Calculate Page-Numbers

echo "<b><div align=\"default\"><font face=\"Arial, Helvetica, sans-serif\" size=\"2\"><font color=\"#000033\">\n";

if ($offset) {
$noffset=$offset-$perpage;
$npoffset = $noffset/$perpage-$middlepage;
if ($npoffset<0) {$npoffset=0;}
if ($npoffset>$maxpoffset) {$npoffset = $maxpoffset;}
echo "<a href=\"$PHP_SELF?offset=$noffset&poffset=$npoffset\"
onmouseover=\"window.status='$nav_prev'; return true;\"
onmouseout=\"window.status=''; return true;\"><<</a>";
}

for($i = $poffset; $i< $poffset+$pperpage && $i < $pages; $i++) {
$noffset = $i * $perpage;
$npoffset = $noffset/$perpage-$middlepage;
if ($npoffset<0) {$npoffset = 0;}
if ($npoffset>$maxpoffset) {$npoffset = $maxpoffset;}
$actual = $i + 1;
if ($actual==$actpage) {
echo "(<a href=\"$PHP_SELF?offset=$noffset&poffset=$npoffset\"
onmouseover=\"window.status='$nav_actpage'; return true;\"
onmouseout=\"window.status=''; return true;\">$actual</a>) ";
} else {
echo "[<a href=\"$PHP_SELF?offset=$noffset&poffset=$npoffset\"
onmouseover=\"window.status='$nav_gopage'; return true;\"
onmouseout=\"window.status=''; return true;\">$actual</a>] ";
}
}

if ($offset+$perpage<$amount_array["0"]) {
$noffset=$offset+$perpage;
$npoffset = $noffset/$perpage-$middlepage;
if ($npoffset<0) {$npoffset=0;}
if ($npoffset>$maxpoffset) {$npoffset = $maxpoffset;}
echo "<a href=\"$PHP_SELF?offset=$noffset&poffset=$npoffset\"
onmouseover=\"window.status='$nav_next'; return true;\"
onmouseout=\"window.status=''; return true;\">>></a> <br>";
}
}
?>

phpnow

# Calculate Page-Numbers
#################################################################################################
if (empty($perpage)) $perpage = 10;
if (empty($pperpage)) $pperpage = 9; //!!! ONLY 5,7,9,11,13 !!!!
//if (empty($sort)) $sort = "$miles ";
if (empty($offset)) $offset = 0;
if (empty($poffset)) $poffset = 0;

$amount = mysql_db_query($database, "SELECT count(*) FROM publicPhotos1 "); //
$amount_array = mysql_fetch_array($amount);
$pages = ceil($amount_array["0"] / $perpage);
$actpage = ($offset+$perpage)/$perpage;
$maxpoffset = $pages-$pperpage;
$middlepage=($pperpage-1)/2;
if ($maxpoffset<0) {$maxpoffset=0;}


echo "<b><div align=\"default\"><font face=\"Arial, Helvetica, sans-serif\" size=\"2\"><font color=\"#000033\">\n";

echo "<table width=\"100%\" border=\"0\" cellpadding=\"0\" cellspacing=\"0\" bgcolor=\"#000066\">
<tr> 
<td width=\"6%\"><div align=\"center\"></div></td>
<td width=\"88%\"><div align=\"center\"></div></td>
<td width=\"6%\"><div align=\"center\"></div></td>
</tr>
</table>"; 
if ($pages) { // print only when pages > 0
echo "$ad_pages\n";



if ($offset) {
$noffset=$offset-$perpage;
$npoffset = $noffset/$perpage-$middlepage;
if ($npoffset<0) {$npoffset=0;}
if ($npoffset>$maxpoffset) {$npoffset = $maxpoffset;}
echo "<a href=\"$PHP_SELF?offset=$noffset&poffset=$npoffset\"
onmouseover=\"window.status='$nav_prev'; return true;\"
onmouseout=\"window.status=''; return true;\"><<</a>";
}

for($i = $poffset; $i< $poffset+$pperpage && $i < $pages; $i++) {
$noffset = $i * $perpage;
$npoffset = $noffset/$perpage-$middlepage;
if ($npoffset<0) {$npoffset = 0;}
if ($npoffset>$maxpoffset) {$npoffset = $maxpoffset;}
$actual = $i + 1;
if ($actual==$actpage) {
echo "(<a href=\"$PHP_SELF?offset=$noffset&poffset=$npoffset\"
onmouseover=\"window.status='$nav_actpage'; return true;\"
onmouseout=\"window.status=''; return true;\">$actual</a>) ";
} else {
echo "[<a href=\"$PHP_SELF?offset=$noffset&poffset=$npoffset\"
onmouseover=\"window.status='$nav_gopage'; return true;\"
onmouseout=\"window.status=''; return true;\">$actual</a>] ";
}
}

if ($offset+$perpage<$amount_array["0"]) {
$noffset=$offset+$perpage;
$npoffset = $noffset/$perpage-$middlepage;
if ($npoffset<0) {$npoffset=0;}
if ($npoffset>$maxpoffset) {$npoffset = $maxpoffset;}
echo "<a href=\"$PHP_SELF?offset=$noffset&poffset=$npoffset\"
onmouseover=\"window.status='$nav_next'; return true;\"
onmouseout=\"window.status=''; return true;\">>></a> <br>";
}
}