prevent reload from resubmitting form

[IceRegent]

I have come accross a problem with my php coding. I have a script which does multiple things in one file. Hoever, this problem can occur on single function scripts as well. The problem occurs when a form is submitted, and then the php script performs the processing on the form, and enters the information into a database. If the user hits a page reload or refresh, the script will re-perform its function and repost the information again into the database. What is the most logical way to prevent the resubmission of form information and reposting it whenever the user hits the reload button?

[NogDog]

Probably the most common method used is to do a redirect to a "landing page" upon completion of the form processing. You can use the [man]header/man function to do the redirect.

[IceRegent]

Ok, situation is, main script is index.php. All other site functions are included from within the index depenant upon the selected choice. The function I am working with right now, contains multiple features dealing with the same feature set. It is my user forums. All functions are performed based upon selections, <a href> functions containing GET statements, such as : <a href="index.php?ftitle='. $row['forumtitle'] . '" target ="self">' . $row['forumtitle'] . '</a> This cycles it back thru the main index page, where, the session variable is still pointing to the function, in this case, the user forums. So, when the index script runs down the page, it gets to the decision, such as: if ($SESSION['select'] == "forums") { include 'forums.php'; }

The index will only include one script at a time for the main functions, depending upon what the session says is going on. So, it goes back to the forum.php script, and passes the $get varaible along with it. The forum.php scrip then performs it's own IF statements, and decides what funtion to perform based upon the returned variables including GET, POST and SESSION varables, all of which help the script decide what to do. So, the submission forms for the user forums are in the forums.php script too. So, if you return to the forum.php script and a form is presented, it is then submitted back to the index.php, which does any processing it needs to do, and includes the forum.php script along with it, which would then know to process the submitted form because of another $POST variable being set. A redirect is not desired in this setup, as after form is processed, it needs to go back and redisplay another segment of the script.

Ice

[IceRegent]

here is how the decisions are made in the index.php script:

// Check the $_GET selection passed from clickable links for selected user options
if ($_SESSION['select'] == "contact") 	{	include 'contact.php';	}	
if ($_SESSION['select'] == "forums") 	{	include 'forums.php'; 	}	
if ($_SESSION['select'] == "classifieds") 	{	include 'classifieds.php';	}	
if ($_SESSION['select'] == "home") 	{	include 'home.php'; }	
if ($_SESSION['select'] == "bands") 	{	include 'bands.php'; }
if ($_SESSION['select'] == "content")  { include 'content.php'; }
if ($_SESSION['select'] == "theme")  { include 'theme.php'; }
if ($_SESSION['select'] == "uplogo")  { include 'uplogo.php'; }
if ($_SESSION['select'] == "reset")  { include 'reset.php'; }
if ($_SESSION['select'] == "articles") { include 'articles.php'; }
if ($_SESSION['select'] == "email") { include 'email.php'; }
if ($_SESSION['select'] == "help") { include 'help.php'; }
if ($_SESSION['select'] == "mstudio") { include 'mstudio.php'; }
if ($_SESSION['select'] == "csent") { echo 'Your Message has been sent!'; }
if ($_SESSION['select'] == "reg") { include 'register.php'; }
//End CLICKABLE LINKS

Here is how the index.php presents the main menu to allow the selection choices for the main functions of the website:

// This will display the menus
echo '<div class="menu">';	
//  First menu segment displays for all users, logged in or not
echo '            <table class="button2">';
echo '						<tr><td><a href="index.php?select=home" target ="_self">Home</a></td></tr>';
echo '                <tr><td><a href="index.php?select=forums" target ="_self">Forums</a></td></tr>';
echo '                <tr><td><a href="index.php?select=bands" target ="_self">Band Pages</a></td></tr>';
echo '                <tr><td><a href="index.php?select=classifieds" target ="_self">Classifieds</a></td></tr>';
echo '                <tr><td><a href="index.php?select=articles" target ="_self">Articles</a></td></tr>';
echo '                <tr><td><a href="index.php?select=contact" target ="_self">Contact Us</a></td></tr>'; 

// If session is logged in, Display ADMIN menu	
if($_SESSION['valid'] == "yes") 
	{
echo '                <tr><td><a href="chat.php" target ="_blank">Chat Rooms</a></td></tr>';   

echo '                <tr><td><a href="index.php?select=content" target ="_self">Update Contents</a></td></tr>';
echo '					 	<tr><td><a href="index.php?select=uplogo" target ="_self">Update Logo</a></td></tr>';
echo '                <tr><td><a href="index.php?select=theme" target ="_self">Change Theme</a></td></tr>';
echo '                <tr><td><a href="index.php?select=reset" target ="_self">Reset Theme</a></td></tr>';
echo '                <tr><td><a href="index.php?select=email" target ="_self">User Email</a></td></tr>';
echo '					 	 <tr><td><a href="index.php?select=mstudio" target ="_self">MStudios</a></td></tr>'; 
echo '                <tr><td><a href="index.php?select=help" target ="_self">Website Help!</a></td></tr>';
echo '					 	<tr><td><a href="logout.php" target="_self">Logout</a></td></tr>';
}
echo '				</table>';
echo '</div>'; //End MENU DISPLAY

Each included script will perform its own set of functions, multiple functions, until another main menu option is chosen, then a different script will be included instead of the previous one. There are various checks above the menu section that clean up session variables when a different choice is made.

Ice

[dagon]

I haven't read the thread, however thoses if's after the first should be elseif, but switch() would be a much better idea.

[djjjozsi]

The question is: where this $SESSION['select'] gets a value?
from the menu's urls ? then you reach the values passed with the url with the $GET and not $_SESSION ...
Use arrays with the keys(conteact,forums) and include files values(contach.php,forums.php).

[cahva]

The initial question was that how can you prevent the resubmit of form. The actual resubmit you really just have to use the header funtion and do a redirect. I still dont know why you couldnt change your code to make this work. If you dont want to do this, you could set some session variable that form is already sent and not do the actions if this variable is set. But the redirect is always better.

And as dagon and djjjozsi said, that "if monster" can be done better using just an array or switch.
Heres how I would do it with array:

$pages = array(
	'contact'           => 'contact.php',
	'forums'            => 'forums.php',
	'classifieds'       => 'classifieds.php',
	'home'              => 'home.php',
	'bands'             => 'bands.php',
	'content'           => 'content.php',
	'theme'             => 'theme.php',
	'uplogo'            => 'uplogo.php',
	'reset'             => 'reset.php',
	'articles'          => 'articles.php',
	'email'             => 'email.php',
	'help'              => 'help.php',
	'mstudio'           => 'mstudio.php',
	'reg'               => 'register.php'
);

if (isset($_SESSION['select']) && in_array($_SESSION['select'],$pages))
{
	include($pages[$_SESSION['select']]);
}

Its missing "csent" which was different than others. Make a new file for that also so its unified with the others.

Other thing that was bothering me was how you echo lots of html. Theres really no need to do that. Just jump out of php if you want:

<?php if($_SESSION['valid'] == "yes"): ?>
                    <tr><td><a href="chat.php" target ="_blank">Chat Rooms</a></td></tr>
                    <tr><td><a href="index.php?select=content" target ="_self">Update Contents</a></td></tr>
                    <tr><td><a href="index.php?select=uplogo" target ="_self">Update Logo</a></td></tr>
                    <tr><td><a href="index.php?select=theme" target ="_self">Change Theme</a></td></tr>
                    <tr><td><a href="index.php?select=reset" target ="_self">Reset Theme</a></td></tr>
                    <tr><td><a href="index.php?select=email" target ="_self">User Email</a></td></tr>
                    <tr><td><a href="index.php?select=mstudio" target ="_self">MStudios</a></td></tr>
                    <tr><td><a href="index.php?select=help" target ="_self">Website Help!</a></td></tr>
                    <tr><td><a href="logout.php" target="_self">Logout</a></td></tr>
<?php endif; ?>

[djjjozsi]

And of course this menu could saved with the array you suggested. 🙂

[IceRegent]

Ok, obviously I am not a professional programmer, so, I am doing the best I can. That is why I havent done things in the wisest manner. I am trying to understand the things that you are saying, and will try to implement the refinements. The most important part at the moment, is understanding the advice about how to prevent the resubmission of the data. Let me see if I can digest it and come to an understanding of how to prevent it.

Ice

[IceRegent]

Ok, here is the complete forum.php script. I didnt want to have to post the entire script but, I might as well, so you can see where everything is coming from. First I am posting the entire index.php, followed by the forums.php.

index.php

<?php
session_start();
include 'include/config.php';
// This is the HTML head of the document - Load stylesheet as well
echo '<head>';
echo '<title>IceRegent NetWorx User Portal</title>';
echo '<link rel="stylesheet" type="text/css" href="visual.css">';
//echo '<meta http-equiv="refresh" content="10">';
echo '</head>';

// This is the LOGO section of the document
echo '<body>';
echo '   <div class="header">';
echo '        <img src="images/logo.png" width="100%" height="90px" alt="IceRegent NetWorx Logo"/>';
echo '    </div>'; 

// Check the session - Set session to NULL if anything but "yes" is found
if($_SESSION['valid'] <> "yes") 
	{ 
		$_SESSION['valid'] = NULL;
	} // End Session NULL

if($_GET['select'] <> NULL) //If selection in menu has been made, set session to selection
	{
		$_SESSION['select'] = $_GET['select'];
	} //End Selection session set

if($_SESSION['select'] <> "classifieds") //If selection is NOT classifieds, destroy classifieds sessions
	{
		$_SESSION['ctitle'] = NULL;	
		$_SESSION['postcat'] = NULL;	
		$_SESSION['cat'] = NULL;		
	} // End Classifieds 

if ($_GET['article'] <> NULL) //If article internal selection is not NULL, set session[article] to selection 
	{
		$_SESSION['article'] = $_GET['article'];
	}	
if ($_GET['article'] == NULL)
	{
		$_SESSION['article'] = NULL;
	} //End Article segment

if($_SESSION['select'] <> "forums") // If session is NOT forums, destroy forum session variables
	{		
		$_SESSION['forum'] = NULL;
		$_SESSION['ftitle'] = NULL;
		$_SESSION['topic'] = NULL;
	} //End forums

if($_SESSION['select'] == "home") //If session IS home, Destroy mstudio session variables
	{
		$_SESSION['project'] = NULL;
		$_SESSION['studio'] = NULL;
	} //End mstudio

if($_SESSION['select'] <> "mstudio") //If session is NOT mstudio, Destroy mstudio session variables
	{
		$_SESSION['project'] = NULL;
		$_SESSION['studio'] = NULL;
	} //End mstudio

// If choice selection has not been made, set choice selection to "home" in order to load home page
if($_SESSION['select'] == NULL) 
	{ 
		$_SESSION['select'] = "home"; 
	} //End home NULL

// If user is logged in, display that fact at the top of the screen
if($_SESSION['valid'] == "yes")
	{
		echo '<span class="loggedinas">Logged in : <br><b>' . $_SESSION['user'] . '</b></span>';
	} //End LoggedInAs

/*if($_SESSION['return'] <> NULL)
	{
		echo 'Return is NULL';
	} */

// This will display the menus
echo '<div class="menu">';	
//  First menu segment displays for all users, logged in or not
echo '            <table class="button2">';
echo '						<tr><td><a href="index.php?select=home" target ="_self">Home</a></td></tr>';
echo '                <tr><td><a href="index.php?select=forums" target ="_self">Forums</a></td></tr>';
echo '                <tr><td><a href="index.php?select=bands" target ="_self">Band Pages</a></td></tr>';
echo '                <tr><td><a href="index.php?select=classifieds" target ="_self">Classifieds</a></td></tr>';
echo '                <tr><td><a href="index.php?select=articles" target ="_self">Articles</a></td></tr>';
echo '                <tr><td><a href="index.php?select=contact" target ="_self">Contact Us</a></td></tr>'; 

// If session is logged in, Display ADMIN menu	
if($_SESSION['valid'] == "yes") 
	{
echo '                <tr><td><a href="chat.php" target ="_blank">Chat Rooms</a></td></tr>';   

echo '                <tr><td><a href="index.php?select=content" target ="_self">Update Contents</a></td></tr>';
echo '					 	<tr><td><a href="index.php?select=uplogo" target ="_self">Update Logo</a></td></tr>';
echo '                <tr><td><a href="index.php?select=theme" target ="_self">Change Theme</a></td></tr>';
echo '                <tr><td><a href="index.php?select=reset" target ="_self">Reset Theme</a></td></tr>';
echo '                <tr><td><a href="index.php?select=email" target ="_self">User Email</a></td></tr>';
echo '					 	 <tr><td><a href="index.php?select=mstudio" target ="_self">MStudios</a></td></tr>'; 
echo '                <tr><td><a href="index.php?select=help" target ="_self">Website Help!</a></td></tr>';
echo '					 	<tr><td><a href="logout.php" target="_self">Logout</a></td></tr>';
}
echo '				</table>';
echo '</div>'; //End MENU DISPLAY

// This will be the right side widget links
if($_SESSION['valid'] == "yes") 
	{
		echo '<div class="widgets">';
		echo '		<table class="widgetlinks">';
		echo '			<tr><td>Software Links</td></tr>';
		echo '			<tr><td>Widget link 2</td></tr>';
		echo '			<tr><td>Widget link 3</td></tr>';
		echo '			<tr><td>Widget link 4</td></tr>';
		echo '		</table>';
		echo '</div>';
	} //End WIDGETS

// Begin MAIN page content display       

echo '    <div class="pageContent">';

// If session is not logged in, display login box 
if($_SESSION['valid'] == NULL)
	{
		echo '		<div class="signin">';
		include 'signin.php';
		echo '		</div>';
	} //End LOGIN BOX

// This is the actual main processing section of the display content - self explanatory include scripts
//echo '<div class="main">';

// Check the $_GET selection passed from clickable links for selected user options
if ($_SESSION['select'] == "contact") 	{	include 'contact.php';	}	
if ($_SESSION['select'] == "forums") 	{	include 'forums.php'; 	}	
if ($_SESSION['select'] == "classifieds") 	{	include 'classifieds.php';	}	
if ($_SESSION['select'] == "home") 	{	include 'home.php'; }	
if ($_SESSION['select'] == "bands") 	{	include 'bands.php'; }
if ($_SESSION['select'] == "content")  { include 'content.php'; }
if ($_SESSION['select'] == "theme")  { include 'theme.php'; }
if ($_SESSION['select'] == "uplogo")  { include 'uplogo.php'; }
if ($_SESSION['select'] == "reset")  { include 'reset.php'; }
if ($_SESSION['select'] == "articles") { include 'articles.php'; }
if ($_SESSION['select'] == "email") { include 'email.php'; }
if ($_SESSION['select'] == "help") { include 'help.php'; }
if ($_SESSION['select'] == "mstudio") { include 'mstudio.php'; }
if ($_SESSION['select'] == "csent") { echo 'Your Message has been sent!'; }
if ($_SESSION['select'] == "reg") { include 'register.php'; }
//End CLICKABLE LINKS

// This segment is for Debugging info only and should only be displayed for a logged in ADMIN, iceregent
if(($_SESSION['valid'] == "yes") AND ($_SESSION['user'] == "iceregent"))
	{
		echo '<div class="displayvars">';
		echo '<iframe src ="vardisplay.php" width="230px" height="380px">';
		echo '</div>';
	}	//End DISPLAYVARS

//echo '   		</div>'; //End MAIN PROCESSING
echo '   </div>'; //End PAGE CONTENT
echo '</body>';

?>

I will post the forums one in the next posting.

Ice

[IceRegent]

forums.php

<?php
session_start();
include 'include/config.php';
echo ' <p><span class="pagetitle">IceRegent NetWorx User Forums</span></p>';
echo '<div class="forums">';

if($_SESSION['valid'] <> "yes") //Let user know they must be logged in before they can post - from valid session info
	{
		echo '<b> You must be logged in to post to the User Forums section </b>';
	} //End LOGGED IN		

if($_GET['select'] == "forums") //If user selected the forums, intitiate and display the main forum display section 
	{
		$_SESSION['return'] = NULL;
		$_SESSION['select'] = "forums";
		$_SESSION['forum'] = "view";
		$_SESSION['ftitle'] = NULL;
		$_SESSION['origthread'] = NULL;
		$_SESSION['topic'] = NULL;
		echo '<span class="route"><h3><a href="index.php?select=forums" target ="_self">Forums</a></h3></span>';
		echo '<table class="forumslist">';
		mysql_select_db(iceregen_bands);
		$query = "SELECT * FROM forumcat";
		$result = mysql_query($query) or exit(mysql_error());
		while($row = mysql_fetch_array($result, MYSQL_ASSOC)) 
			{
				echo '<tr><td><a href="index.php?ftitle='. $row['forumtitle'] . '" target ="_self">' . $row['forumtitle'] . '</a></td></tr>';
			} 
		echo '</table>';
	mysql_close();
	} //End MAIN FORUM DISPLAY section 

if($_GET['forum'] == "post") //If user has selected to POST NEW TOPIC, then display POST NEW TOPIC form 
	{		
		$posttopic = $_SESSION['ftitle'];
		echo '<span class="route"><a href="index.php?select=forums" target ="_self"><h3>Forums</a> - ';
		echo '<a href="index.php?ftitle='. $_SESSION['ftitle'] . '" target ="_self">' . $_SESSION['ftitle'] . '</a></h3></span>';
		echo '<form action="index.php" method="post" value="yes">';
		echo '<table>';
		echo '<tr>';
		echo '<td>Forum Posting to:</td><td>' . $posttopic . '</td>';
		echo '</tr>';
		echo '<input type="hidden" name="fpost" value="yes">';
		echo '<tr>';
		echo '<td>Forum Topic?</td><td><input type="text" name="ftopic"></td>';
		echo '</tr>';
		echo '<tr>';
		echo '<td>Your Content:</td><td><textarea name="fcontent" rows="3" cols="30"></textarea></td>';
		echo '</tr>';
		echo '<tr>';
		echo '<td><input type="submit" value="Post Topic"><input type="reset"></td>';
		echo '</tr>';
		echo '</table>';
		echo '</form>';
	} //End of POST NEW TOPIC display form

if($_POST['fpost'] == "yes") //If POST NEW TOPIC form has been submitted, then process the form
	{
		$_POST['fpost'] = NULL;
		$_SESSION['return'] = "titles";
		$ftitle=$_SESSION['ftitle'];
		$ftopic=$_POST['ftopic'];
		$fcontent=$_POST['fcontent'];
		$ftopic = stripslashes($ftopic);
		$ftopic = mysql_real_escape_string($ftopic);
		$fcontent = stripslashes($fcontent);
		$fcontent = mysql_real_escape_string($fcontent);
		$user=$_SESSION['user'];
		$fdate=date("y-m-d  H:i:s", time());
		$query = "INSERT INTO forumtop (ftid, forumtitle, topic, forumcont, uid, date, subtopic) VALUES (NULL, '$ftitle', '$ftopic', '$fcontent', '$user', '$fdate', NULL)";
		$result = mysql_query($query) or exit(mysql_error());
	} //End of POST NEW TOPIC processing section

if(($_GET['ftitle'] <> NULL) or ($_SESSION['return'] == "titles")) //If user has chosen a Forum to view, display all topics in the chosen forum 
	{
		$_SESSION['return'] = NULL;
		$_SESSION['ftitle'] = $_GET['ftitle'];
		if($_SESSION['valid'] == "yes") //If user is logged in, display option to post a new topic
		{				
			echo '<table class="button1">';				
			echo '<tr><td><a href="index.php?forum=post" target ="_self">NEW TOPIC</a></td></tr>';
			echo '</table>';				
		} //End NEW TOPIC	
		echo '<span class="route"><h3><a href="index.php?select=forums" target ="_self">Forums</a> - ';
		echo '<a href="index.php?ftitle='. $_SESSION['ftitle'] . '" target ="_self">' . $_SESSION['ftitle'] . '</a></h3></span>';
		echo '<table class="forumslist">';
		$ftitle=$_GET['ftitle'];
		mysql_select_db(iceregen_bands);
		$query = "SELECT ftid, topic, subtopic FROM forumtop WHERE forumtitle='$ftitle'";
		$result = mysql_query($query) or exit(mysql_error());
		while($row = mysql_fetch_array($result, MYSQL_ASSOC)) 
			{
				if($row['subtopic'] == NULL)
				{
					echo '<tr><td><a href="index.php?topic='. $row['topic'] . '" target ="_self">' . $row['topic'] . '</a></td></tr>';
				}
			} 
		echo '</table>';
		mysql_close();
	} //End DISPLAY ALL TOPICS section

if($_GET['topic'] <> NULL) //If user has selected a topic, then display all messages posted to that topic	
	{
		echo '<span class="route"><h3><a href="index.php?select=forums" target ="_self">Forums</a> - ';
		echo '<a href="index.php?ftitle='. $_SESSION['ftitle'] . '" target ="_self">' . $_SESSION['ftitle'] . '</a></h3></span>';		
		$_SESSION['return'] = NULL;
		$ftopic=$_GET['topic'];
		$_SESSION['topic'] = $ftopic;
		mysql_select_db(iceregen_bands);
		$query = "SELECT * FROM forumtop WHERE topic='$ftopic'";
		$result = mysql_query($query) or exit(mysql_error());
		while($row = mysql_fetch_array($result, MYSQL_ASSOC)) 
			{						
				echo '<table class="forumtopic">';
				echo '<tr><td><b>TOPIC : </b>' . $row['topic'] . '</td></tr>';
				echo '<tr><td><b>POSTED BY: </b>' . $row['uid'] . '</td></tr>';
				echo '<tr><td class="lace"><b>THREAD: </b>' . $row['forumcont'] . '</td></tr>';
				echo '<tr><td><b>Date Posted: </b>' . $row['date'] . '</td></tr>';
//				echo '<tr><td><b>Sub Topic: </b>' . $row['subtopic'] . '</td></tr>';
				echo '</table>';				
				if($row['subtopic'] <> NULL)
					{
						$_SESSION['origthread'] = $row['subtopic'];						
					}
				if($row['subtopic'] == NULL)
					{
					$_SESSION['origthread'] = $row['ftid'];
					}				
			} 	//End Display single Topics

	if($_SESSION['valid'] == "yes")
		{							
			echo '<table class="button1">';
			echo '<tr><td><a href="index.php?forum=reply" target ="_self">REPLY THREAD</a></td></tr><br>';
			echo '</table>';
		}	
		mysql_close();			
} //End DISPLAY ALL MESSAGES in Selected Topic

if($_GET['forum'] == "reply") //Display the reply to message topic form 
	{
		echo '<span class="route"><h3><a href="index.php?select=forums" target ="_self">Forums</a> - ';
		echo '<a href="index.php?ftitle='. $_SESSION['ftitle'] . '" target ="_self">' . $_SESSION['ftitle'] . '</a></h3></span>';	
		$postforum=$_SESSION['ftitle'];
		$posttopic=$_SESSION['topic'];
		$origthread=$_SESSION['origthread'];
		echo '<form action="index.php" method="post">';
		echo '<table>';
		echo '<input type="hidden" name="tpost" value="yes">';
		echo '<tr>';
		echo '<td>Forum Posting to:</td><td>' . $postforum . '</td>';
		echo '</tr>';		
		echo '<tr>';
		echo '<td>Original Thread:</td><td>' . $posttopic . '</td>';
		echo '</tr>';
		echo '<td>Your Reply:</td><td><textarea name="fcontent" rows="3" cols="30"></textarea></td>';
		echo '</tr>';
		echo '<tr>';
		echo '<td><input type="submit" value="Post Reply"><input type="reset"></td>';
		echo '</tr>';
		echo '</table>';
		echo '</form>';
	} //End REPLY to MESSAGE form

if($_POST['tpost'] == "yes") //If user has hit the submit button on the REPLY to MESSAGE form, process the data
	{
		$_POST['tpost'] = NULL;
		$_SESSION['return'] = "forums";
		$ftitle=$_SESSION['ftitle'];
		$ftopic=$_SESSION['topic'];
		$fcontent=$_POST['fcontent'];
		$ftoporig=$_SESSION['origthread'];
		$fcontent = stripslashes($fcontent);
		$fcontent = mysql_real_escape_string($fcontent);
		$user=$_SESSION['user'];
		$fdate=date("y-m-d  H:i:s", time());
		$query = "INSERT INTO forumtop (ftid, forumtitle, topic, forumcont, uid, date, subtopic) VALUES (NULL, '$ftitle', '$ftopic', '$fcontent', '$user', '$fdate', '$ftoporig')";
		$result = mysql_query($query) or exit(mysql_error());			
	} //End Process REPLY to MESSAGE

if($_SESSION['return'] == "forums") //If reply has posted, return to this point 
	{
		echo '<span class="route"><h3><a href="index.php?select=forums" target ="_self">Forums</a> - ';
		echo '<a href="index.php?ftitle='. $_SESSION['ftitle'] . '" target ="_self">' . $_SESSION['ftitle'] . '</a></h3></span>';				
		$_SESSION['return'] = NULL;
		$ftopic = $_SESSION['topic'];
		include 'include/config.php';
		mysql_select_db(iceregen_bands);
		$query = "SELECT * FROM forumtop WHERE topic='$ftopic'";
		$result = mysql_query($query) or exit(mysql_error());
		while($row = mysql_fetch_array($result, MYSQL_ASSOC)) 
			{						
				echo '<table class="forumtopic">';
				echo '<tr><td><b>TOPIC : </b>' . $row['topic'] . '</td></tr>';
				echo '<tr><td><b>POSTED BY: </b>' . $row['uid'] . '</td></tr>';
				echo '<tr><td class="lace"><b>THREAD: </b>' . $row['forumcont'] . '</td></tr>';
				echo '<tr><td><b>Date Posted: </b>' . $row['date'] . '</td></tr>';
//				echo '<tr><td><b>Sub Topic: </b>' . $row['subtopic'] . '</td></tr>';
				echo '</table>';				
				if($row['subtopic'] <> NULL)
					{
						$_SESSION['origthread'] = $row['subtopic'];						
					}
				if($row['subtopic'] == NULL)
					{
					$_SESSION['origthread'] = $row['ftid'];
					}
			}
	} 	//End Display single Topics	

echo '</div>';
?>

So, I know there are numerous way to do things better, but, as I said, I am not a pro,so I am doing the best I can.

Ice

[IceRegent]

For some reason, the suggestion from "cahva" only works if the IF statement is changed from

if (isset($SESSION['select']) && in_array($SESSION['select'],$pages))

to this:

if (isset($_SESSION['select']))

Otherwise, with the original change, it displays blank no matter what I do on the page. I am trying to understand the reason for the failure to work.

Ice

[IceRegent]

I just now tried modifying this section:

if($_GET['select'] <> NULL) //If selection in menu has been made, set session to selection
	{
		$_SESSION['select'] = $_GET['select'];
	}  //End Selection session set 

if($_SESSION['select'] <> "classifieds") //If selection is NOT classifieds, destroy classifieds sessions
	{
		$_SESSION['ctitle'] = NULL;	
		$_SESSION['postcat'] = NULL;	
		$_SESSION['cat'] = NULL;		
	} // End Classifieds 

if($_SESSION['select'] <> "forums") // If session is NOT forums, destroy forum session variables
	{		
		$_SESSION['forum'] = NULL;
		$_SESSION['ftitle'] = NULL;
		$_SESSION['topic'] = NULL;
	} //End forums

if($_SESSION['select'] == "home") //If session IS home, Destroy mstudio session variables
	{
		$_SESSION['project'] = NULL;
		$_SESSION['studio'] = NULL;
	} //End mstudio

if($_SESSION['select'] <> "mstudio") //If session is NOT mstudio, Destroy mstudio session variables
	{
		$_SESSION['project'] = NULL;
		$_SESSION['studio'] = NULL;
	} //End mstudio

// If choice selection has not been made, set choice selection to "home" in order to load home page
if($_SESSION['select'] == NULL) 
	{ 
		$_SESSION['select'] = "home"; 
	} //End home NULL

Into this CODE:

switch ($_GET['select']) 
{
case not NULL : 
$_SESSION['select'] = $_GET['select'];
break;
case not "classifieds" : 	
$_SESSION['ctitle'] = NULL										  $_SESSION['postcat'] = NULL;	
$_SESSION['cat'] = NULL;	
break;
case not "forums" :			
$_SESSION['forum'] = NULL;									
$_SESSION['ftitle'] =NULL;											$_SESSION['topic'] = NULL;
break;
case "home" :	
$_SESSION['project'] = NULL;
$_SESSION['studio'] = NULL;
break;
case not "mstudio" :
$_SESSION['project'] = NULL;
$_SESSION['studio'] = NULL;
break;
default :
$_SESSION['select'] = "home";
} //End SELECT SWITCH

It is more compact to do it this way, however...Now I get error statement of:

Parse error: syntax error, unexpected T_STRING in /home/iceregen/public_html/index.php on line 33

Line 33 is :

case not NULL : $_SESSION['select'] = $_GET['select'];

I need to check for the NOT condition, I must not be understanding the correct syntax?

Ice

[johanafm]

In cahvas code, change in_array to array_key_exists. in_array looks for array element values while array_key_exists checks the keys.

[johanafm]

And your error message is due to a missing ;

case not "classifieds" :     

$_SESSION['ctitle'] = NULL   // no ;

Also, the cases for your switch statement aren't ok. You have to set fixed cases, not ranges or the "anything other than specific value" that you use. I.e. "not" is not ok in this context.