problem creating zip file

[greedyisg00d]

I found this code using google and the problem is it only creates the zip file but the contents are not included.

function create_zip($files = array(),$destination = '',$overwrite = false) {
	//if the zip file already exists and overwrite is false, return false
	if(file_exists($destination) && !$overwrite) { return false; }
	//vars
	$valid_files = array();
	//if files were passed in...
	if(is_array($files)) {
		//cycle through each file
		foreach($files as $file) {
			//make sure the file exists
			if(file_exists($file)) {
				$valid_files[] = $file;
			}
		}
	}
	//if we have good files...
	if(count($valid_files)) {
		//create the archive
		$zip = new ZipArchive();
		if($zip->open($destination,$overwrite ? ZIPARCHIVE::OVERWRITE : ZIPARCHIVE::CREATE) !== true) {
			return false;
		}
		//add the files
		foreach($valid_files as $file) {
			$zip->addFile($file,$file);
		}
		//debug
		//echo 'The zip archive contains ',$zip->numFiles,' files with a status of ',$zip->status;

	//close the zip -- done!
	$zip->close();

	//check to make sure the file exists
	return file_exists($destination);
}
else
{
	return false;
}
}


$files_to_zip = array('C:/employee.txt','C:/company.txt','C:/sales.txt');
$result = create_zip($files_to_zip,'C:/FILES/myfiles.zip');
if(!$result)
	echo'Failed';
else
	echo'Done';

[johanafm]

The script looks like it should work. The reason the files are not added is that this condition fails

if(file_exists($file)) { 

Either, the files you specified really don't exist, or there is a problem with the path. But, I'm not presently on a windows machine, so I can't check what might go wrong. Perhaps try replacing / with \ in the path. Additionally if safe_mode is enabled, then file_exists will return false for existing files for which you have no access rights.

Also, I'd make this change

    if(is_array($files)) {
        //cycle through each file
        foreach($files as $file) {
            //make sure the file exists
            if(file_exists($file)) {
                // $valid_files[] = $file;
                $zip->addFile($file);
            }
        }
    }

Then take the above code block and substitute it for

        //add the files
        foreach($valid_files as $file) {
            $zip->addFile($file,$file);
        } 

The more and/or larger files you add and the more users around who may rename, move or delete files, the more important this is. Since your script first checks if the files exist, and only tries to add them some time later, it is entirely possible that someone else makes changes on disk so that a file no longer exist when your script actually tries to add it.
Even with my suggested change, there is of course a small risk this could happen, but at least it minimizes time between file accesses in if (file_exists) and zip->add.

[greedyisg00d]

The code works when I change my path to the same folder where the script is located but now I cannot open or extract the file because it says it is corrupted but when I try to zip it manually it works fine

[johanafm]

What claims it's corrupted? Is it the standard windows zip utility? Could be path issues again, since that utility doesn't handle some stuff, such as path starting with '/'.

[greedyisg00d]

it displays an error "unexpected end of line"

[johanafm]

it?

I ran your code with php 5.3, then unzipped the archive using OSX's archive tool. No errors.