What is up with PHP

[Beauford2]

I am getting all sorts of oddities happening with PHP, where I know the code is 100% correct, but it just doesn't work.

Case in point.

require("constants.php");

$db->query("UPDATE users SET daysingang=daysingang+1 WHERE gang > 0");
$db->query("UPDATE users SET rmdays=rmdays-1 WHERE rmdays > 0 ");
$db->query("UPDATE users SET rmpack=0 WHERE rmdays <= 0");
$db->query("UPDATE rmpacks SET rmDAYS=rmDAYS-1 WHERE rmDAYS > 0");
$db->query("DELETE FROM rmpacks WHERE rmDAYS <= 0");
$db->query("UPDATE users SET daysold=daysold+1, crack=0, boxesopened=0, bubbas=0, slots=0, roulette=0, searchdowntown=0, gamevote=0, defencecount=0");
$db->query("UPDATE users SET mail=mail-1 WHERE mail > 0");
$db->query("UPDATE users SET forum=forum-1 WHERE forum > 0");
$db->query("DELETE FROM moth WHERE time < unix_timestamp()-86400");
$db->query("UPDATE settings SET logins=0");
$db->query("UPDATE users SET keno=0 WHERE keno > 0");

Everything works but the last line. If I run it from the command line, works great.

This is only one example of dozens that I have come across.

I know everyones saying, sure, sure - idiot programmer, and sometimes it is, but why does the above not work? This is it, there is no other code. This is one script and it runs in a seperate cron.

constants.php just has the MySQL connect info in it.

Using PHP 5.2x and MySQL 5.x on a Linux server with Apache (not sure of version)

Ideas? 😕

[NogDog]

Please define "just doesn't work". Have you checked the PHP error logs or turned on all error reporting? Have you checked the return values from your query function calls and used the appropriate error reporting mechanism for your database interface if they fail?

E.g.:

<?php
ini_set('display_errors', 1); // set to 0 for production version
error_reporting(E_ALL);

require("constants.php");

$result = $db->query("UPDATE users SET daysingang=daysingang+1 WHERE gang > 0");
if($result == false) {
   // do something here to generate debug data
}
// etc...
?>

[Beauford2]

Doesn't work means, as should be self evident from the line itself, does not update the DB. If keno is > 0 it should set it to 0. It does not.

No errors no nothing, just doesn't update. The line before and the line after work fine.

To make it more interesting, check this. I removed the last line and added it to the 6th line - still doesn't work, but everything else in the line does.

And yes, I have checked and quadruple checked, and everything about this is correct. If I take that entire line 6 and run it from the command line, keno gets updated as it should - it is reset to '0'.

$db->query("UPDATE users SET daysingang=daysingang+1 WHERE gang > 0");
$db->query("UPDATE users SET rmdays=rmdays-1 WHERE rmdays > 0 ");
$db->query("UPDATE users SET rmpack=0 WHERE rmdays <= 0");
$db->query("UPDATE rmpacks SET rmDAYS=rmDAYS-1 WHERE rmDAYS > 0");
$db->query("DELETE FROM rmpacks WHERE rmDAYS <= 0");
$db->query("UPDATE users SET daysold=daysold+1, crack=0, boxesopened=0, bubbas=0, slots=0, roulette=0, searchdowntown=0, gamevote=0, defencecount=0, keno=0");
$db->query("UPDATE users SET mail=mail-1 WHERE mail > 0");
$db->query("UPDATE users SET forum=forum-1 WHERE forum > 0");
$db->query("DELETE FROM moth WHERE time < unix_timestamp()-86400");
$db->query("UPDATE settings SET logins=0");

So if it updates successfully from the command line, how can it not update while in the script above, especially since everthing elses updates just fine in this script.

Thx

[NogDog]

When you test it from the command line do you use the same DB user as is used by your script's database connection? (I.e., if not, could it be an access issue for that table?)

Other than that, all I can suggest (my crystal ball isn't working today) is to do some defensive programming similar to what I posted above. I don't know which database interface $db represents (or your own class?), but if, for example, it's MySQLi, you might do:

$sql = "UPDATE users SET keno=0 WHERE keno > 0";
$result = $db->query($sql);
if($result == false)
{
   user_error($db->error . "<br />\n$sql"); // get the MySQL error and see the exact query
}
elseif($db->affected_rows = 0)
{
   user_error("No rows updated: $sql");
}
else
{
   // for testing, comment out for live version:
   echo $db->affected_rows . " updated<br />\n"; // or just error_log() it?
}

Or better yet, extend your $db class to include a method that will do that with the desired error reporting.

[BuzzPHP]

If its just one field that is giving problems, and all the others update as expected, then I'd delete the field and create it again.

Or, try using a different field name. There could be some strange field setting in there that is effecting that field and nothing else.

But, thats assuming the keno field is no different to the other integer fields.

Strange things happen.