[RESOLVED] AdminBot Script Help

matt002

Hi coders,

I have a adminbot script for SWAT4 to which I have coded. It basically checks the servers chat & actions and uses MYSQL to keep track of known trouble makers etc

I am having difficulties at the moment runninng the script successfully with only certain bits functioning correctly. This is probably due to the "scrappy" coding and bad practices from a novice.

I wondered if a coder with good knowledge and a keen eye could look over my script and check it for errors and offer alternatives to what they see if required?

If someone has time to assist me, I would much appreciate it.

The main script is attached (prepare to be shocked, amazed and bewildered- in a bad way) lol

Go easy on me, although it works, the reliability is bad due to so many novice mistakes and poor coding.

Regards

Matt

BuzzPHP

1) You have uploaded approx. 800 lines of code.
2) At the top it states

Then you state:

I am having difficulties at the moment runninng the script successfully with only certain bits functioning correctly. This is probably due to the "scrappy" coding and bad practices from a novice.

That doesn't make any sence to me.

It is clear to me the code was written by someone with some decent knowledge. It uses some concepts that take years to learn.

And then you say "bad practices from a novice".

To me this smells of someone who stole the code, claimed its theirs and then is asking for free help to fix it up.

That is insulting on so many levels.

matt002

I am actually quite offended by your post.

In my eyes although I have had help, as posted in the credits at the top if you read, I consider myself a novice when it comes to security and tidy code writing.

If you were any expert, you would see the code is messy in places and hence why I wanted an opinion not a useless accusation.

I never steal code, I coded that myself with assitance along the way and I am utterly outraged how someone who barely knows me and cannot be constructive decided to say my hard work (I have nearly spent a year on this script) is credited to someone else!

I tell you something, your SMELL is wrong and is absolutely rubbish.

Go judge someone who ACTUALLY does rob others hard work, not those who do not!

If your not going to answer my question or aim to help, why bother posting in a supposedly coding help forum.

matt002

Oh and let me add.... ill give you £100 if you find a SWAT 4 Adminbot script anywhere what does what my script does. Trust me, I have tried before deciding to spend my time coding one! There are so many words I could call you right now after that insult, and one of the nicer ones would be arrogant!

Shrike

BuzzPHP;10930631 wrote:
1) You have uploaded approx. 800 lines of code.
2) At the top it states

"Coded by |SOG|Matt - Sog-team.co.uk - © COPYRIGHT 2009"

Then you state:

That doesn't make any sence to me.

It is clear to me the code was written by someone with some decent knowledge. It uses some concepts that take years to learn.

And then you say "bad practices from a novice".

To me this smells of someone who stole the code, claimed its theirs and then is asking for free help to fix it up.

That is insulting on so many levels.

Honestly, do you really think that this is the case? Steal is not often a word associated with open source now is it?

Matt002 - the main problem I can see with this code is that it's a big plate of spaghetti. The first thing I would do is start breaking it down into functions, and try to remove as much duplication as possible. It's just too awkward to read that much code.

matt002

Thank you Shrike, I appreciate your response.

I have never been great at functions, but it isnt the first time somone told me the same as you. I am concerned though that I need to recode everything in order to get it to work as functions.

Thanks for your feedback though, I shall try see what I can do.

Neville1985

Break it down man, it'll take a bit of time, but will be well worth it in the end. do some reading about classes and OOP, makes life so much easier after you get over the learning curve.

Apress PHP Objects, Patterns and Practice 2nd Edition

Google that, its a long read, but after your done you will have a greater understanding of OOP design. When I learnt about it, I went through alot of my code an re-structured it.

If you really did design said code, you will be able to follow it and break it down. Take that how u want to. lol 😛