[RESOLVED] quotation problem

prkarpi

Hello everyone.
I have this code.

...some code

if(@file_exists("uploads/" .$filename)){
          //Rename the file to an MD5 version
          rename("uploads/".$filename, "uploads/".$hashedfilename);
          echo "The file ".  basename( $filename ). "has been uploaded.  Your file is <a href='uploads/$hashedfilename'>here</a>.";
          }  

...some code

Entire code works like a charm. However, when I try to change "uploads/" directory to a var directory it shows an error. So let say:

$target_path = "some dir";
          if(@file_exists($target_path . $filename)){
          //Rename the file to an MD5 version
          rename("$target_path".$filename, "$target_path".$hashedfilename);
          echo "The file ".  basename( $filename ). "has been uploaded.  Your file is <a href='$target_path.$hashedfilename'>here</a>.";
          }

I am thinking the problem lies within the " or ' quotations. I've tried both - no use. Any ideas?

Thank you.

jaql

prkarpi;10931651 wrote:

Hello everyone.
I have this code.

...some code

if(@file_exists("uploads/" .$filename)){
          //Rename the file to an MD5 version
          rename("uploads/".$filename, "uploads/".$hashedfilename);
          echo "The file ".  basename( $filename ). "has been uploaded.  Your file is <a href='uploads/$hashedfilename'>here</a>.";
          }  

...some code

Entire code works like a charm. However, when I try to change "uploads/" directory to a var directory it shows an error. So let say:

$target_path = "some dir";
          if(@file_exists($target_path . $filename)){
          //Rename the file to an MD5 version
          rename("$target_path".$filename, "$target_path".$hashedfilename);
          echo "The file ".  basename( $filename ). "has been uploaded.  Your file is <a href='$target_path.$hashedfilename'>here</a>.";
          }

I am thinking the problem lies within the " or ' quotations. I've tried both - no use. Any ideas?

Thank you.

If you use a variable to hold the name of your directory you shouldn't need quotes around the variable name.

You should be able to do something like this:

<?php
$target_path = "uploads/";

if (@file_exists($target_path . $filename)) {
  //Rename the file to an MD5 version
  rename($target_path.$filename, $target_path.$hashedfilename);
  echo "The file ".  basename( $filename ). "has been uploaded.  Your file is <a href='$target_path.$hashedfilename'>here</a>.";
}

Also, make sure there's a / somewhere between $target_path and $filename so that a real path is generated; either already in $target_path like above, between the two, like this:

$target_path.'/'.$filename

or in the $filename variable.

prkarpi

Thank you.

But no - this does not work. I've tried using " and ' and no quotes. There might be a different solution. Any other ideas?

jaql

Try using copy() instead of rename():

<?php
$target_path = "uploads/";

if (@file_exists($target_path . $filename)) {
  //Rename the file to an MD5 version
  copy($target_path.$filename, $target_path.$hashedfilename);
  echo "The file ".  basename( $filename ). "has been uploaded.  Your file is <a href='$target_path.$hashedfilename'>here</a>.";
}

You could then delete the old file if you wanted to after it is copied by using unlink().

Also, what does $filename contain? Is it literally just a filename, like foo.exe, or is it a path + a filename, like path/to/foo.exe? If it's a path and a filename, then I understand why you're using basename() in your echo statement, but if it's just a filename, you shouldn't need basename(). Not that this will fix your problem, but I was just wondering.

prkarpi

ok. the solution lies in how PHP sees directories. I have found a solution within this: http://www.php.net/manual/en/ini.sect.safe-mode.php#ini.safe-mode-include-dir

Thanks.

jaql

prkarpi;10931663 wrote:
ok. the solution lies in how PHP sees directories. I have found a solution within this: http://www.php.net/manual/en/ini.sect.safe-mode.php#ini.safe-mode-include-dir

Thanks.

Cool, as long as you fixed it.

I just tried something similar on my local machine and it worked fine:

<?php
$path = 'files/';
$filename = 'green.jpg';
$newname  = 'green2.jpg';

if(@file_exists($path.$filename)) {
  rename($path.$filename, $path.$newname);
  echo "The file ".  basename( $filename ). " has been uploaded.  Your file is <a href='$path.$newname'>here</a>.";
}

prkarpi

jaql, thanks, but try to put a full directory into the $path variable. For example: "C://Programfiles/wamp/www/somedirectory"... PHP 5 won't allow to do so without declaring a safe directory first.