Problem implementing PHP cache routine

getgray

Hi guys:

I am trying to implement some commonly published cache control code using a PHP script attached.

It appears to be almost working. The problem I am having is that the variable
$reqfilename
does not appear to be getting set.

I am not a PHP programmer, and am probably missing something fundamental

Can someone tell me how to properly set this variable in this code?

I am running Apache for my webserver.

<?php        

$cachefile = "cache/".$reqfilename.".html";

// Serve from the cache if it is the same age or younger than the last 
// modification time of the included file (includes/$reqfilename)

  if (file_exists($cachefile) && (filemtime("includes/".$reqfilename) < filemtime($cachefile))) {  

include($cachefile);
echo "<!-- Cached ".date('H:i', filemtime($cachefile))."-->\n";
exit;        
  }

//else
// start the output buffer        

ob_start(); 
?>

// Normal HTML here

<?php    

    // PHP, open the cache file for writing
    $fp = fopen($cachefile, 'w');

// save the contents of output buffer to the file        
fwrite($fp, ob_get_contents());

// close the file        
fclose($fp);

// Send the output to the browser        
ob_end_flush();
?>

dagon

the tutorial you followed explains its set for his site, but as your not using his template you are going to have to define it ourself
something like this should work:

$reqfilename=md5($_SERVER['SCRIPT_FILENAME']);

this may or may not work depending on your site set up.

getgray

Thanks Dragon.

Somone suggested I try this:

$reqfilename = basename($_SERVER['REQUEST_URI'], ".html");

That appears to have take care of it and it is working now.

Thanks again very much for the time to help.

Best,
Scott

getgray

Dagon that is, sorry bout that... don't seem to be able to edit.

dagon

that will work if you don't have more than one file with the same name, but is not uncommon to have several index.php files in different dirs (also wouldn't work if you where using a front end controller). Since all you cache files are in one dir, only using the file name could be a problem.

I use to cache all my sites, now i cache none, they are all so dynamic that they always need to refresh the contents and a lot of the issues that where solved with caching simply don't exist any more.

getgray

Hmmm. This stuff is never easy for a beginner 🙂.

I don't know what a front end would be, hopefully I don't have one.

As for teh possibility of multiple index files, I will take that into consideration. Thank you.

Weedpacket

Perhaps a premade solution like PEAR's Cache Lite would be more convenient.

dagon

my option for the cache file name would solve the multiple file name issues, as it uses the whole path, but weedpacket's solution my be more convenient. If you don't know that you need to be caching, then don't -- as you see how it wraps your code, it is something that's easy to add at a latte date.

getgray;10931808 wrote:
Hmmm. This stuff is never easy for a beginner 🙂.

php is one of the easiest languages to learn with lots of great resource's on the net -- like us:-)

getgray

$reqfilename=md5($SERVER['SCRIPT_FILENAME']);

Dagon: Once I got it basically working the other way, I went back to see what your line above did. I wasn't familiar with what $SERVER returned so didn't see it right off at first. Once I played with it I see what it is doing now. I implemented it and it appears to do exactly what I need. Since my site is mainly static, this appears to be a simple enough, great solution. And it seems to give me the ability to easily "expire" some content by simply clearing the/a cache.

I looked at PEAR and it seems to be powerful, but more complex than is needed for my relatively simple site. And with a decent learning curve.

Thanks for the help!