Unexpected T_ELSE

[jakey]

Heya guys,

Been messing around with this for a while now, I'm no PHP coder (Especially at 9:55 on a Monday morning) and I keep getting syntax errors. Maybe one of you PHP buffs can set me straight? :p

<?php

insert('dbconn.php');

mysql_select_db("gumballtest_99k_crm1", $con);

$sql="select * from contacts WHERE name LIKE '$srch')";

if ($query)
{
echo "Here are the results:<br><br>";
echo "<table width=90% align=center border=1><tr>
<td align=center bgcolor=#00FFFF>Name</td>
<td align=center bgcolor=#00FFFF>Email</td>
<td align=center bgcolor=#00FFFF>Telephone</td>
<td align=center bgcolor=#00FFFF>Rally Year</td>
</tr>";

while ($r = mysql_fetch_array($query)) { // Begin while
$name = $r["name"];
$email = $r["email"];
$Telephone = $r["telephone"];
$rally_year = $r["rally_year"];
echo "<tr>
<td>$name</td>
<td>$email</td>
<td>$telephone</td>
<td>$rally_year</td></tr>
<tr> <td colspan=4 bgcolor=\"#ffffa0\">$comment</td>
</tr>";
} // end while
echo "</table>";
} else { echo "problems...."; } else {
echo "Search string is empty. <br> Go back and type a string to search";
}
?>

The error i keep getting thrown is

Parse error: syntax error, unexpected T_ELSE in /htdocs/search.php on line 33

[jakey]

Woo, that was a silly error. Got rid of one 'else' 🙂

Now it's throwing an unexpected t_string D:

Revised code:

<?php
insert('dbconn.php')
mysql_select_db("gumballtest_99k_crm1", $con);

$sql="select * from contacts WHERE name LIKE '$srch')";

if ($query)
{
echo "Here are the results:<br><br>";
echo "<table width=90% align=center border=1><tr>
<td align=center bgcolor=#00FFFF>Name</td>
<td align=center bgcolor=#00FFFF>Email</td>
<td align=center bgcolor=#00FFFF>Telephone</td>
<td align=center bgcolor=#00FFFF>Rally Year</td>
</tr>";

while ($r = mysql_fetch_array($query)) { // Begin while
$name = $r["name"];
$email = $r["email"];
$Telephone = $r["telephone"];
$rally_year = $r["rally_year"];
echo "<tr>
<td>$name</td>
<td>$email</td>
<td>$telephone</td>
<td>$rally_year</td></tr>
<tr> <td colspan=4 bgcolor=\"#ffffa0\">$comment</td>
</tr>";
} // end while
echo "</table>";
} else {
echo "Search string is empty. <br> Go back and type a string to search";
}
?>

[BuzzPHP]

1) Replace "insert" with "include_once"
2) Is $con valid? ie: Have you actually connected to a mysql server?
3) You haven't set the $srch variable
4) You have a ')' at the end of the SQL string.
5) $query is not valid. You haven't called $query = mysql_query($sql).
6) $Telephone and $telephone are different variables.
7) You havent set $comment
8) You have "} else { echo "problems...."; } else {" yet, only one level of if. For each "if" statement, you can only have one "else"

Im unsure whats in 'dbconn.php' but, you need to make sure you have a valid mysql connection before you can assume you can connect to a database.

You need to learn to step though your code and verbose error messages. Just because you have a pile of code doesn't mean its going to work as one.

Step though your code one line at a time a validate all your assumptions.

ie: If you beleive a line of code is working, then prove it to yourself. Otherwise you can overlook the most simplest bugs.

[Weedpacket]

None of those problems would lead to a parse error, of course: the code is so broken that it's not even being run. jakey, consider using [noparse]

...

[/noparse] to post your code (as described in the Coding Forum FAQ, where, by the way, I am moving this thread to because it's currently in the wrong place.

Parse errors are the simplest to fix because they're so basic (PHP can see there's a problem just by looking at it). In this case, your "insert" line (which as BuzzPHP is probably supposed to be "include_once") is missing its terminating semicolon.