[RESOLVED] PHP While Loop advice

[ee12csvt]

Hi,

I have created a while loop using Dreamweaver CS3

$colname_rsNumbers = "-1";
if (isset($_GET['id'])) {
  $colname_rsNumbers = $_GET['id'];
}
mysql_select_db($database_connGrowl, $connGrowl);
$query_rsNumbers = sprintf("SELECT * FROM growl_numbers WHERE LocoID = %s", GetSQLValueString($colname_rsNumbers, "text"));
$rsNumbers = mysql_query($query_rsNumbers, $connGrowl) or die(mysql_error());
$row_rsNumbers = mysql_fetch_assoc($rsNumbers);
$totalRows_rsNumbers = mysql_num_rows($rsNumbers);

and the page code is

<?php do { ?>
                <?php echo $row_rsNumbers['LocoNo']; ?>&nbsp;
                <?php } while ($row_rsNumbers = mysql_fetch_assoc($rsNumbers)); ?>

The ID variable is passed from the previous page which gives a result like

Loco1 Loco2 Loco3 Loco4

I want to print the results across the page with a separator between the numbers (e.g. / ) and a full stop after the last one.

Loco1 / Loco2 / Loco3 / Loco4.

The answer is probably quite simple, I have been altering the code to try and achieve the result I want for a number of weeks, so any advice would be much appreciated.

Thanks

Phil

[BuzzPHP]

Put the results into an array and then use implode() to create your formated version.

<?php
$array = array();
do {
  $array[] = $row_rsNumbers['LocoNo']; 
} while ($row_rsNumbers = mysql_fetch_assoc($rsNumbers)); 
echo implode(" / ", $array). ".";
?>

But, I would get rid of the first mysql_fetch_assoc() function call and use:

<?php
$array = array();
while ($row_rsNumbers = mysql_fetch_assoc($rsNumbers))
{
  $array[] = $row_rsNumbers['LocoNo']; 
}
echo implode(" / ", $array). ".";
?>

[BuzzPHP]

BTW: The reason I would use the second version is in the event no records are found. In which case, the first code will most likely print something weird.

Actually, something like this might be needed in such cases.

if (count($array) > 0) echo implode(" / ", $array). "."; 

But, im not sure what your needs are.

[ee12csvt]

BuzzPHP,

Many thanks for you advice, I have implemented it on the page I was working on with the desired results.

Much appreciated

Phil