File Upload Error

steveday21

I been learning from a teach yourself book and have come up against a brickwall that is making me crazy. Thank you in advance to anyone that can help me!

The error message I am getting is;

Parse error: syntax error, unexpected T_STRING, expecting ']' in C:\Program Files\Apache Software Foundation\Apache2.2\htdocs\Sams\do_upload.php on line 5

The html for the upload page is;

<html>
<head>
<title>A simple file upload form</title>
</head>

<input type="hidden" name="MAX_FILE_SIZE" value="51200" />
<p><strong>File to Upload:</strong>
<input type="file" name="fileupload" /></p>

And finally the php code I have copied from the book is

<?php
$file_dir = "C:\Program Files\Apache Software Foundation\Apache2.2\htdocs\test\";

foreach($FILES as $file_name => $file_array) {
echo "path: ".$file_array['"tmp'name"]."<br />\n";
echo "name: ".$file_array[''"name"]."<br />\n";
echo "type: ".$file_array["'type'"]."<br />\n";
echo "size: ".$file_array[''"size"]."<br />\n";

if (is_uploaded_file($file_array['"tmp_'name"]))
{	move_uploaded_file($file_array['"tmp_'name"],"$file_dir".$file_array["name"]") or die ("Couldn't copy");
  	echo "file was moved!<br />";
}

}
?>

I am a little confused about all the ' and " usage but this exactly as it appears in the book so I'm wondering is it a publishers error or am I missing something?

Your help will be hugely well received.

dagon

echo "name: ".$file_array[''"name"]."<br />\n";

should be

echo "name: ".$file_array['name']."<br />\n";

steveday21

Ok, it looks like this has made some progress but I stumble again. Changing only the ['name'] didn't change the error so I applied the logic to the other [..] bits (which may have been a little naive but thought it was worth a try)

I changed the code to look like this;

<?php
$file_dir = "C:\Program Files\Apache Software Foundation\Apache2.2\htdocs\test\";

foreach($_FILES as $file_name => $file_array) {
echo "path: ".$file_array['tmp_name']."<br />\n";
echo "name: ".$file_array['name']."<br />\n";
echo "type: ".$file_array["'type'"]."<br />\n";
echo "size: ".$file_array['size']."<br />\n";

if (is_uploaded_file($file_array['tmp_name']))
{	move_uploaded_file($file_array['tmp_name'],"$file_dir".$file_array["name"]") or die ("Couldn't copy");
  	echo "file was moved!<br />";
}

}
?>

I did this sytematically because as I went through the code the error message repeated except it quoted the next line of code so I assumed the same logic and progressed through to the end. I reach a new error for the code above;

Parse error: syntax error, unexpected T_CONSTANT_ENCAPSED_STRING in C:\Program Files\Apache Software Foundation\Apache2.2\htdocs\Sams\do_upload1.php on line 11

This is why it's been making me crazy!!! I got this far before and assumed that I must be barking up the wrong tree.

Thanks again for your help.

dagon

that book is so full of errors, i would suggest not using it, line 11 should be:

{ move_uploaded_file($file_array['tmp_name'],$file_dir.$file_array['name']) or die ("Couldn't copy");

steveday21

Thank you for your help. I've made some progress and now I am seeing the echo output;

path:
name: Becky Camera- xmas08-June1109 001.jpg
type:
size: 0

The is no evidence of the file being moved to the folder;

$file_dir = "C:\Program Files\Apache Software Foundation\Apache2.2\htdocs\test\";

I think this may be down to write permissions or something but need to do more research. If you can help I'd be grateful but appreciate that I need to learn and understand that you might not want to re-write the whole script for me.

Thanks again.

bradgrafelman

The problem is that using a backslash in a double-quoted string signifies that you're using a special escape sequence, e.g. "\n" gets replaced with the new line character. See the manual page for a [man]string[/man] to read more about this.

The solution would be: a) use single-quoted strings for file paths; b) escape the backslashes; or c) don't use backslashes (Windows can understand forward slashes just fine).