move_uploaded_file doesn't work with no errors or warnings....urgent

Seraphinox

Hello everyone,

So I have recently run into a conundrum with a script I am writing for someone. The script was written to upload a file, but when I go and execute it it doesn't want to move the file that was uploaded and returns no errors, warnings, or anything. And the array displays that everything is in order. Below is how the print_r of the $_FILES array looks:

Array ( [imagefile] => Array ( [name] => acoustic.JPG [type] => image/jpeg [tmp_name] => /tmp/php5J8rXy [error] => 0 [size] => 35694 )

As you can see, everything is there. Now, moving forward, below is my upload code. Like I said, it returns absolutely no errors, and the CHMOD is set up properly on the target directory. I am so frustrated with this script so any help would be appreciated. Thanks.

if ($_POST['action'] == "imageUpload") {
			$imageFile = $_FILES['imagefile']['name'];
			$imageFile_size = $_FILES['imagefile']['size'];
			$imageFile_type = $_FILES['imagefile']['type'];

		print_r($_FILES);

		//Check to make sure the image is a GIF or a JPEG
		if ($imageFile_type == "image/gif" || $imageFile_type == "image/jpeg" || $imageFile_type == "image/jpg" || $imageFile_type = "image/pjpeg")
		{
			if ($imageFile_size <= $_POST['MAX_FILE_SIZE'])
			{			
				//Check to make sure the file does not exist
				if (file_exists("$imageDir" . $imageFile))
					echo "The file already exists, please delete the existing image before uploading a new one.";
				else
				{
					//Insert the file into the database
					$insertQuery = "INSERT INTO picture ( `id`, `picture_name` ) VALUES ( '{$_REQUEST['id']}', '{$imageFile}' )";
					$query = mysql_query($insertQuery);

					//Upload the file
					move_uploaded_file($_FILES['imagefile']['tmp_name'], "$imageDir/$imageFile");
				}
			}
			else
			{
				echo "Error: This image exceeds the maximum file size of 40 MB.";
			}
		}
		else
		{
			echo "Error: This image must be of type GIF or JPEG.";
		}	
	}

Seraphinox

Oh, and I can confirm that the target directory is referenced properly as the associated link stored in the database goes to the proper location.

dagon

check target directories permissions.

Seraphinox

Seraphinox;10932333 wrote:
Hello everyone,

... and the CHMOD is set up properly on the target directory...

Already said that the permissions were fine in the first post. So that can't be the issue. Thanks though.

lsg1

Seraphinox;10932333 wrote:
Hello everyone,

So I have recently run into a conundrum with a script I am writing for someone. The script was written to upload a file, but when I go and execute it it doesn't want to move the file that was uploaded and returns no errors, warnings, or anything. And the array displays that everything is in order. Below is how the print_r of the $_FILES array looks:

Array ( [imagefile] => Array ( [name] => acoustic.JPG [type] => image/jpeg [tmp_name] => /tmp/php5J8rXy [error] => 0 [size] => 35694 )

As you can see, everything is there. Now, moving forward, below is my upload code. Like I said, it returns absolutely no errors, and the CHMOD is set up properly on the target directory. I am so frustrated with this script so any help would be appreciated. Thanks.
if ($_POST['action'] == "imageUpload") {
			$imageFile = $_FILES['imagefile']['name'];
			$imageFile_size = $_FILES['imagefile']['size'];
			$imageFile_type = $_FILES['imagefile']['type'];

		print_r($_FILES);

		//Check to make sure the image is a GIF or a JPEG
		if ($imageFile_type == "image/gif" || $imageFile_type == "image/jpeg" || $imageFile_type == "image/jpg" || $imageFile_type = "image/pjpeg")
		{
			if ($imageFile_size <= $_POST['MAX_FILE_SIZE'])
			{			
				//Check to make sure the file does not exist
				if (file_exists("$imageDir" . $imageFile))
					echo "The file already exists, please delete the existing image before uploading a new one.";
				else
				{
					//Insert the file into the database
					$insertQuery = "INSERT INTO picture ( `id`, `picture_name` ) VALUES ( '{$_REQUEST['id']}', '{$imageFile}' )";
					$query = mysql_query($insertQuery);

					//Upload the file
					move_uploaded_file($_FILES['imagefile']['tmp_name'], "$imageDir/$imageFile");
				}
			}
			else
			{
				echo "Error: This image exceeds the maximum file size of 40 MB.";
			}
		}
		else
		{
			echo "Error: This image must be of type GIF or JPEG.";
		}	
	}

Did you make sure that the form that invokes this code has enctype='multipart/form-data' in it?

dagon

lsg1;10932338 wrote:
Did you make sure that the form that invokes this code has enctype='multipart/form-data' in it?

$_FILES array would not be populated if this was the issue, in still inclined towards dir path\permission myself.

bradgrafelman

Your if() statement that checks for pre-existing files is not correct. This:

if (file_exists("$imageDir" . $imageFile))

would check paths like "foldernamefilename" which is obviously missing a separator character.

EDIT: Also, is any part of the script outputting anything? If not, it could be that there is a parse error and that you don't have display_errors set to On.

If there is some output, then at least it isn't a parse error. What level is your error_reporting set to? Did you try bumping it up to E_ALL?

Seraphinox

dagon;10932340 wrote:
$_FILES array would not be populated if this was the issue, in still inclined towards dir path\permission myself.

I can assure you that it is not a directory/permissions problem. That was the first thing I checked.

Also, in response to the person above me, I tried bumping my error reporting to maximum and all that but I still didn't get the script to output any errors. Also, I will take a look at my file exists function, but the problem is is that that shouldn't cause the problem when I actually go to upload the file (becuase I make sure the file is always gone when I go to test it).

Boy what I conundrum. But I will get back to you as soon as I test it further.

bradgrafelman

Not sure what else to suggest... check if move_upload_file() is returning false, in which case PHP must be outputting some type of error message (or at least trying to; it may be that you're suppressing it or not logging/displaying it).

Weedpacket

Have you double-checked the value of $imageDir? There's nothing in the posted code that sets it. If that's wrong then everything will upload fine but not to the place where you're looking for it.

Incidentally, "$imageDir" is redundant when $imageDir would work just as well. I'd also check the size of the uploaded file before checking the type, and use [man]getimagesize[/man] to verify the file's type ('cos you just can't trust what the client says).