[RESOLVED] Private variable

Connie_Goss

I am trying to build my first simple object. Everything is fine until I try to declare a private array variable in my class declaration. When I run the code, I get a "website cannot display the page" http 500 error. I have isolated the problem to the "Private" declaration. If I remove the word "private" it doesn't crash.

I am using windows xp, php version 5.2.5. Any ideas? 😕

laserlight

Post the smallest and simplest script that demonstrates the problem.

NogDog

Off-hand I can't imagine why that would cause a 500 error, which is normally generated by the web server before your PHP code even starts to execute. We may need to see some code to figure this out.

Connie_Goss

Here's the code. The red line is where it seems to bomb. If I remove the word "private" it does not crash.

SCRIPT #1:

require ('Cart.class.php');
session_start();
$_SESSION['cart'] = new Cart();

ETC.....

SCRIPT #2:

<?php
class Cart {}
{
// Create an array for holding the shopping cart contents
private $_contents = array();

// Add a product to the shopping cart
public function addProduct($proofno,$descript,$qty) {

// is proof already in cart? add if not
if (isset($this->contents[$proofno.$descript])) {
$this->contents[$proofno.$descript,2] += $qty ; // increase the quantity if it's already in cart
} else {
$this->_contents[$proofno.$descript] = array( $proof,$descript,$qty ); add image + size to cart if new
}
}
}
?>

Neville1985

Connie Goss;10932581 wrote:
<?php
class Cart {}
{
// Create an array for holding the shopping cart contents
private $_contents = array();

// Add a product to the shopping cart
public function addProduct($proofno,$descript,$qty) {

// is proof already in cart? add if not
if (isset($this->contents[$proofno.$descript])) {
$this->contents[$proofno.$descript,2] += $qty ; // increase the quantity if it's already in cart
} else {
$this->_contents[$proofno.$descript] = array( $proof,$descript,$qty ); add image + size to cart if new
}
}
}
?>

try this

class Cart 
{
	// Create an array for holding the shopping cart contents
	private $_contents = array();

// Add a product to the shopping cart
public function addProduct($proofno,$descript,$qty) {

	// is proof already in cart? add if not
	if (isset($this->_contents[$proofno.$descript])) { 
		$this->_contents[$proofno.$descript] += $qty ; // increase the quantity if it's already in cart
	} else {
		$this->_contents[$proofno.$descript] = array( $proofno,$descript,$qty ); //add image + size to cart if new
	}
}
}

Your class definition was not within the parentheses

class Cart {} //<-- the problem
 {
   // Create an array for holding the shopping cart contents
  private $_contents = array();
//etc etc etc
}
class Cart 
{

// Create an array for holding the shopping cart contents
  private $_contents = array();
//etc etc etc

}

and another problem in the code:

if (isset($this->_contents[$proofno.$descript])) { 
          $this->_contents[$proofno.$descript,2] += $qty ; //[$proofno.$descript,2] invalid
      }

If your trying to access index '2' of [$proofno.$descript] array, then try this

     if (isset($this->_contents[$proofno.$descript])) { 
          $this->_contents[$proofno.$descript][2] += $qty ;
      }

Hope this helps.

Connie_Goss

Thanks for the reply Neville. I made the corrections you pointed out but am still getting the same http 500 error. Now it won't run at all, "private" or not. Could this be a version problem, or someting in my PHP.INI?

Connie_Goss

RESOLVED! I must have accidentally deleted the comment slashes on the end of one of my lines. When I restored them (and made the other corrections you all pointed out) the problem went away. Thanks everyone.