[RESOLVED] ok.. i have no clue why so i need some help.

dariuc

i did about 5-6 hours of tinkering and error checking on a piece of code and i've eliminated everything i can think of.


function inflictAil()
{
if($currentprop=="serrated")
{
echo "hi";
}

}//end funct

all the functions on the page work with the exception of this one.

everytime i try to send a function that has conditional statements it wont work... and only the NEW functions i write do that. i've tried renaming, changing all the vars, etc.

made sure all the variables were working.

what im looking for is ideas on why the following wont work with ONLY this function

switch statements, if and if else

dagon

$currentprop is not being passed to the function, so unless its a global, the function inflictAil() cant access it.

function inflictAil($currentprop){
//snip
}

inflictAil($currentprop);

bradgrafelman

In other words, the variable $currentprop in your example may very well have been properly defined elsewhere in your code, but it wasn't in the variable scope of the function. dagon's snippet is one example of how to pass variables to functions as parameters.

For more information on what a variable scope is, see this manual page: [man]variables.scope[/man].

dariuc

i already tried that.
in fact i tried that several different ways.

in this code $currentprop is a global var.

and also as i mentioned earlier the code works in a completely different php file.

it's just that when i plug it into where it needs to work, it does nothing.

if i make the code so that it simply prints to the page like

echo "this";

it works fine.

as soon as i add in any type of IF or SWITCH statements the code doesn't work at all.
except for the switch statement, then the DEFAULT will show up.. but nothing else.

Also i have many other switch and if statements on this page.. they all work. I'm simply writing a function so i dont clutter the page anymore than i need to.

i also tried copy and pasting the switch code DIRECTLY into the spot i wanted it to go and it still doesn't work.

i tried testing it in places i didnt need it to work thinking it may just be something else i missed.

this function will be run inside another function. I'm aware of scope, which is why i made it global.

but the function it's set to run inside is an object function.

does that have anything to do with why the code won't work? i wouldnt think so because i wrote earlier code that works fine . a global function called in the local object function code.😕

laserlight

So, what did you try aside from what you originally posted?

dariuc

i've been working on this particular problem nonstop for 4 days. The project im working on is a fanbased project of mine.

this is what the code is supposed to look like

function inflictAil()
{

switch($currentprop)
{
case "serrated":
$ailToHit=rand(1,100);
if($ailToHit>=75)
{
echo " You inflicted a wound on your target! ";
$_SESSION['WOUNDBOOL2']=1;
}
else
{
echo " You nearly wound your opponent! ";
}
break;

case "drain":
$ailToHit=rand(1,100);
if($ailToHit>=50)
{
echo " Your attacks syphon stamina from the opponent. ";
$_SESSION['FATIGUEBOOL2']=1;
}
else
{
echo " You opponent is beginning to look tired! ";
}
break;

case "laced":
$ailToHit=rand(1,100);
if($ailToHit>=60)
{
echo " Your laced blade poisons the foe! ";
$_SESSION['POISONBOOL2']=1;
}
else
{
echo " Your blade drips with poison, one good strike will do it! ";
}
break;

case "seal":
$ailToHit=rand(1,100);
if($ailToHit>=85)
{
echo " You inflict chakra seal. ";
$_SESSION['SEALBOOL2']=1;
}
else
{
echo " One good strike will seal your opponent's chakra. ";
}

break;

}//end switch

}//end funct

I've taken to stepping thru my coding in order to find the problem spots.

so i stripped it all down and went to the bare minimum.

keep in mind that the code above works on ANY other page of my website. i have session start in place. all the includes i need.

when i stepped through it, echos worked fine.
the problem came when i set up an if statement, it would not output any print to the screen.

same for switch statements, only the default value will print to screen.

dagon

dariuc;10932814 wrote:
and also as i mentioned earlier the code works in a completely different php file.

so what is different between the files?

dagon

$currentprop is clearly not set, you don't show how or where it is set, but its not.

dariuc

the difference isn't anything to be honest.

one file is a brand spanking new file with all the necessary includes to get it to work.

the other is a file that has 1700 + lines of code in it.

it's a file that defines an object class and the functions specific to that object class.

in essense it's a battle program for a browser based game.

I thought that it was something wrong with the larger file, EXCEPT i wrote a function almost exactly like the one im having trouble with just a few hours before this occured.

which kinda rules out there being a problem with the larger file, especially since i've been using it all this time without any problems as well.

I'm wondering if there is a limit to the amount of info you can program on one single page file.

Or perhaps a limit to the number of conditional statements on a page?

dariuc

$currentprop is set. And you know how i know it's set? Because i echoed it to the page to make sure it had the correct value.

As i stated I CHECKED all of that.
i wouldn't even be posting here if it was something that simple.

dagon

echo it inside the function

dariuc

$currentprop is the value gained from querying a database table.

i echoed it to the main page to make sure it was set before i even wrote the program. it works when i echo it inside or outside the function.

i tried that (many times)

the problem isn't one your focusing on.

What I'd like to know is an answer for why php functions suddenly stop accepting conditional statements.

DOESN'T WORK

function inflictAil()
{
if($currentprop=="serrated")
{
echo "hi";
}

}//end

WORKS FINE


function inflictAil()
{

echo "hi";

}//end

see what i mean now?
I've established that it's not the variable that the if condition hinges on. I've replaced that variable and had the same results.

dagon

the 2nd one works fine becuse its not checking the value of a variable the first fails beause $currentprop is not set inside the function

echo "outside: ".$currentprop;

function inflictAil()
{

echo "inside: ".$currentprop;

}//end

dariuc

what im tryng to tell you is that regardless of whether it's inside or outside they both print to screen.

dariuc

wait. my bad. i see what i did.

i had the page echo the value. and i had the function run at the same time so it looked like two values popped up. after i added the outside and inside print i saw what you meant. my apologies sir.

dariuc

I'm very appreciative of your help.

And i now feel slightly more like a dolt. but thats okay because it's fixed. Thanks to all who took the time to respond.

dagon

posted before i saw you have fixed it, alls well that ends well.