Javascript onSubmit not working

[NZ_Kiwis]

this code submit even with no password or passwords not matching. why

<script type="text/javascript">

function ValdA(){
var user_input = document.Form1.Password.value;
var user_input2 = document.Form1.Password1.value;

if (user_input == user_input2){
document.Form1.SaveChanges.disabled=false;	
alert('Yes');
return true

} else {

if(user_input == ""){
alert('Please enter your password.')	
document.forms['Form1'].elements['Password'].focus();
document.Form1.SaveChanges.disabled=true;
return false

} else if(user_input2 == ""){

alert('Please confirm your password.')	
document.forms['Form1'].elements['Password1'].focus();
document.Form1.SaveChanges.disabled=true;
return false
}

}
</script>



<form action="includes/create_my_account.php" method="post" onSubmit="return ValdA() name="Form1" class="Font12" id="Form1">
  <p class="FontBold12">My Details</p>
  <p>
  <label>Username:
    <input name="Username" type="text" />
  </label>
  &nbsp;

  </p>
  <p><label>First Name: <input name="FirstName" type="text" /> <label>Last Name: <input name="LastName" type="text" /></label></label>&nbsp;</p>
  <p class="Font12">
    <label>New Password:
      <input name="Password" onchange="ValdA()" type="password" size="10" />
    </label>
    &nbsp;
    <label>Confirm New Password:
      <input name="Password1" type="password" onchange="ValdA()" size="10" />
    </label>
  </p>
  <p class="Font12">
    <label>Email Address:
      <input name="Email" type="text" size="50" />
    </label>
    <br />
  <p class="Font12">
    <label>Hide my personal details
      <input name="Personal" type="checkbox" value="1"> </label> 															
    <br />
    <label>Daily Mailer
      <input name="Mailer" type="checkbox" value="1"/>

</label>&nbsp;<br /><label>Help this website<input name="Help" type="checkbox" value="1"/></label>
  </p>
<p class="Font12"><label>I agree to all the Terms and Conditions of this website <input name="Terms" type="checkbox" value="1" /></label>&nbsp;</p>
<p class="Font12">
  <label>
    <input type="submit" name="SignUp" id="SignUp" value="Sign Up" />
  </label>
</p>
</form>

[Weedpacket]

I'm curious why you sometimes use the "document.forms['Form1'].elements['Password1']" form and sometimes use the older "document.Form1.Password1".

But more significantly, you've missed the closing quote on the onsubmit attribute. Also, there's no "SaveChanges" field in the form.

Then there's the missing '}' on the end. If the function has a syntax error, then it doesn't get defined, and calling it is therefore an error (as the JavaScript interpreter is probably reporting in the error console).

And are you sure you want this to fire every time the password field changes?

It will of course validate if both fields are blank, because if both fields are blank then they are equal.

[NZ_Kiwis]

okay I want to make sure both passwords are enterd and they match.

<script type="text/javascript">

function ValdA(){
var user_input = document.Form1.Password.value;
var user_input2 = document.Form1.Password1.value;

if(user_input == ""){
alert('Please enter your password.')	
document.forms['Form1'].elements['Password'].focus();
document.Form1.SignUp.disabled=true;
return false

} 

if(user_input2 == ""){

alert('Please confirm your password.')	
document.forms['Form1'].elements['Password1'].focus();
document.Form1.SignUp.disabled=true;
return false

};

if (user_input == user_input2 && user_input == ""){

alert('You must enter a password.')	
document.forms['Form1'].elements['Password1'].focus();
document.Form1.SignUp.disabled=true;
return false

}

if (user_input == user_input2 && user_input != ""){

//document.forms['Form1'].elements['Password1'].focus();
document.Form1.SignUp.disabled=false;
return true

}


};
</script>