[RESOLVED] Problem with reading fields from a database..

[msm206]

Hi,

I am a total newbie when it comes to PHP. My background is in ASP. However I have taken on a website for a customer which is written in a bespoke PHP package (by the previous developer).

Basically, it is a CMS where you are suppost to be able to edit the title, keywords and description in the admin system. However when I set something in the admin system, it doesn't show up on the public web pages. This is the following code which is supposed to retrive the meta data set by the user and stored in the database. However it doesn't seem to be working. There are default settings (as you will see below in lines 1-3). However if I comment (//) out lines 4-6, the proceeding lines do not set what is in the database as the title tag, meta desc, or keys. I can't see, from my point of view, anything wrong with the code, and I just wondered if any of you guys could help me out as to why the code on lines 7-25 isn't working? The data is in the database yet it just comes back with blank fields/data.

Look forward to hearing your suggestions. Matt

1 define ("PAGE_TITLETAG","Demo Titletag");
2 define ("PAGE_METAKEYS","Demo Metakeys");
3 define ("PAGE_METADESC","Demo Metadesc");
4 public $strTitleTag = PAGE_TITLETAG;
5 public $strMetaDesc = PAGE_METADESC;
6 public $strMetaKeys = PAGE_METAKEYS;

7 function __construct($intPage = 1){
8 session_start();
9 $this->objConn = mysql_connect(MYSQL_HOSTNAME,MYSQL_USERNAME,MYSQL_PASSWORD);
10 mysql_select_db(MYSQL_DATABASE,$this->objConn);
11 $this->strRssFile = 'rss/cache/bbc-world.xml';
12 $strQuery = "SELECT page_titletag,page_metadesc,page_metakeys,page_heading,page_body,page_section,page_action FROM page WHERE page_id=".$intPage;
13 $this->arrPage = mysql_fetch_assoc(mysql_query($strQuery));
14 $this->strUID = $_COOKIE['lib_log'];
15 if($this->arrPage['page_titletag'] != ''){
16 $strTitleTag = $this->arrPage['page_titletag'];
17 }
18 if($this->arrPage['page_metakeys'] != ''){
19 $strMetaKeys = $this->arrPage['page_metakeys'];
20 }
21 if($this->arrPage['page_metadesc'] != ''){
22 $strMetaDesc = $this->arrPage['page_metadesc'];
23 }
24 $this->startTask();
25 }

[msm206]

Sorry - this has come up as being resolved already for some reason. It isn't resolved so any help would still be appreciated. Matt

[NogDog]

Could you re-post the code here within [noparse]

...

[/noparse] tags (and no line numbers)? It will be much easier to read and will maintain any indenting that way.

[msm206]

Yes..here is the code...

define ("PAGE_TITLETAG","Demo Titletag");
define ("PAGE_METAKEYS","Demo Metakeys");
define ("PAGE_METADESC","Demo Metadesc");

public $strTitleTag = PAGE_TITLETAG;
public $strMetaDesc = PAGE_METADESC;
public $strMetaKeys = PAGE_METAKEYS;

public $intCallback = 0;

function __construct($intPage = 1){
	session_start();
	$this->_objConn = mysql_connect(MYSQL_HOSTNAME,MYSQL_USERNAME,MYSQL_PASSWORD);
	mysql_select_db(MYSQL_DATABASE,$this->_objConn);
	$this->strRssFile = 'rss/cache/bbc-world.xml';
	$strQuery = "SELECT page_titletag,page_metadesc,page_metakeys,page_heading,page_body,page_section,page_action FROM page WHERE page_id=".$intPage;
	$this->arrPage = mysql_fetch_assoc(mysql_query($strQuery));
	$this->strUID = $_COOKIE['lib_log'];
	if($this->arrPage['page_titletag'] != ''){
		$strTitleTag = $this->arrPage['page_titletag'];
	}
	if($this->arrPage['page_metakeys'] != ''){
		$strMetaKeys = $this->arrPage['page_metakeys'];
	}
	if($this->arrPage['page_metadesc'] != ''){
		$strMetaDesc = $this->arrPage['page_metadesc'];
	}
	$this->startTask();
}

[NogDog]

Took me a minute to realize this must be part of a class definition. Therefore I think all you need to do is to prepend $this-> to those variables when you use them within the function:

$this->strTitleTag = $this->arrPage['page_titletag'];

Otherwise (using just $strTitleTag) you are using a variable local only to that function.

[msm206]

Thankyou very much. That worked a treat. Cheers. Matt