PHP contact form help

[Tali]

Hi,
I have a contact form , which works fine except 1 thing - from time to time it sends empty emails. I have my emails address as CC every time someone sends response.

I searched the web and saw similar problem, so changed my code accordingly , but still receive empty ones.

This is the code I had first:
<?php
$subject = 'Form Submission from Business Exchange';

$emailadd = $POST['recipient'];

$emailcompany = $POST['company'];

$realname = $POST['realname'];
$email = $POST['email'];
$phone = $POST['phone'];
$text = $POST['text'];
$emailother = 'bcc:[e-mail]';
$url = ''; // Where to redirect after form is processed.
$req = '1'; // Makes all fields required. If set to '1' no field can not be empty. If set to '0' any or all fields can be empty.

// --------------------------Do not edit below this line--------------------------
$text = "Results from form $emailcompany:\n\n";

$space = ' ';
$line = '
';

if(!$email == "" && (!strstr($email,"@") || !strstr($email,".")))
{
echo "<h2>Enter valid e-mail</h2>\n";
$badinput = "<h2>Feedback was NOT submitted</h2>\n";
echo $badinput;
die ("Go back! ! ");
}

if(empty($realname) || empty($email) || empty($text )) {
echo "<h2>Fill in all fields</h2>\n";
die ("Go back! ! ");
}

foreach ($_POST as $key => $value)
{
/if ($req == '1')
{
if ($value == '')
{echo "<font color='white'$key field is empty</font>";die;}
}/

$j = strlen($key);
	if ($j >= 20)
	{echo "Name of form element $key cannot be longer than 20 characters";die;}
$j = 20 - $j;
	for ($i = 1; $i <= $j; $i++)
	{$space .= ' ';}
$value = str_replace('\n', "$line", $value);
$conc = "{$key}:$space{$value}$line";
$text .= $conc;
$space = '  ';

}
mail($emailadd, $subject, $text, 'From: '.$emailadd.'');
mail($emailother, $subject, $text, 'From: '.$emailother.'');
echo "<font color='red'>You message was sent successfully</font>";
?>
This is the second version, that not supposed to send empty emails:
<?php
$errors = array();

           if(empty($_POST['realname'])){
        $errors[] = 'Please enter your name';

     } else {

        echo  "";
     }


     if(empty($_POST['email'])){
        $errors[] = 'Please enter your email';

     } else {

        echo "";

     }

     if(empty($_POST['text'])){
        $errors[] = 'Please enter your comments';

     } else {
        echo  "";
     }


        $emailPattern = '/^[^@\s]+@([-a-z0-9]+\.)+[a-z]{2,}$/i';

$subject = 'Form Submission from Business Exchange'; // Subject of email sent to you.
$emailadd = safe($POST['recipient']); // Your email address. This is where the form information will be sent.
$emailcompany = safe($POST['company']); //Company name it's coming from
$name = safe(stripslashes($POST['realname']));
$email = safe($POST['email']);
$phone = safe($POST['phone']);
$comments = safe(stripslashes($POST['text']));
$emailother = 'bcc:[e-mail]';

$text = "Results from form $emailcompany:\n\n";

	 $message .= "Results from form " . $emailcompany . "\n\n";
     $message .= "Name:  " . $name . "\n";
     $message .= "Email: " . $email . "\n";
     $message .= "Phone Number: " . $phone . "\n\n";
     $message .= "Message:  " . $comments . "\n\n";

if (count($errors) < 1){
mail($emailadd, $subject, $message, 'From: '.$emailadd.'');
mail($emailother, $subject, $message, 'From: '.$emailother.'');

    echo "<font color='red'>Thank you so much for your Inquiry. Your message was sent successfully</font>"; 
  } else { 
    echo "<font color='red'>Feedback was NOT submitted. Fill in all fields</font>"; 
  }  

function safe($string)
{
$pattern = "/\r|\n|\%0a|\%0d|Content-Type😐bcc😐to😐cc:/i";
return preg_replace($pattern, '', $string);
}

?>

Thank you in advance

Will appreciate your help

Tali

[Weedpacket]

Please use the formatting tags described in the FAQ to make your posts easier to read; thank you.

[big_nerd]

In order to easily figure out where the issue is, before sending it to yourself, add the following info to the email going to YOU only:

1) The errors array [you never know]
2) A Copy of the $_POST array

if (count($errors) < 1){
mail($emailadd, $subject, $message, 'From: '.$emailadd.'');
// before you send to yourself
$message .= printf('<pre>&#37;s</pre>',printf($errors,true));
$message .= printf('<pre>%s</pre>',printf($_POST,true));
mail($emailother, $subject, $message, 'From: '.$emailother.'');

Also, when you do things like:

if(empty($_POST['realname'])){
  $errors[] = 'Please enter your name';
} else {
  echo "";
}

It is a waste to have that else echo statement, you can also try the following:

if(empty(trim($_POST['realname'])) || strlen(trim($_POST['realname'])) <= 1){
   $errors[] = 'Please enter your name';
}

This is because if someone even enters a space or some other null character it will come out 'empty' although to PHP it isnt (there is a space).

trim() removes any leading & trailing spaces (which means, if it was ALL spaces, it will NULL/empty the string

And as you can guess, strlen() gets the length of the string, a name has to be at least 2 char's, at least thats the shortest name I've ever seen, so if its 1 or less char's, then error out.

You can do the same/similar for the other fields (if this works).

Best of luck

[Tali]

Hi big.nerd,
Thanks for your reply.
I added the code you suggested, but after sending, it shows just empty page. Nothing on it. I didnt receive any email as well

Thanks

Tali

[big_nerd]

There may be an error in the code,

At the very top of the page that blank, do the following:

error_reporting(E_ALL);
ini_set('display_errors',1);

And try agian, see if it points out a syntax error or something of the sort.

[Tali]

I put the code on the page which was blank.
Doesn't display any errors or syntax error.

Thanks

[dagon]

post your full current code.

[Tali]

Hi dagon,

Thanks for your response.
This is mail.php I had before
<?php
include 'bus_var.php';
?>

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta name="generator" content="HTML Tidy for Windows (vers 15 August 2007), see www.w3.org" />
<title>
Business Exchange &amp; Real Estate Exchange - Buy or Sell a Business, Franchise or Home in Canada
</title>

<link href="css/styles.css" rel="stylesheet" type="text/css" /><!-- Tracker Code Start -->

</head><?php get_menu(); ?>
<body>
<div id="content">
<div class="body_col1">
<div class="margin">
<img src="img/arrow_icon.png" alt="" />
</div>
<div class="cell_75per">

      <div class="page_title_text">
    Contact form
      </div>
    </div><br class="clear" />
    <div class="margin">
      &#160;&nbsp;
    </div>
    <div class="fra_cell">






  <?php
  $errors = array();

           if(empty($_POST['realname'])){
        $errors[] = 'Please enter your name';

     } else {

        echo  "";
     }


     if(empty($_POST['email'])){
        $errors[] = 'Please enter your email';

     } else {

        echo "";

     }

     if(empty($_POST['text'])){
        $errors[] = 'Please enter your comments';

     } else {
        echo  "";
     }


        $emailPattern = '/^[^@\s]+@([-a-z0-9]+\.)+[a-z]{2,}$/i';

$subject = 'Form Submission from Business Exchange'; // Subject of email sent to you.
$emailadd = safe($POST['recipient']); // Your email address. This is where the form information will be sent.
$emailcompany = safe($POST['company']); //Company name it's coming from
$name = safe(stripslashes($POST['realname']));
$email = safe($POST['email']);
$phone = safe($POST['phone']);
$comments = safe(stripslashes($POST['text']));
$emailother = 'bcc:[e-mail]';

$text = "Results from form $emailcompany:\n\n";

	 $message .= "Results from form " . $emailcompany . "\n\n";
     $message .= "Name:  " . $name . "\n";
     $message .= "Email: " . $email . "\n";
     $message .= "Phone Number: " . $phone . "\n\n";
     $message .= "Message:  " . $comments . "\n\n";

if (count($errors) < 1){
mail($emailadd, $subject, $message, 'From: '.$emailadd.'');
mail($emailother, $subject, $message, 'From: '.$emailother.'');

    echo "<font color='red'>Thank you so much for your Inquiry. Your message was sent successfully</font>"; 
  } else { 
    echo "<font color='red'>Feedback was NOT submitted. Fill in all fields</font>"; 
  }  

function safe($string)
{
$pattern = "/\r|\n|\&#37;0a|\%0d|Content-Type😐bcc😐to😐cc:/i";
return preg_replace($pattern, '', $string);
}

?>

    </div>


    <!--  -->
    <?php get_listings(); ?>
  </div><?php get_sidebar(); ?>
</div><?php get_footer(); ?>

This one when I added suggested code:
<?php
error_reporting(E_ALL);
ini_set('display_errors',1);
?>
<?php
include 'bus_var.php';
?>

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta name="generator" content="HTML Tidy for Windows (vers 15 August 2007), see www.w3.org" />
<title>
Business Exchange &amp; Real Estate Exchange - Buy or Sell a Business, Franchise or Home in Canada
</title>

<link href="css/styles.css" rel="stylesheet" type="text/css" /><!-- Tracker Code Start -->

</head><?php get_menu(); ?>
<body>
<div id="content">
<div class="body_col1">
<div class="margin">
<img src="img/arrow_icon.png" alt="" />
</div>
<div class="cell_75per">

      <div class="page_title_text">
    Contact form
      </div>
    </div><br class="clear" />
    <div class="margin">
      &#160;&nbsp;
    </div>
    <div class="fra_cell">






  <?php
  $errors = array();

          if(empty(trim($_POST['realname'])) || strlen(trim($_POST['realname'])) <= 1){

$errors[] = 'Please enter your name';
}

     if(empty($_POST['email'])){
        $errors[] = 'Please enter your email';

     } else {

        echo "";

     }

     if(empty($_POST['text'])){
        $errors[] = 'Please enter your comments';

     } else {
        echo  "";
     }


        $emailPattern = '/^[^@\s]+@([-a-z0-9]+\.)+[a-z]{2,}$/i';

$subject = 'Form Submission from Business Exchange'; // Subject of email sent to you.
$emailadd = safe($POST['recipient']); // Your email address. This is where the form information will be sent.
$emailcompany = safe($POST['company']); //Company name it's coming from
$name = safe(stripslashes($POST['realname']));
$email = safe($POST['email']);
$phone = safe($POST['phone']);
$comments = safe(stripslashes($POST['text']));
$emailother = ''; //bcc:[e-mail]

$text = "Results from form $emailcompany:\n\n";

	 $message .= "Results from form " . $emailcompany . "\n\n";
     $message .= "Name:  " . $name . "\n";
     $message .= "Email: " . $email . "\n";
     $message .= "Phone Number: " . $phone . "\n\n";
     $message .= "Message:  " . $comments . "\n\n";
	 // before you send to yourself

$message .= printf('<pre>%s</pre>',printf($errors,true));
$message .= printf('<pre>%s</pre>',printf($_POST,true));

if (count($errors) < 1){
mail($emailadd, $subject, $message, 'From: '.$emailadd.'');

echo "<font color='red'>Thank you so much for your Inquiry. Your message was sent successfully</font>";
} else {
echo "<font color='red'>Feedback was NOT submitted. Fill in all fields</font>";
}

function safe($string)
{
$pattern = "/\r|\n|\%0a|\%0d|Content-Type😐bcc😐to😐cc:/i";
return preg_replace($pattern, '', $string);
}

?>

    </div>


    <!--  -->
    <?php get_listings(); ?>
  </div><?php get_sidebar(); ?>
</div><?php get_footer(); ?>

Thanks

[dagon]

please read post 2, make it easy for other to help you, or they may not bother.

[Tali]

I hope that what you mean:

This is mail.php I had before

<?php
include 'bus_var.php';
?>

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
</head><?php get_menu(); ?>
<body>
<div id="content">
<div class="body_col1">
<div class="margin">
<img src="img/arrow_icon.png" alt="" />
</div>
<div class="cell_75per">

<div class="page_title_text">
Contact form
</div>
</div><br class="clear" />
<div class="margin">
 &nbsp;
</div>
<div class="fra_cell">






<?php
$errors = array();

if(empty($_POST['realname'])){
$errors[] = 'Please enter your name';

} else {

echo "";
}


if(empty($_POST['email'])){
$errors[] = 'Please enter your email';

} else {

echo "";

}

if(empty($_POST['text'])){
$errors[] = 'Please enter your comments';

} else {
echo "";
}


$emailPattern = '/^[^@\s]+@([-a-z0-9]+\.)+[a-z]{2,}$/i';



$subject = 'Form Submission from Business Exchange'; 
$emailadd = safe($_POST['recipient']); 
$emailcompany = safe($_POST['company']); 
$name = safe(stripslashes($_POST['realname']));
$email = safe($_POST['email']);
$phone = safe($_POST['phone']);
$comments = safe(stripslashes($_POST['text']));
$emailother = '[e-mail]';


$text = "Results from form $emailcompany:\n\n";

$message .= "Results from form " . $emailcompany . "\n\n";
$message .= "Name: " . $name . "\n";
$message .= "Email: " . $email . "\n";
$message .= "Phone Number: " . $phone . "\n\n";
$message .= "Message: " . $comments . "\n\n";

if (count($errors) < 1){
mail($emailadd, $subject, $message, 'From: '.$emailadd.'');
mail($emailother, $subject, $message, 'From: '.$emailother.'');

echo "<font color='red'>Thank you so much for your Inquiry. Your message was sent successfully</font>";
} else {
echo "<font color='red'>Feedback was NOT submitted. Fill in all fields</font>";
}

function safe($string)
{
$pattern = "/\r|\n|\&#37;0a|\%0d|Content\-Type:|bcc:|to:|cc:/i";
return preg_replace($pattern, '', $string);
}


?>

</div>

This one when I added suggested code:

<?php
error_reporting(E_ALL);
ini_set('display_errors',1);
?>
<?php
include 'bus_var.php';
?>

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>

</head><?php get_menu(); ?>
<body>
<div id="content">
<div class="body_col1">
<div class="margin">
<img src="img/arrow_icon.png" alt="" />
</div>
<div class="cell_75per">

<div class="page_title_text">
Contact form
</div>
</div><br class="clear" />
<div class="margin">
 &nbsp;
</div>
<div class="fra_cell">
<?php
$errors = array();

if(empty(trim($_POST['realname'])) || strlen(trim($_POST['realname'])) <= 1){
$errors[] = 'Please enter your name';
}


if(empty($_POST['email'])){
$errors[] = 'Please enter your email';

} else {

echo "";

}

if(empty($_POST['text'])){
$errors[] = 'Please enter your comments';

} else {
echo "";
}


$emailPattern = '/^[^@\s]+@([-a-z0-9]+\.)+[a-z]{2,}$/i';

$subject = 'Form Submission from Business Exchange'; 
$emailadd = safe($_POST['recipient']);
$emailcompany = safe($_POST['company']); 
$name = safe(stripslashes($_POST['realname']));
$email = safe($_POST['email']);
$phone = safe($_POST['phone']);
$comments = safe(stripslashes($_POST['text']));
$emailother = ''; //[e-mail]


$text = "Results from form $emailcompany:\n\n";

$message .= "Results from form " . $emailcompany . "\n\n";
$message .= "Name: " . $name . "\n";
$message .= "Email: " . $email . "\n";
$message .= "Phone Number: " . $phone . "\n\n";
$message .= "Message: " . $comments . "\n\n";
// before you send to yourself
$message .= printf('<pre>%s</pre>',printf($errors,true));
$message .= printf('<pre>%s</pre>',printf($_POST,true));

if (count($errors) < 1){
mail($emailadd, $subject, $message, 'From: '.$emailadd.'');

echo "<font color='red'>Thank you so much for your Inquiry. Your message was sent successfully</font>";
} else {
echo "<font color='red'>Feedback was NOT submitted. Fill in all fields</font>";
}

function safe($string)
{
$pattern = "/\r|\n|\%0a|\%0d|Content\-Type:|bcc:|to:|cc:/i";
return preg_replace($pattern, '', $string);
}


?>

</div>
...

Thanks

[Tali]

Today it went crazy - maybe 100 or 200 empty emails.

Thanks

Tali