php "for loop and i++"

[prkarpi]

I have this JS which is implemented in php file:

<script>
		var dsi = new Array("1","2","3");
		for(i=0;i<dsi.length;i++) {
			if(dsi[i] != id) $("#remix_player_"+dsi[i]).html(players[dsi[i]][1]);
		}
		$("#remix_player_"+id).html(players[id][0]);
	}

</script>

This is a simple array. The var dsi in the first line tells how many mp3 players JS will write on page - ("1","2","3"). Here is my problem. I want these numbers (1, 2, 3) to be dynamic. In other words, depending on the MySQL data pulled from db - for example if db only has one record - I want only "1" to be written in that JS array line - var dsi - new Array("1"); if two then two and so on. I tried and I got it working with for loop and i++, but the problem is that I don't need the comma after the last digit - and I can't get rid of that last comma. I am thinking that php array might do the trick, so far I had no luck. Any suggestions. Thank you.

[Weedpacket]

So show us how you got it with the for() loop and we'll be able to show you what changes to make.

Or if you've got an array then it's trivial; see [man]join[/man].

[prkarpi]

Thanks for reply weedpacket.

Here is the loop I came up with with i++:

		
<script>
var dsi = new Array(
<?php
$resultTwo = mysql_query($sql);
while($rowTwo = mysql_fetch_array($resultTwo)) {
$tracks = $rowTwo['m_nameTwo'];
#$first == "";
$incJS==2; $incJS<=$total_pages; $incJS++; 
echo ",\"" . $incJS . "\""; 
}
?>
);
		for(i=0;i<dsi.length;i++) {
			if(dsi[i] != id) $("#remix_player_"+dsi[i]).html(players[dsi[i]][1]);
		}
		$("#remix_player_"+id).html(players[id][0]);
	}

</script>

$total_pages - is a var that COUNT() all tracks by a user.

Here is the output it prints:

		
<script>
var dsi = new Array(
,"1","2","3","4","5","6","7","8","9","10");
		for(i=0;i<dsi.length;i++) {
			if(dsi[i] != id) $("#remix_player_"+dsi[i]).html(players[dsi[i]][1]);
		}
		$("#remix_player_"+id).html(players[id][0]);
	}

</script>

If I switch around commas and put it after incJS it will give me "1", "2", and end with a comma.
As for array, I was thinking about putting each record from db into it and then outputting it, but problem with comma still exists - as I imagine.

[Weedpacket]

prkarpi wrote:

As for array, I was thinking about putting each record from db into it and then outputting it, but problem with comma still exists - as I imagine.

No, that makes perfect sense. Like I said, have a look at [man]join[/man].

[prkarpi]

Weedpacket thanks. I this code now:

		
<script>
var dsi = new Array(
<?php
$resultTwo = mysql_query($sql);
while($rowTwo = mysql_fetch_array($resultTwo)) {
$tracks = $rowTwo['m_nameTwo'];

$incJS==2; $incJS<=$total_pages; $incJS++; 
$array = array("\"$incJS\"", '');
$comma_separated = join(',', $array);

echo $comma_separated;
...

</script>

I don't seem to be getting the right results still. The output I get is this:
var dsi = new Array("1","2","3","4","5","6","7","8","9","10",);

I tried various scenarios, but I think I am missing something here. I see that the problem is in array($incJS, '') that the '' outputs NULL following the comma. How can I get rid of NULL. Thanks again.

[Weedpacket]

Uh, yeah, that code is a mess. Is that supposed to be a [man]for[/man] loop there but missing half its bits? If it is, you do realise that (once it's fixed), because of where it is, it would run all the way through for every single record you get from the database?

And are you saying that it only needs to be 1, 2, 3, 4, 5, ... and the numbers don't have any other meaning (like they're not database record id numbers?). If that's the case you might as well build the array entirely in JavaScript, using PHP solely to write the size of the array.

[prkarpi]

I will answer your questions in steps as for your comments.

1. You are right, this is not a FOR loop, it is a WHILE loop. As long as bd has record (which by the way is limited to only 10 records per page or so) it needs to print those numbers accordingly.

2. The numbers do not have any meaning at all. For example if db has only one record, javascript only needs to print array("1") if there are two numbers then array("1","2") and so on.

It is a fairly simple while loop, but the comma at the end of the last number kills the entire javascript code.
I am starting to see what you saying about building entire code in JS, but my knowledge in JS is limited, that's why I have decided to do it in PHP. Any idea how to get rid of the last comma in the array through the use of PHP? Thanks again.

[Weedpacket]

prkarpi wrote:

1. You are right, this is not a FOR loop, it is a WHILE loop. As long as bd has record (which by the way is limited to only 10 records per page or so) it needs to print those numbers accordingly.

I was talking about this bit:

$incJS==2; $incJS<=$total_pages; $incJS++; 

JavaScript would still be simpler.

dsi = [];
for(i=0; i<<?php echo $count?>; i++) dsi[i]=i;

Whatever variable $count is supposed to be.

Of course, that's a pretty pointless array. dsi==i, so wherever you have dsi you could just use i instead.