[RESOLVED] Strict standards error

vertmonkee

I have a form which gets submited as post data. When I have put it on the live server IE7 is the only browser where the form does not submit.

I turned on error_reporting and got a long list of messages like this.

Strict Standards: var: Deprecated. Please use the public/private/protected modifiers in /var/www/html/xajax/xajax_core/xajax.inc.php on line 84

I searched around to see how to overcome the problem and everyone just says to turn off error reporting.

If I do this IE7 doesn't even recognise that I have submitted the form. All it does is refresh the screen.

Can anyone suggest how i can solve this?

Thanks for any help.

laserlight

Basically, it is stating that you are using a PHP 4 keyword that has been deprecated in favour of the public, private and protected keywords to specify access control for class members. A quick hack to fix the error messages would involve changing each use of var to public; a more comprehensive fix would involve examining the classes to see if you can change them to benefit from access control.

paulnaj

From what you've said, it seems that the file xajax.inc.php contains a old-style class that uses the var keyword, rather than the public keyword.

The manual entry for visibility says: Note: The PHP 4 method of declaring a variable with the var keyword is still supported for compatibility reasons (as a synonym for the public keyword). In PHP 5 before 5.1.3, its usage would generate an E_STRICT warning.

So I would suggest changing all instances of var with public (keeping a backup copy of the original file, of course).

Not sure why it only breaks IE7, though.

vertmonkee

Excellent, thanks for the quick responses. I've been going through the file and changing var to public which seems to be workign fine.

The other two error messages I get are

Strict Standards: Assigning the return value of new by reference is deprecated

This is the line of code
$xuf =& new xajaxUserFunction($xuf);

Strict Standards: is_a(): Deprecated. Please use the instanceof operator

This is the line of code
if (is_a($mResult, 'xajaxRequest'))

Do you mind telling me what I would need to change these to?

Thanks again you guys are a great help

paulnaj

Hi again,

You could look in the manual (which is only what I did). You have to look up 'instanceof' and PHP5 classes. See if you can work it out and come back if you run into problems.

I would keep in mind laserlight's comment, though. If you need 'strict' standards then tweaking these classes might just keep popping up errors - a rewrite of the class in the new style might be the only way in the end.

laserlight

vertmonkee wrote:
Strict Standards: Assigning the return value of new by reference is deprecated

This is the line of code
$xuf =& new xajaxUserFunction($xuf);

In PHP4, new xajaxUserFunction($xuf) would have returned an object, and this object would have been copied to $xuf, resulting in an unnecessary copy. As such, assigning/returning by reference was used to avoid this inefficiency. In PHP5, object variables actually hold object references, and new xajaxUserFunction($xuf) now returns an object reference, thus there is no reason to assign/return by reference.

The solution would be to change it to:

$xuf = new xajaxUserFunction($xuf);

vertmonkee wrote:
Strict Standards: is_a(): Deprecated. Please use the instanceof operator

This is the line of code
if (is_a($mResult, 'xajaxRequest'))

According to the latest news, is_a() has been "undeprecated", so there is actually no problem, heh. Still, you could change it to:

if ($mResult instanceof xajaxRequest)

vertmonkee wrote:
Do you mind telling me what I would need to change these to?

Notice that the error messages actually tell you roughly what to do 😉

vertmonkee

Thats great, I did start looking at the documentation and found the instance of but was having a couple of problems with that.

After your comments all the error message have gone thank you.