Smarty PHP Javascript integration

Lee_E31

Hi all,

I'm having a few issues integrating some code into an existing SMARTY/PHP installation, hopefully someone will be able to point us in the right direction...

Here goes, firstly I have the following code which allows a user to select an item from a dropdown list and update some totals based on the selection made, when I run this in isolation, everything is fine and calculates the totals as expected. The option list is generated from database entries.

[FONT="Courier New"]<?php
$db_host = 'localhost';
$db_user = 'root';
$db_pwd = 'password';
$totalcost = 0;
$ordercost = 10;
$e_delivery = 0;
$shipping_cost = 0;
$e_totalcost = $ordercost +$e_delivery;

$database = 'mydb';
$table = 'shipping';

if (!mysql_connect($db_host, $db_user, $db_pwd))
die("Can't connect to database");

if (!mysql_select_db($database))
die("Can't select database");

$result = mysql_query("SELECT * FROM {$table}");
if (!$result) {
die("Query to show fields from table failed");
}

$fields_num = mysql_num_fields($result);

echo "<h1>Table: {$table}</h1>";
echo "<table border='1'><tr>";

for($i=0; $i<$fields_num; $i++)
{
$field = mysql_fetch_field($result);
echo "<td>{$field->name}</td>";
}
echo "</tr>\n";

while($row = mysql_fetch_row($result))
{
echo "<tr>";

foreach($row as $cell)
    echo "<td>$cell</td>";

echo "</tr>\n";

}
mysql_free_result($result);

?>
<html>
<head>
<script>
<!--
var shipping = Array ();
<?
$sql = "SELECT shipping_id, shipping_cost FROM shipping";
$r = mysql_query($sql);
while($line = mysql_fetch_assoc($r)) {
?>
shipping[<?=$line['shipping_id']?>] = <?=$line['shipping_cost']?>;
<?
}
?>

function updatetotal() {

var ordercost = parseFloat(document.getElementById('ordercost').value);
var e_totalcost = document.getElementById('total');
var e_delivery = document.getElementById('delivery');
var shipping_cost = shipping[document.getElementById('delivery').value];

e_totalcost = shipping_cost + ordercost;
e_delivery = shipping_cost;

document.getElementById('shipping_cost').value = e_delivery; 
document.getElementById('e_totalcost').value = e_totalcost;

}
-->
</script>
<title>Populate Select List from db table</title>
</head>

<p>
<br> Your order total is: <input type='text' name='ordercost' id='ordercost' value=<?=$ordercost?>>
<br>
Delivery Costs: <input type='text' name='shipping_cost' id='shipping_cost' value=<?=$shipping_cost?>>
<br>
Total Due: <input type='text' name='e_totalcost' id='e_totalcost' value=<?=$e_totalcost?> >
</p>

<select name="delivery" id="delivery" onChange="updatetotal();">
<?php
$sql = "SELECT shipping_id, shipping_type FROM shipping";
$rs = mysql_query($sql);
while($row = mysql_fetch_array($rs))
{
echo "<option value=\"".$row['shipping_id']."\">".$row['shipping_type']."\n ";

}
?>
</select>
</form>
</body>
</html>[/FONT]

So far so good, however now stuck trying to integrate that into a SMARTY / PHP setup. In the tpl, the drop down list is generated using the following code:

[FONT="Courier New"]Delivery options:
<select name="shipping" id="shipping" onchange="updatetotal();">
{section name=i loop=$obj->mShippingInfo}
<option value="{$obj->mShippingInfo.shipping_id}">
{$obj->mShippingInfo.shipping_type}
</option>
{/section}[/FONT]

but not sure where to go from there, cannot get the variables to add, keeps generating an error. Also tried parsing into an if statement but still no luck, can anyone help?
thanks in advance.

Kudose

<?php
  $sql = "SELECT shipping_id, shipping_type FROM shipping";
  $rs = mysql_query($sql);
  $rows = array();
  while(($row = mysql_fetch_assoc($rs))
    $rows[] = $row;
  $smarty->assign("optValues", $rows)
?>
<select name="shipping" id="shipping" onchange="updatetotal();">
  {foreach from="optValues" key="i" item="row"}
  <option value="{$row.shipping_id}">{$row.shipping_type}</option>
  {/foreach}
</select>

That should do it ... untested.

johanafm

while(($rows[] = mysql_fetch_assoc($rs) !== FALSE){ }

That would also assign an element with false value to $rows.

while ($row = mysql_fetch_assoc($rs))
	$rows[] = $row;

Kudose

You're right. There was a typo. There should be a parenthesis after mysql_fetch_assoc($rs)

I've updated the code above.

johanafm

I actually wasn't commenting on the missing ) to deal with operator precedence, but rather the fact that the last time the condition is evaluated, mysql_fetch_assoc returns false and assigns false to the array, i.e.

$rows[] = false;

This means that there will be two errors in {foreach}, since {$row.shipping_id} and {$row.shipping_type} do not exist. That row will contain {$row[0]} with the value false.

Kudose

You're right again. That's what I get for posting after being up for 26 hours. I knew it looked funny when I typed it. :\

Lee_E31

thanks for prompt replies, however sadly getting parse errors, here's what i've got so far:

php:
if (!mysql_connect($db_host, $db_user, $db_pwd))
die("Can't Connect to database");
$sql = "SELECT shipping_id, shipping_cost FROM shipping";
$rs = mysql_query($sql);
$rows = array();
while(($rows[] = mysql_fetch_assoc($rs) !== FALSE){
$rows[] = $row;
$smarty->assign("optValues", $rows)
}

tpl:
Delivery options:
<select name="shipping" id="shipping" onchange="updatetotal();">
{foreach from="optValues" key="i" item="row"}
<option value="{$row.shipping_id}">{$row.shipping_type}</option>
{/foreach}
</select>

johanafm

Actually posting the reported error is a good idea. So is wrapping php code in php tags and properly indenting it.

This part looks funny

// should assign this to $row, not $rows.
// also, there is no need to actually specify !== false, but that's a matter of style
// and you were missing a parenthesis as kudose commented on his own code
/* finally, you assign $rows once to your smarty variable.
doing so once per row yields the same result (each next assignment overwrites the previous one),
but it is a total waste of efficiency. */
while($row = mysql_fetch_assoc($rs)){
	$rows[] = $row;
}
$smarty->assign("optValues", $rows)